Cut over-engineering found by a repo-wide audit
- Config: auth, services, logging, queue and database only repeated the
framework's own files and are gone; the others keep only the keys that
differ (app version, cache serializable_classes, session cookie name,
Markdown mail theme, the shares disk, three Octane values, Livewire's
pagination theme and payload guards).
- Email verification is removed: User never implemented MustVerifyEmail,
so it was never enforced, and SealShare has a single admin and no
registration. CreateNewUser goes with it.
- FileEncryptionService::encryptFile() and generateSalt() were only used
by tests; tests build files with encryptTestFile() in tests/Pest.php.
- The expiration options are defined once, as Share::EXPIRATIONS. "30 Days"
now lasts 30 days instead of a calendar month, and Admin settings only
save a default expiration that is one of the options.
- One-caller helpers are inlined, the uploader reads chunk responses with
XHR's responseType, and starter-kit leftovers are removed.
- Docker: PHP reads the PHP_* limits from the environment itself
(${VAR:-default} in uploads.ini); both entrypoints stop writing the ini.
docker-compose.yml shares the app and scheduler variables through one
anchor. The dev image installs gd for the screenshot publisher and fake
test images.
- Development runs in Docker only: the composer dev script, concurrently,
laravel/pail, laravel/sail, autoprefixer and the shell-quote override
are gone.
- phpunit.xml forces the test environment with <server> entries, so tests
run in the dev container no longer use its real database.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
a62edbcefb
commit
4530298398
+17
-25
@@ -1,3 +1,18 @@
|
||||
# What the app and the scheduler both need
|
||||
x-environment: &environment
|
||||
APP_KEY: ${APP_KEY:?Set APP_KEY in .env or environment}
|
||||
APP_URL: ${APP_URL:-http://localhost}
|
||||
APP_ENV: ${APP_ENV:-production}
|
||||
APP_DEBUG: ${APP_DEBUG:-false}
|
||||
DB_CONNECTION: ${DB_CONNECTION:-sqlite}
|
||||
DB_HOST: ${DB_HOST:-}
|
||||
DB_PORT: ${DB_PORT:-}
|
||||
DB_DATABASE: ${DB_DATABASE:-/app/database/sqlite/database.sqlite}
|
||||
DB_USERNAME: ${DB_USERNAME:-}
|
||||
DB_PASSWORD: ${DB_PASSWORD:-}
|
||||
LOG_CHANNEL: ${LOG_CHANNEL:-stderr}
|
||||
LOG_LEVEL: ${LOG_LEVEL:-warning}
|
||||
|
||||
services:
|
||||
app:
|
||||
image: gitea.nonameweb.ch/nonameweb/sealshare:latest
|
||||
@@ -15,20 +30,9 @@ services:
|
||||
- caddy_data:/data
|
||||
- caddy_config:/config
|
||||
environment:
|
||||
APP_KEY: ${APP_KEY:?Set APP_KEY in .env or environment}
|
||||
APP_URL: ${APP_URL:-http://localhost}
|
||||
APP_ENV: ${APP_ENV:-production}
|
||||
APP_DEBUG: ${APP_DEBUG:-false}
|
||||
<<: *environment
|
||||
AUTO_HTTPS: ${AUTO_HTTPS:-false}
|
||||
SERVER_NAME: ${SERVER_NAME:-localhost}
|
||||
DB_CONNECTION: ${DB_CONNECTION:-sqlite}
|
||||
DB_HOST: ${DB_HOST:-}
|
||||
DB_PORT: ${DB_PORT:-}
|
||||
DB_DATABASE: ${DB_DATABASE:-/app/database/sqlite/database.sqlite}
|
||||
DB_USERNAME: ${DB_USERNAME:-}
|
||||
DB_PASSWORD: ${DB_PASSWORD:-}
|
||||
LOG_CHANNEL: ${LOG_CHANNEL:-stderr}
|
||||
LOG_LEVEL: ${LOG_LEVEL:-warning}
|
||||
SESSION_DRIVER: ${SESSION_DRIVER:-database}
|
||||
QUEUE_CONNECTION: ${QUEUE_CONNECTION:-database}
|
||||
CACHE_STORE: ${CACHE_STORE:-database}
|
||||
@@ -60,19 +64,7 @@ services:
|
||||
volumes:
|
||||
- sealshare_storage:/app/storage/app
|
||||
- sealshare_database:/app/database/sqlite
|
||||
environment:
|
||||
APP_KEY: ${APP_KEY:?Set APP_KEY in .env or environment}
|
||||
APP_URL: ${APP_URL:-http://localhost}
|
||||
APP_ENV: ${APP_ENV:-production}
|
||||
APP_DEBUG: ${APP_DEBUG:-false}
|
||||
DB_CONNECTION: ${DB_CONNECTION:-sqlite}
|
||||
DB_HOST: ${DB_HOST:-}
|
||||
DB_PORT: ${DB_PORT:-}
|
||||
DB_DATABASE: ${DB_DATABASE:-/app/database/sqlite/database.sqlite}
|
||||
DB_USERNAME: ${DB_USERNAME:-}
|
||||
DB_PASSWORD: ${DB_PASSWORD:-}
|
||||
LOG_CHANNEL: ${LOG_CHANNEL:-stderr}
|
||||
LOG_LEVEL: ${LOG_LEVEL:-warning}
|
||||
environment: *environment
|
||||
depends_on:
|
||||
app:
|
||||
condition: service_healthy
|
||||
|
||||
Reference in New Issue
Block a user