6 Commits
Author SHA1 Message Date
Andreas Reinhold / reiniandClaude Opus 5.5 f597181f91 Release 2.4.0
docker / build-and-push (push) Successful in 9m42s
docker / test (8.5) (push) Successful in 3m22s
docker / release (push) Successful in 5s
linter / quality (push) Successful in 1m2s
tests / ci (8.5) (push) Successful in 3m19s
Large shares download reliably: "Download all to a folder" saves the
files one at a time into a folder the recipient picks, resuming where a
connection broke off, and single-file downloads answer Range requests.
The ZIP sends its size, and downloads no longer stop after 5 minutes.

The download page shows the file count and total size and marks the
files already downloaded; the upload page gains "Browse Folder".

Every dependency is up to date (Laravel 13.35, Livewire 4.4.7, Vite
8.3.4), which closes three security advisories, and the Gitea workflows
run on Node 24 actions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 23:28:23 +02:00
Andreas Reinhold / reiniandClaude Opus 5.5 30a485f5d9 Mark the file the folder download is on
During "Download all to a folder" the recipient saw only the file name
under the progress bar. The file's row in the list now shows the loading
indicator while it is on its way, and the list scrolls that row into
view, so a run through hundreds of files can be followed in the list.
The row is scrolled rather than the indicator, which is still hidden
when the run moves on to the file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 23:28:23 +02:00
Andreas Reinhold / reiniandClaude Opus 5.5 6578335568 Fix the security audit's findings
ShareDownload::$authenticated was a public property without #[Locked],
so a visitor with a share's link but not its password could set it from
the browser and see the file list: names, folder paths, sizes and
whether the share holds a text. The contents stayed protected; the flag
is now locked, and a test tries to set it.

Sessions hold the keys of the password shares a recipient unlocked, and
were stored unencrypted in the sessions table wherever SESSION_ENCRYPT
was not set, which includes every Docker install. They are now
encrypted unless SESSION_ENCRYPT=false. Share keys never live in the
session, so every share stays readable; people sign in again once.

The container generated an APP_KEY when none was set, printed it to the
logs and generated another on the next start, which left the shares
without a password unreadable. It now refuses to start without one and
says how to create it; docker-compose.example.yml requires it for both
services. The command it names, and the README's, now pass
--entrypoint php: the image's entrypoint ignores its arguments, so
"docker run <image> php artisan key:generate --show" never ran it.

Every proxy is trusted, so the password-reset mail built its link from
a host a forged X-Forwarded-Host could choose. It is now built from
APP_URL.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 23:23:00 +02:00
Andreas Reinhold / reiniandClaude Opus 5.5 6c3202a0cf Scroll a long file list on the download page on its own
A share with hundreds of files made the download page as tall as its
list, so the recipient scrolled far past the buttons. The list now sits
in .share-file-list, capped at min(32rem, 60dvh) with its own scroll, as
the upload page's selected-files list already is; the download buttons
stay on the first screen.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 22:40:34 +02:00
Andreas Reinhold / reiniandClaude Opus 5.5 63bae2d1a6 Update dependencies
Composer: Laravel 13.35, Livewire 4.4.7, Octane 2.21, Fortify 1.41,
Boost 2.10.3 and Pest 5.3.1, with the packages they bring (51 in all,
brick/math to 1.0). league/commonmark 2.10.3 closes a high and a medium
advisory. npm: Vite 8.3.4 and Playwright 1.64; npm audit fix updates
source-map-js past a high advisory. Both audits are now clean.

Boost's update rewrote its guidelines in CLAUDE.md and four skills.

The Gitea workflows move to the current majors of checkout, setup-node
and the Docker actions, which run on Node 24 instead of the end-of-life
Node 20. QEMU stays pinned to 9.2.2: 10.2 still segfaults on the arm64
runner.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 21:28:45 +02:00
Andreas Reinhold / reiniandClaude Opus 5.5 b594fb2300 Download large shares file by file, resumably
A 29 GB share with 254 files failed as one ZIP: the single request ran
into the 300-second request limit and, behind a proxy we cannot
configure, could be cut at any time with no way to resume.

Single-file downloads now answer HTTP Range requests (206, ETag and
If-Range, 416 past the end): a SEALCHK2 file is decrypted from the chunk
holding the first byte asked for. On that, the download page's new
"Download all to a folder" (File System Access API, Chrome and Edge on a
computer) saves every file into a folder the recipient picks, one
request per file, in its folder path; a broken connection is retried
from the byte on disk, complete files are skipped, and failed files get
a Retry button. Other browsers keep the ZIP and the per-file buttons.

The ZIP is sized up front with ZipStream's strict simulation and sent
with Content-Length, so the browser shows progress and notices a cut.
Both download routes lift the time limit for their streams.

The recipient's download window now restarts with each download, so a
long file-by-file download never outlasts it. The download page shows
the file count and total size and marks the files this browser has
downloaded, and the upload page gains "Browse Folder", which keeps each
file's path as a dropped folder does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 21:20:35 +02:00
31 changed files with 1249 additions and 571 deletions
+1 -1
View File
@@ -1,6 +1,6 @@
--- ---
name: infer-conventions name: infer-conventions
description: "Use this skill to analyze how a Laravel application is actually written and record its conventions as shared rules. Trigger when the user wants to detect, infer, document, or standardize project conventions or coding style, set up or grow `.ai/rules`, resolve mixed or conflicting patterns (e.g. \"are we using Form Requests or inline validation?\"), or onboard agents and teammates to \"how we do things here\". Covers: a systematic sweep of ~49 Laravel convention dimensions (validation, models, architecture, testing, frontend, database, console), open-ended house-pattern discovery, conflict reporting, and recording rules scoped to the right paths via the Boost `record-rule` MCP tool. Only run this skill when the user explicitly asks for it; never start a sweep as part of another task. Do not use for one-off code review, enforcing formatting a linter already handles, or editing `.ai/rules` files by hand." description: "Use this skill to analyze how a Laravel application is actually written and record its conventions as shared rules. Trigger when the user wants to detect, infer, document, or standardize project conventions or coding style, set up or grow `.ai/rules`, resolve mixed or conflicting patterns (e.g. \"are we using Form Requests or inline validation?\"), or onboard agents and teammates to \"how we do things here\". Covers: a systematic sweep of ~49 Laravel convention dimensions (validation, models, architecture, testing, frontend, database, API responses), open-ended house-pattern discovery, conflict reporting, and recording rules scoped to the right paths via the Boost `record-rule` MCP tool. Only run this skill when the user explicitly asks for it; never start a sweep as part of another task. Do not use for one-off code review, enforcing formatting a linter already handles, or editing `.ai/rules` files by hand."
disable-model-invocation: true disable-model-invocation: true
license: MIT license: MIT
metadata: metadata:
@@ -9,11 +9,11 @@ Each item gives the fork, then a hint (a grep or dir to spot which side the app
## A. Validation & HTTP input ## A. Validation & HTTP input
1. Validation entry point: inline `$request->validate()` vs Form Request classes vs `Validator::make()`. 1. Validation entry point: inline `$request->validate()` vs Form Request classes vs `Validator::make()`.
- Hint: `ls app/Http/Requests`; grep `->validate(` / `Validator::make(` in `app/Http/Controllers`. - Hint: `ls app/Http/Requests`; grep -- `->validate(` / `Validator::make(` in `app/Http/Controllers`.
2. Custom rule location: invokable rule objects in `app/Rules` vs inline closures vs `Validator::extend()` in a provider. Rule objects are the default `make:rule` path, so record only if the app leans on closures or `Validator::extend` instead. "No rule objects" alone is just no-signal. 2. Custom rule location: invokable rule objects in `app/Rules` vs inline closures vs `Validator::extend()` in a provider. Rule objects are the default `make:rule` path, so record only if the app leans on closures or `Validator::extend` instead. "No rule objects" alone is just no-signal.
- Hint: `ls app/Rules`; grep `Validator::extend` in `app/Providers`. - Hint: `ls app/Rules`; grep `Validator::extend` in `app/Providers`.
3. Typed input retrieval: typed getters (`$request->string()`, `->integer()`, `->enum()`, `->date()`) vs raw `$request->input()` / dynamic properties. 3. Typed input retrieval: typed getters (`$request->string()`, `->integer()`, `->enum()`, `->date()`) vs raw `$request->input()` / dynamic properties.
- Hint: grep `->string(` / `->integer(` / `->enum(` vs `->input(` in `app/Http`. - Hint: grep -- `->string(` / `->integer(` / `->enum(` vs `->input(` in `app/Http`.
4. Custom messages/attributes: `lang/*/validation.php` vs Form Request `messages()` / `attributes()` methods. 4. Custom messages/attributes: `lang/*/validation.php` vs Form Request `messages()` / `attributes()` methods.
- Hint: `ls lang`; grep `function messages`, `function attributes` in `app/Http/Requests`. - Hint: `ls lang`; grep `function messages`, `function attributes` in `app/Http/Requests`.
@@ -26,7 +26,7 @@ Each item gives the fork, then a hint (a grep or dir to spot which side the app
7. Route handler style: closures in `routes/*.php` vs controller classes. 7. Route handler style: closures in `routes/*.php` vs controller classes.
- Hint: count `function ()` vs `::class` in `routes/web.php`, `routes/api.php`. - Hint: count `function ()` vs `::class` in `routes/web.php`, `routes/api.php`.
8. Middleware assignment: route/group `->middleware()` vs controller `HasMiddleware::middleware()` vs `#[Middleware]` attribute. 8. Middleware assignment: route/group `->middleware()` vs controller `HasMiddleware::middleware()` vs `#[Middleware]` attribute.
- Hint: grep `implements HasMiddleware`, `#[Middleware(` in controllers vs `->middleware(` in routes. - Hint: grep -- `implements HasMiddleware`, `#[Middleware(` in controllers vs `->middleware(` in routes.
9. Route model binding: implicit (type-hinted models) vs explicit `Route::bind` vs manual `findOrFail`. 9. Route model binding: implicit (type-hinted models) vs explicit `Route::bind` vs manual `findOrFail`.
- Hint: typed model params in signatures vs `findOrFail(` in controllers; grep `Route::bind`. - Hint: typed model params in signatures vs `findOrFail(` in controllers; grep `Route::bind`.
10. Rate limiting: named `RateLimiter::for()` + `throttle:name` vs inline `throttle:60,1`. 10. Rate limiting: named `RateLimiter::for()` + `throttle:name` vs inline `throttle:60,1`.
@@ -37,7 +37,7 @@ Each item gives the fork, then a hint (a grep or dir to spot which side the app
11. Authorization home: Gates (`Gate::define`) vs Policy classes in `app/Policies`. 11. Authorization home: Gates (`Gate::define`) vs Policy classes in `app/Policies`.
- Hint: `ls app/Policies`; grep `Gate::define` in `app/Providers`. - Hint: `ls app/Policies`; grep `Gate::define` in `app/Providers`.
12. Authorization call site: `$this->authorize()` / `Gate::authorize()` vs `$user->can()` vs `can` middleware vs `#[Authorize]` vs `@can` in Blade. 12. Authorization call site: `$this->authorize()` / `Gate::authorize()` vs `$user->can()` vs `can` middleware vs `#[Authorize]` vs `@can` in Blade.
- Hint: grep `authorize(`, `->can(`, `middleware('can:`, `#[Authorize(`, `@can(`. - Hint: grep -- `authorize(`, `->can(`, `middleware('can:`, `#[Authorize(`, `@can(`.
## D. Eloquent & models ## D. Eloquent & models
@@ -56,7 +56,7 @@ Each item gives the fork, then a hint (a grep or dir to spot which side the app
19. Model events: observers (`app/Observers`, `#[ObservedBy]`) vs `booted()` closures vs event classes. 19. Model events: observers (`app/Observers`, `#[ObservedBy]`) vs `booted()` closures vs event classes.
- Hint: `ls app/Observers`; grep `booted`, `::observe`, `#[ObservedBy]`. - Hint: `ls app/Observers`; grep `booted`, `::observe`, `#[ObservedBy]`.
20. Eager-load posture: explicit per-query `->with()` vs model-level `$with` defaults. Treat `preventLazyLoading()` separately as a development guard because it can complement either posture. 20. Eager-load posture: explicit per-query `->with()` vs model-level `$with` defaults. Treat `preventLazyLoading()` separately as a development guard because it can complement either posture.
- Hint: grep `protected $with`, `->with(`, and separately `preventLazyLoading` in `app/`. - Hint: grep -- `protected $with`, `->with(`, and separately `preventLazyLoading` in `app/`.
## E. Architecture & organization ## E. Architecture & organization
@@ -91,11 +91,11 @@ This app ships a frontend stack, so the items below apply.
## G. Database & migrations ## G. Database & migrations
33. Foreign keys: `foreignId()->constrained()` vs `foreignIdFor(Model::class)` vs manual `foreign()->references()->on()`. 33. Foreign keys: `foreignId()->constrained()` vs `foreignIdFor(Model::class)` vs manual `foreign()->references()->on()`.
- Hint: grep `foreignId(`, `foreignIdFor(`, `->foreign(` in `database/migrations`. - Hint: grep -- `foreignId(`, `foreignIdFor(`, `->foreign(` in `database/migrations`.
34. `down()` methods: real reverse logic vs omitted / one-way migrations. 34. `down()` methods: real reverse logic vs omitted / one-way migrations.
- Hint: grep `function down` vs the migration count. - Hint: grep `function down` vs the migration count.
35. Enum storage: DB `enum()` column vs `string()` + PHP-enum cast on the model. 35. Enum storage: DB `enum()` column vs `string()` + PHP-enum cast on the model.
- Hint: grep `->enum(` in migrations vs string columns cast to enums. - Hint: grep -- `->enum(` in migrations vs string columns cast to enums.
36. Transactions: `DB::transaction(fn ...)` closure vs manual `beginTransaction` / `commit` / `rollBack`. 36. Transactions: `DB::transaction(fn ...)` closure vs manual `beginTransaction` / `commit` / `rollBack`.
- Hint: grep `DB::transaction`, `beginTransaction` in `app/`. - Hint: grep `DB::transaction`, `beginTransaction` in `app/`.
37. Idempotent writes: `upsert` / `updateOrCreate` / `firstOrCreate` vs find-then-save. 37. Idempotent writes: `upsert` / `updateOrCreate` / `firstOrCreate` vs find-then-save.
@@ -110,14 +110,14 @@ This app ships a frontend stack, so the items below apply.
40. Fixtures: compare how equivalent test-owned records are created, such as factories vs manual inserts. Track seeders separately for shared reference data because `$this->seed()` commonly and legitimately coexists with factories. 40. Fixtures: compare how equivalent test-owned records are created, such as factories vs manual inserts. Track seeders separately for shared reference data because `$this->seed()` commonly and legitimately coexists with factories.
- Hint: grep `::factory(` and direct inserts in `tests/`; separately inspect `$this->seed(` calls and what those seeders provide. - Hint: grep `::factory(` and direct inserts in `tests/`; separately inspect `$this->seed(` calls and what those seeders provide.
41. Collaborator isolation: how the app doubles its own classes, Mockery `mock()` / `spy()` vs real integration. Ignore facade fakes like `Mail::fake()` here, they isolate framework services by default and are not a fork against Mockery. 41. Collaborator isolation: how the app doubles its own classes, Mockery `mock()` / `spy()` vs real integration. Ignore facade fakes like `Mail::fake()` here, they isolate framework services by default and are not a fork against Mockery.
- Hint: grep `->mock(`, `->spy(`, `Mockery::` in `tests/`. - Hint: grep -- `->mock(`, `->spy(`, `Mockery::` in `tests/`.
42. Endpoint assertions: array `assertJson([...])` / `assertJsonFragment` vs fluent `AssertableJson`. 42. Endpoint assertions: array `assertJson([...])` / `assertJsonFragment` vs fluent `AssertableJson`.
- Hint: grep `AssertableJson`, `assertJsonFragment` in `tests/`. - Hint: grep `AssertableJson`, `assertJsonFragment` in `tests/`.
## I. Responses & API resources ## I. Responses & API resources
43. Response shape: API Resource classes vs `response()->json()` vs returning models/arrays directly. 43. Response shape: API Resource classes vs `response()->json()` vs returning models/arrays directly.
- Hint: `ls app/Http/Resources`; grep `JsonResource`, `->json(` in controllers. - Hint: `ls app/Http/Resources`; grep -- `JsonResource`, `->json(` in controllers.
44. Resource relationship inclusion: `whenLoaded()` guards vs unconditional relationship access. Do not count ordinary scalar attributes as rivals to conditional relationships, and evaluate general `when()` fields separately. 44. Resource relationship inclusion: `whenLoaded()` guards vs unconditional relationship access. Do not count ordinary scalar attributes as rivals to conditional relationships, and evaluate general `when()` fields separately.
- Hint: compare relationship fields using `whenLoaded(` with unconditional relationship property access in `app/Http/Resources`. - Hint: compare relationship fields using `whenLoaded(` with unconditional relationship property access in `app/Http/Resources`.
45. Pagination contracts: within comparable endpoint categories, length-aware `paginate()` vs `simplePaginate()` vs `cursorPaginate()`. These have different totals, navigation, ordering, and performance contracts, so record only a stable path-scoped API policy, never a project-wide majority. 45. Pagination contracts: within comparable endpoint categories, length-aware `paginate()` vs `simplePaginate()` vs `cursorPaginate()`. These have different totals, navigation, ordering, and performance contracts, so record only a stable path-scoped API policy, never a project-wide majority.
@@ -128,7 +128,7 @@ This app ships a frontend stack, so the items below apply.
## J. Strings, collections & dates ## J. Strings, collections & dates
47. Iteration idiom: `collect()->map()->filter()` pipelines vs `array_map` / `foreach`. 47. Iteration idiom: `collect()->map()->filter()` pipelines vs `array_map` / `foreach`.
- Hint: grep `collect(`, `->map(` vs `array_map`, `foreach` density in `app/`. - Hint: grep -- `collect(`, `->map(` vs `array_map`, `foreach` density in `app/`.
48. String API: fluent `Str::of()->...` (Stringable) vs static `Str::` vs native (`trim`, `strtoupper`). 48. String API: fluent `Str::of()->...` (Stringable) vs static `Str::` vs native (`trim`, `strtoupper`).
- Hint: grep `Str::of(` vs `Str::` vs native string funcs. - Hint: grep `Str::of(` vs `Str::` vs native string funcs.
49. Dates: compare equivalent construction call styles (`now()` / `today()` helpers vs `Carbon::`) separately from the application's mutable/immutable date policy. `Date::use(CarbonImmutable::class)` can make helpers return immutable dates, so those signals are complementary rather than conflicting. 49. Dates: compare equivalent construction call styles (`now()` / `today()` helpers vs `Carbon::`) separately from the application's mutable/immutable date policy. `Date::use(CarbonImmutable::class)` can make helpers return immutable dates, so those signals are complementary rather than conflicting.
@@ -103,7 +103,7 @@ $posts = Post::query()
## Use Atomic Locks for Race Conditions ## Use Atomic Locks for Race Conditions
Use a lock when concurrent execution must be serialized. `Cache::lock()` provides an atomic lock when the configured cache store supports locks. `lockForUpdate()` locks selected database rows and must run inside a database transaction. These mechanisms solve different coordination problems. Use a lock when concurrent execution must be serialized. `Cache::lock()` provides an atomic lock when the configured cache store supports locks. `lockForUpdate()` locks selected database rows and must run inside a database transaction. These mechanisms solve different coordination problems. Set the lease (`10` below) longer than the callback can ever run: once it expires, another process can acquire the lock while the first is still working.
```php ```php
Cache::lock('order-processing-'.$order->id, 10)->block(5, function () use ($order) { Cache::lock('order-processing-'.$order->id, 10)->block(5, function () use ($order) {
@@ -26,7 +26,7 @@ Use the assertion in this table for each subject.
Use a PHPUnit assertion only if no Pest expectation and no Laravel assertion exists for the subject. Use a PHPUnit assertion only if no Pest expectation and no Laravel assertion exists for the subject.
Assert each fact once. Do not assert a 200 status before `assertSee`, because `assertSee` already shows that the page rendered. Assert each fact once, but status and content are separate facts. `assertSee` passes on an error page that contains the text, so keep `assertOk()` alongside it when the status is part of the behavior.
## Named Response Assertions ## Named Response Assertions
+9 -9
View File
@@ -24,7 +24,7 @@ jobs:
steps: steps:
- name: Checkout code - name: Checkout code
uses: actions/checkout@v6 uses: actions/checkout@v7
- name: Setup PHP - name: Setup PHP
uses: shivammathur/setup-php@v2 uses: shivammathur/setup-php@v2
@@ -35,7 +35,7 @@ jobs:
coverage: xdebug coverage: xdebug
- name: Setup Node - name: Setup Node
uses: actions/setup-node@v4 uses: actions/setup-node@v7
with: with:
node-version: "24" node-version: "24"
@@ -65,25 +65,25 @@ jobs:
needs: test needs: test
steps: steps:
- name: Checkout code - name: Checkout code
uses: actions/checkout@v6 uses: actions/checkout@v7
# The runner is an arm64 server, so the amd64 image's final stage is emulated. QEMU 8.x # The runner is an arm64 server, so the amd64 image's final stage is emulated. QEMU 8.x
# crashes running x86_64 programs on an arm64 host (QEMU issue 2168, "QEMU internal # crashes running x86_64 programs on an arm64 host (QEMU issue 2168, "QEMU internal
# SIGSEGV {code=MAPERR, addr=0x20}") and 10.2 segfaults on this runner too; 9.2.2 was # SIGSEGV {code=MAPERR, addr=0x20}") and 10.2 segfaults on this runner too; 9.2.2 was
# checked on the runner's host: node, composer and install-php-extensions all run. # checked on the runner's host: node, composer and install-php-extensions all run.
- name: Set up QEMU - name: Set up QEMU
uses: docker/setup-qemu-action@v3 uses: docker/setup-qemu-action@v4
with: with:
image: tonistiigi/binfmt:qemu-v9.2.2 image: tonistiigi/binfmt:qemu-v9.2.2
- name: Set up Docker Buildx - name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3 uses: docker/setup-buildx-action@v4
# Gitea's job token cannot publish packages yet: REGISTRY_TOKEN is an access token with # Gitea's job token cannot publish packages yet: REGISTRY_TOKEN is an access token with
# package write rights, owned by the account that pushes (gitea.actor). # package write rights, owned by the account that pushes (gitea.actor).
- name: Log in to the Gitea container registry - name: Log in to the Gitea container registry
if: gitea.event_name != 'pull_request' if: gitea.event_name != 'pull_request'
uses: docker/login-action@v3 uses: docker/login-action@v4
with: with:
registry: gitea.nonameweb.ch registry: gitea.nonameweb.ch
username: ${{ gitea.actor }} username: ${{ gitea.actor }}
@@ -91,7 +91,7 @@ jobs:
- name: Extract Docker metadata - name: Extract Docker metadata
id: meta id: meta
uses: docker/metadata-action@v5 uses: docker/metadata-action@v6
with: with:
images: gitea.nonameweb.ch/nonameweb/sealshare images: gitea.nonameweb.ch/nonameweb/sealshare
tags: | tags: |
@@ -102,7 +102,7 @@ jobs:
type=sha type=sha
- name: Build and push Docker image - name: Build and push Docker image
uses: docker/build-push-action@v6 uses: docker/build-push-action@v7
with: with:
context: . context: .
platforms: linux/amd64,linux/arm64 platforms: linux/amd64,linux/arm64
@@ -118,7 +118,7 @@ jobs:
if: startsWith(gitea.ref, 'refs/tags/v') if: startsWith(gitea.ref, 'refs/tags/v')
steps: steps:
- name: Checkout code - name: Checkout code
uses: actions/checkout@v6 uses: actions/checkout@v7
- name: Take the release notes from the changelog - name: Take the release notes from the changelog
run: | run: |
+1 -1
View File
@@ -22,7 +22,7 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
environment: Testing environment: Testing
steps: steps:
- uses: actions/checkout@v6 - uses: actions/checkout@v7
- name: Setup PHP - name: Setup PHP
uses: shivammathur/setup-php@v2 uses: shivammathur/setup-php@v2
+2 -2
View File
@@ -24,7 +24,7 @@ jobs:
steps: steps:
- name: Checkout code - name: Checkout code
uses: actions/checkout@v6 uses: actions/checkout@v7
- name: Setup PHP - name: Setup PHP
uses: shivammathur/setup-php@v2 uses: shivammathur/setup-php@v2
@@ -35,7 +35,7 @@ jobs:
coverage: xdebug coverage: xdebug
- name: Setup Node - name: Setup Node
uses: actions/setup-node@v4 uses: actions/setup-node@v7
with: with:
node-version: '24' node-version: '24'
+27
View File
@@ -5,6 +5,32 @@ All notable changes to this project are documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [2.4.0] - 2026-10-08
### Added
- "Download all to a folder" on the download page, in Chrome and Edge on a computer. The recipient picks a folder, and the files are saved into it one at a time, in their folder paths, with progress. A connection that breaks off is resumed where it stopped, files already in the folder are skipped, and files that still fail can be retried. Each request is only as long as one file, so large shares get through proxies that cut long requests. Other browsers keep the ZIP and the per-file buttons.
- Single-file downloads can be resumed: they answer HTTP Range requests, so the browser continues an interrupted download instead of starting over.
- The download page shows how many files a share holds and their total size, and marks the files this browser has downloaded. During a folder download it marks the file on its way and scrolls the list to it.
- "Browse Folder" on the upload page picks a whole folder. Each file keeps its path in it, as when a folder is dropped.
### Changed
- The ZIP download sends its size, so the browser shows its progress and notices a download that was cut short.
- A long file list on the download page scrolls on its own, so the download buttons stay on the first screen.
- A recipient's 1-hour download window restarts with each download they start, so downloading a large share file by file does not use up another download partway through.
- Updated to Laravel 13.35, Livewire 4.4.7, Laravel Octane 2.21 and Laravel Fortify 1.41, and Vite 8.3.4.
- The Gitea workflows use the current versions of the checkout, setup-node and Docker actions, which run on Node 24 instead of the end-of-life Node 20.
- Sessions are encrypted (unless `SESSION_ENCRYPT=false`), because they hold the keys of the password shares a recipient unlocked. Every share stays readable, but everyone is signed out once by the update: admins sign in again, and recipients enter a share's password again. A recipient who was inside their download window on a share that had reached its download limit can no longer download it.
- The Docker image no longer starts without `APP_KEY`. It used to generate one, print it to the logs and generate another on the next start, which left every share without a password unreadable. `docker-compose.example.yml` now requires it for both services. **Before updating an install that never set `APP_KEY`, copy the key from the container's logs (`Generated APP_KEY: …`) and set it for the app and the scheduler**, so the shares created since its last start stay readable. A new key is created with `docker run --rm --entrypoint php <image> artisan key:generate --show`; the command in the README did not run it before.
### Fixed
- Downloads of large shares stopped after 5 minutes (`OCTANE_MAX_EXECUTION_TIME`, 300 seconds by default) and left a broken ZIP. Downloads no longer have a time limit.
- Security: a visitor with a password-protected share's link but not its password could reveal its file list (names, folder paths, sizes, and whether it holds a text) by changing the page's state in the browser. The files and the text themselves stayed protected.
- Security: the password-reset link is built from `APP_URL`, never from the request's host, which a forged `X-Forwarded-Host` header could set.
- Security: league/commonmark 2.10.3 fixes a denial of service in the GitHub Flavored Markdown table extension and a bypass of its raw-HTML filter. source-map-js, used by the asset build, is updated past a high-severity advisory.
## [2.3.0] - 2026-09-26 ## [2.3.0] - 2026-09-26
### Added ### Added
@@ -174,6 +200,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Dark themed UI built with Livewire, Alpine.js, Tailwind CSS and DaisyUI. - Dark themed UI built with Livewire, Alpine.js, Tailwind CSS and DaisyUI.
- Docker images published to `ghcr.io/surtic86/sealshare`, served by FrankenPHP via Laravel Octane. - Docker images published to `ghcr.io/surtic86/sealshare`, served by FrankenPHP via Laravel Octane.
[2.4.0]: https://gitea.nonameweb.ch/noNameWEB/SealShare/compare/v2.3.0...v2.4.0
[2.3.0]: https://gitea.nonameweb.ch/noNameWEB/SealShare/compare/v2.2.0...v2.3.0 [2.3.0]: https://gitea.nonameweb.ch/noNameWEB/SealShare/compare/v2.2.0...v2.3.0
[2.2.0]: https://gitea.nonameweb.ch/noNameWEB/SealShare/compare/v2.1.0...v2.2.0 [2.2.0]: https://gitea.nonameweb.ch/noNameWEB/SealShare/compare/v2.1.0...v2.2.0
[2.1.0]: https://gitea.nonameweb.ch/noNameWEB/SealShare/compare/v2.0.1...v2.1.0 [2.1.0]: https://gitea.nonameweb.ch/noNameWEB/SealShare/compare/v2.0.1...v2.1.0
+3 -15
View File
@@ -3,11 +3,9 @@
# Laravel Boost Guidelines # Laravel Boost Guidelines
The Laravel Boost guidelines are specifically curated by Laravel maintainers for this application. These guidelines should be followed closely to ensure the best experience when building Laravel applications.
## Foundational Context ## Foundational Context
This application is a Laravel application running on PHP 8.5. You are an expert with the Laravel ecosystem. Always use the APIs that match the installed major version of each package — do not assume a version. This application is a Laravel application running on PHP 8.5. Always use the APIs that match the installed major version of each package — do not assume a version.
Before relying on a package's API, confirm its installed version: Before relying on a package's API, confirm its installed version:
- PHP packages: run `composer show --direct` to list direct dependencies with versions, or `composer show <vendor/package>` for a single package. - PHP packages: run `composer show --direct` to list direct dependencies with versions, or `composer show <vendor/package>` for a single package.
@@ -34,16 +32,12 @@ This project has domain-specific skills available in `**/skills/**`. You MUST ac
## Frontend Bundling ## Frontend Bundling
- If the user doesn't see a frontend change reflected in the UI, it could mean they need to run `npm run build`, `npm run dev`, or `composer run dev`. Ask them. - If a frontend change doesn't show in the UI or you get a "Unable to locate file in Vite manifest" error, run `npm run build` or ask the user to run `npm run dev` or `composer run dev`.
## Documentation Files ## Documentation Files
- You must only create documentation files if explicitly requested by the user. - You must only create documentation files if explicitly requested by the user.
## Replies
- Be concise in your explanations - focus on what's important rather than explaining obvious details.
=== boost rules === === boost rules ===
# Laravel Boost # Laravel Boost
@@ -72,8 +66,7 @@ This project has domain-specific skills available in `**/skills/**`. You MUST ac
## Project Rules ## Project Rules
- This project contains committed, area-grouped rules in `.ai/rules` when that directory exists (settled decisions, non-obvious traps, standing constraints). Framework and package guidelines that only apply to specific paths (testing, frontend, components) also live there, under `.ai/rules/boost` — this is not just recorded decisions, it is load-bearing guidance you have not seen inline. Before you enter plan mode or create/edit any file, you MUST first: open @.ai/rules/index.md (it maps file globs to rule files), read every rule file whose globs cover the path(s) in scope, and run `grep -rin 'keyword' .ai/rules` to catch what a path match alone misses. Do not write code until you have read and are following every matching rule. If `.ai/rules` does not exist, continue without it. - This project contains committed, area-grouped rules in `.ai/rules` when that directory exists, including path-scoped framework guidelines under `.ai/rules/boost`. Before you enter plan mode or create/edit any file, you MUST first: open @.ai/rules/index.md (it maps file globs to rule files), read every rule file whose globs cover the path(s) in scope, and run `grep -rin 'keyword' .ai/rules` to catch what a path match alone misses. Do not write code until you have read and are following every matching rule. If `.ai/rules` does not exist, continue without it.
- Record a rule with `record-rule` only when the user explicitly asks for one. Instructions for the work at hand are not rules, no matter how emphatic: "remove this typo", "use X here" are work to do, not rules to record. Never record a rule on your own initiative, as a byproduct of a change, or to summarize what you just did. When the user does ask, pass a `glob` (e.g. `app/Http/Controllers/**`), a short `title`, and a few-line `note`. Use `record-rule` rather than your native memory or notes tool, because native memory is personal and session-scoped, while only `.ai/rules` is shared with the team and persists in the repo.
## Artisan ## Artisan
@@ -103,7 +96,6 @@ This project has domain-specific skills available in `**/skills/**`. You MUST ac
# Deployment # Deployment
- Laravel can be deployed using [Laravel Cloud](https://cloud.laravel.com/), which is the fastest way to deploy and scale production Laravel applications. - Laravel can be deployed using [Laravel Cloud](https://cloud.laravel.com/), which is the fastest way to deploy and scale production Laravel applications.
- Activate the `deploying-to-cloud` skill whenever deploying to Laravel Cloud, configuring Cloud environments or resources, using the Cloud CLI, or troubleshooting Cloud deployments.
=== tests rules === === tests rules ===
@@ -141,10 +133,6 @@ This project has domain-specific skills available in `**/skills/**`. You MUST ac
- Faker: Use methods such as `$this->faker->word()` or `fake()->randomDigit()`. Follow existing conventions whether to use `$this->faker` or `fake()`. - Faker: Use methods such as `$this->faker->word()` or `fake()->randomDigit()`. Follow existing conventions whether to use `$this->faker` or `fake()`.
- When creating tests, make use of `php artisan make:test [options] {name}` to create a feature test, and pass `--unit` to create a unit test. Most tests should be feature tests. - When creating tests, make use of `php artisan make:test [options] {name}` to create a feature test, and pass `--unit` to create a unit test. Most tests should be feature tests.
## Vite Error
- If you receive an "Illuminate\Foundation\ViteException: Unable to locate file in Vite manifest" error, you can run `npm run build` or ask the user to run `npm run dev` or `composer run dev`.
=== laravel-octane/core rules === === laravel-octane/core rules ===
# Laravel Octane # Laravel Octane
+1 -1
View File
@@ -94,7 +94,7 @@ curl -O https://gitea.nonameweb.ch/noNameWEB/SealShare/raw/branch/main/docker-co
cp docker-compose.example.yml docker-compose.yml cp docker-compose.example.yml docker-compose.yml
# Generate an app key and paste it into docker-compose.yml # Generate an app key and paste it into docker-compose.yml
docker run --rm gitea.nonameweb.ch/nonameweb/sealshare:latest php artisan key:generate --show docker run --rm --entrypoint php gitea.nonameweb.ch/nonameweb/sealshare:latest artisan key:generate --show
# Edit docker-compose.yml — set APP_KEY and APP_URL, and choose how HTTPS is served (below) # Edit docker-compose.yml — set APP_KEY and APP_URL, and choose how HTTPS is served (below)
# Then start: # Then start:
+104 -36
View File
@@ -12,6 +12,7 @@ use Illuminate\Support\Facades\Storage;
use Symfony\Component\HttpFoundation\HeaderUtils; use Symfony\Component\HttpFoundation\HeaderUtils;
use Symfony\Component\HttpFoundation\StreamedResponse; use Symfony\Component\HttpFoundation\StreamedResponse;
use ZipStream\CompressionMethod; use ZipStream\CompressionMethod;
use ZipStream\OperationMode;
use ZipStream\ZipStream; use ZipStream\ZipStream;
class DownloadController extends Controller class DownloadController extends Controller
@@ -24,7 +25,9 @@ class DownloadController extends Controller
/** /**
* Download all files as a ZIP archive, streamed file by file as it is decrypted: stored without * Download all files as a ZIP archive, streamed file by file as it is decrypted: stored without
* compression, with ZIP64 for files over 4 GB, and never held in memory or written to disk. The * compression, with ZIP64 for files over 4 GB, and never held in memory or written to disk. The
* private text is left out: it is only ever shown on the page. * archive's size is worked out from the files' sizes first, so the browser shows its progress
* and notices a download cut short. The private text is left out: it is only ever shown on the
* page.
*/ */
public function download(Request $request, Share $share): StreamedResponse public function download(Request $request, Share $share): StreamedResponse
{ {
@@ -38,45 +41,40 @@ class DownloadController extends Controller
// Counted before the body streams: the session is saved by then. // Counted before the body streams: the session is saved by then.
abort_unless($this->shareService->claimDownload($share, $request->session()), 404); abort_unless($this->shareService->claimDownload($share, $request->session()), 404);
return new StreamedResponse(function () use ($share, $key): void { $zip = new ZipStream(
$zip = new ZipStream( operationMode: OperationMode::SIMULATE_STRICT,
defaultCompressionMethod: CompressionMethod::STORE, defaultCompressionMethod: CompressionMethod::STORE,
defaultEnableZeroHeader: true, defaultEnableZeroHeader: true,
sendHttpHeaders: false, sendHttpHeaders: false,
flushOutput: true, flushOutput: true,
);
foreach ($share->files as $file) {
$zip->addFileFromCallback(
fileName: $this->archiveName($file),
exactSize: $file->file_size,
callback: fn (): PumpStream => $this->decryptedStream($share, $file, $key),
); );
}
foreach ($share->files as $file) { $size = $zip->finish();
$chunks = $this->encryptionService->decryptedChunks(
Storage::disk('shares')->path($share->token.'/'.basename($file->stored_path)),
$key,
);
$zip->addFileFromPsr7Stream(fileName: $this->archiveName($file), stream: new PumpStream(function () use ($chunks): string|false { return new StreamedResponse(function () use ($zip): void {
while ($chunks->valid() && $chunks->current() === '') { // A large share takes longer than any request limit to send.
$chunks->next(); set_time_limit(0);
}
if (! $chunks->valid()) { $zip->executeSimulation();
return false;
}
$chunk = $chunks->current();
$chunks->next();
return $chunk;
}));
}
$zip->finish();
}, 200, [ }, 200, [
'Content-Type' => 'application/zip', 'Content-Type' => 'application/zip',
'Content-Length' => $size,
'Content-Disposition' => HeaderUtils::makeDisposition('attachment', 'share-'.$share->token.'.zip'), 'Content-Disposition' => HeaderUtils::makeDisposition('attachment', 'share-'.$share->token.'.zip'),
]); ]);
} }
/** /**
* Download a single file; never the private text, which is only ever shown on the page. * Download a single file; never the private text, which is only ever shown on the page. A
* `Range` request gets the bytes from where an interrupted download stopped, so the browser,
* or the page's folder download, resumes it instead of starting over.
*/ */
public function downloadFile(Request $request, Share $share, ShareFile $shareFile): StreamedResponse public function downloadFile(Request $request, Share $share, ShareFile $shareFile): StreamedResponse
{ {
@@ -85,30 +83,100 @@ class DownloadController extends Controller
$key = $this->shareService->sessionDecryptionKey($share, $request->session()); $key = $this->shareService->sessionDecryptionKey($share, $request->session());
$size = $shareFile->file_size;
$etag = '"'.hash('xxh128', $shareFile->stored_path).'"';
[$start, $end] = $this->requestedRange($request, $size, $etag) ?? [0, $size - 1];
abort_unless($this->shareService->claimDownload($share, $request->session()), 404); abort_unless($this->shareService->claimDownload($share, $request->session()), 404);
$encryptedPath = Storage::disk('shares')->path($share->token.'/'.basename($shareFile->stored_path)); $encryptedPath = Storage::disk('shares')->path($share->token.'/'.basename($shareFile->stored_path));
$mimeType = $shareFile->mime_type ?? 'application/octet-stream'; $partial = $start > 0 || $end < $size - 1;
$headers = [ $headers = [
'Content-Type' => $mimeType, 'Content-Type' => $shareFile->mime_type ?? 'application/octet-stream',
'Content-Disposition' => HeaderUtils::makeDisposition( 'Content-Disposition' => HeaderUtils::makeDisposition(
'attachment', 'attachment',
$shareFile->original_name, $shareFile->original_name,
'download', 'download',
), ),
'Content-Length' => max($end - $start + 1, 0),
'Accept-Ranges' => 'bytes',
'ETag' => $etag,
]; ];
if ($shareFile->file_size !== null) { if ($partial) {
$headers['Content-Length'] = $shareFile->file_size; $headers['Content-Range'] = "bytes {$start}-{$end}/{$size}";
} }
return new StreamedResponse(function () use ($encryptedPath, $key): void { return new StreamedResponse(function () use ($encryptedPath, $key, $start, $end): void {
foreach ($this->encryptionService->decryptedChunks($encryptedPath, $key) as $chunk) { set_time_limit(0);
$remaining = $end - $start + 1;
foreach ($this->encryptionService->decryptedChunks($encryptedPath, $key, $start) as $chunk) {
if (strlen($chunk) >= $remaining) {
echo substr($chunk, 0, $remaining);
flush();
return;
}
echo $chunk; echo $chunk;
flush(); flush();
$remaining -= strlen($chunk);
} }
}, 200, $headers); }, $partial ? 206 : 200, $headers);
}
/**
* The first and last byte a single `Range` request asks for, or null to send the whole file:
* without a range, with one this does not read (several ranges, another unit), or with an
* `If-Range` naming another version of the file. A range wholly past the end is refused.
*
* @return array{0: int, 1: int}|null
*/
private function requestedRange(Request $request, int $size, string $etag): ?array
{
$range = (string) $request->header('Range');
if ($size === 0 || ! preg_match('/^bytes=(\d*)-(\d*)$/', $range, $matches) || $matches[1].$matches[2] === ''
|| ($request->hasHeader('If-Range') && $request->header('If-Range') !== $etag)) {
return null;
}
[$start, $end] = $matches[1] === ''
? [max($size - (int) $matches[2], 0), $size - 1]
: [(int) $matches[1], $matches[2] === '' ? $size - 1 : min((int) $matches[2], $size - 1)];
abort_if($start > $end, 416, headers: ['Content-Range' => "bytes */{$size}"]);
return [$start, $end];
}
/**
* A file's decrypted content as a stream ZipStream reads from.
*/
private function decryptedStream(Share $share, ShareFile $file, string $key): PumpStream
{
$chunks = $this->encryptionService->decryptedChunks(
Storage::disk('shares')->path($share->token.'/'.basename($file->stored_path)),
$key,
);
return new PumpStream(function () use ($chunks): string|false {
while ($chunks->valid() && $chunks->current() === '') {
$chunks->next();
}
if (! $chunks->valid()) {
return false;
}
$chunk = $chunks->current();
$chunks->next();
return $chunk;
});
} }
/** /**
+11 -1
View File
@@ -7,6 +7,7 @@ use App\Services\ShareService;
use Carbon\CarbonInterval; use Carbon\CarbonInterval;
use Illuminate\Support\Facades\RateLimiter; use Illuminate\Support\Facades\RateLimiter;
use Livewire\Attributes\Layout; use Livewire\Attributes\Layout;
use Livewire\Attributes\Locked;
use Livewire\Attributes\Renderless; use Livewire\Attributes\Renderless;
use Livewire\Attributes\Validate; use Livewire\Attributes\Validate;
use Livewire\Component; use Livewire\Component;
@@ -16,6 +17,8 @@ class ShareDownload extends Component
{ {
public Share $share; public Share $share;
/** Set only by mount() and verifyPassword(): the browser must never unlock the file list. */
#[Locked]
public bool $authenticated = false; public bool $authenticated = false;
#[Validate('required|string')] #[Validate('required|string')]
@@ -85,9 +88,16 @@ class ShareDownload extends Component
public function render(): mixed public function render(): mixed
{ {
$shareService = app(ShareService::class); $shareService = app(ShareService::class);
$files = $this->share->files->where('is_text', false)->values();
return view('livewire.share-download', [ return view('livewire.share-download', [
'files' => $this->share->files->where('is_text', false)->values(), 'files' => $files,
'downloads' => $files->map(fn ($file): array => [
'id' => $file->id,
'path' => $file->relative_path ?: $file->original_name,
'size' => $file->file_size,
'url' => route('share.download.file', [$this->share, $file]),
]),
'hasText' => $this->share->files->contains('is_text', true), 'hasText' => $this->share->files->contains('is_text', true),
'downloadWindowEndsAt' => $shareService->downloadWindowEndsAt($this->share, session()->driver()), 'downloadWindowEndsAt' => $shareService->downloadWindowEndsAt($this->share, session()->driver()),
'remainingDownloads' => $this->share->max_downloads ? max($this->share->max_downloads - $this->share->download_count, 0) : null, 'remainingDownloads' => $this->share->max_downloads ? max($this->share->max_downloads - $this->share->download_count, 0) : null,
+8
View File
@@ -3,6 +3,8 @@
namespace App\Providers; namespace App\Providers;
use App\Actions\Fortify\ResetUserPassword; use App\Actions\Fortify\ResetUserPassword;
use App\Models\User;
use Illuminate\Auth\Notifications\ResetPassword;
use Illuminate\Cache\RateLimiting\Limit; use Illuminate\Cache\RateLimiting\Limit;
use Illuminate\Http\Request; use Illuminate\Http\Request;
use Illuminate\Support\Facades\RateLimiter; use Illuminate\Support\Facades\RateLimiter;
@@ -28,6 +30,12 @@ class FortifyServiceProvider extends ServiceProvider
private function configureActions(): void private function configureActions(): void
{ {
Fortify::resetUserPasswordsUsing(ResetUserPassword::class); Fortify::resetUserPasswordsUsing(ResetUserPassword::class);
// From APP_URL, never the request's host: every proxy is trusted, so a forged X-Forwarded-Host would otherwise pick it.
ResetPassword::createUrlUsing(fn (User $user, string $token): string => rtrim((string) config('app.url'), '/').route('password.reset', [
'token' => $token,
'email' => $user->getEmailForPasswordReset(),
], false));
} }
/** /**
+32 -11
View File
@@ -200,20 +200,35 @@ class FileEncryptionService
} }
/** /**
* The decrypted content of a file in any of the three formats, chunk by chunk. * The decrypted content of a file in any of the three formats, chunk by chunk, from byte
* `$offset` of the plaintext on. A `SEALCHK2` file starts at the chunk holding that byte; the
* older formats are decrypted from their start and the bytes before it dropped.
* *
* @return Generator<int, string> * @return Generator<int, string>
*/ */
public function decryptedChunks(string $encryptedPath, string $key): Generator public function decryptedChunks(string $encryptedPath, string $key, int $offset = 0): Generator
{ {
$magic = (string) file_get_contents($encryptedPath, false, null, 0, 8); $magic = (string) file_get_contents($encryptedPath, false, null, 0, 8);
if ($magic === self::MAGIC) { if ($magic === self::MAGIC) {
yield from $this->decryptChunks($encryptedPath, $key); yield from $this->decryptChunks($encryptedPath, $key, $offset);
} elseif ($magic === self::LEGACY_CHUNKED_MAGIC) {
yield from $this->decryptLegacyChunks($encryptedPath, $key); return;
} else { }
yield $this->decryptLegacy($encryptedPath, $key);
$chunks = $magic === self::LEGACY_CHUNKED_MAGIC
? $this->decryptLegacyChunks($encryptedPath, $key)
: [$this->decryptLegacy($encryptedPath, $key)];
foreach ($chunks as $chunk) {
if ($offset >= strlen($chunk)) {
$offset -= strlen($chunk);
continue;
}
yield substr($chunk, $offset);
$offset = 0;
} }
} }
@@ -251,7 +266,7 @@ class FileEncryptionService
* *
* @return Generator<int, string> * @return Generator<int, string>
*/ */
private function decryptChunks(string $encryptedPath, string $key): Generator private function decryptChunks(string $encryptedPath, string $key, int $offset = 0): Generator
{ {
$handle = fopen($encryptedPath, 'rb'); $handle = fopen($encryptedPath, 'rb');
@@ -270,10 +285,16 @@ class FileEncryptionService
throw new RuntimeException('Invalid encrypted file: no chunks'); throw new RuntimeException('Invalid encrypted file: no chunks');
} }
for ($index = 0; $index < $chunkCount; $index++) { $firstIndex = min(intdiv($offset, max($chunkSize, 1)), $chunkCount - 1);
$chunk = (string) fread($handle, $storedChunkSize); $skip = $offset - $firstIndex * $chunkSize;
fseek($handle, $this->chunkOffset($firstIndex, $chunkSize));
yield $this->decryptChunk($chunk, $key, $noncePrefix, $index, $index === $chunkCount - 1); for ($index = $firstIndex; $index < $chunkCount; $index++) {
$chunk = (string) fread($handle, $storedChunkSize);
$plaintext = $this->decryptChunk($chunk, $key, $noncePrefix, $index, $index === $chunkCount - 1);
yield $skip > 0 ? substr($plaintext, $skip) : $plaintext;
$skip = 0;
} }
} finally { } finally {
fclose($handle); fclose($handle);
+7 -3
View File
@@ -393,8 +393,10 @@ class ShareService
/** /**
* When this session's download window for a share ends, or null while it has none open. The * When this session's download window for a share ends, or null while it has none open. The
* window opens with the session's counted download; until it ends, the session may start more * window opens with the session's counted download and each download started in it keeps it
* downloads of the share without counting them, even once the share has reached its limit. * open, so downloading a large share file by file never outlasts it; until it ends, the session
* may start more downloads of the share without counting them, even once the share has
* reached its limit.
*/ */
public function downloadWindowEndsAt(Share $share, Session $session): ?CarbonInterface public function downloadWindowEndsAt(Share $share, Session $session): ?CarbonInterface
{ {
@@ -418,6 +420,8 @@ class ShareService
public function claimDownload(Share $share, Session $session): bool public function claimDownload(Share $share, Session $session): bool
{ {
if ($this->downloadWindowEndsAt($share, $session) !== null) { if ($this->downloadWindowEndsAt($share, $session) !== null) {
$session->put($this->downloadSessionKey($share), now()->getTimestamp());
return true; return true;
} }
@@ -436,7 +440,7 @@ class ShareService
} }
/** /**
* The session key holding when this session's download of a share was counted. * The session key holding when this session last started a download of a share.
*/ */
private function downloadSessionKey(Share $share): string private function downloadSessionKey(Share $share): string
{ {
Generated
+359 -351
View File
File diff suppressed because it is too large Load Diff
+1 -1
View File
@@ -25,6 +25,6 @@ return [
| |
*/ */
'version' => '2.3.0', 'version' => '2.4.0',
]; ];
+8 -2
View File
@@ -8,13 +8,19 @@ use Illuminate\Support\Str;
|-------------------------------------------------------------------------- |--------------------------------------------------------------------------
| |
| Kept from earlier releases, where it differs from the framework's | Kept from earlier releases, where it differs from the framework's
| "<app>_session": renaming the cookie would sign everyone out. Every | "<app>_session": renaming the cookie would sign everyone out.
| other key comes from the framework's defaults. |
| Sessions are encrypted unless SESSION_ENCRYPT=false: they hold the keys
| of the password shares a recipient unlocked, which must never sit
| readable in the sessions table. Every other key comes from the
| framework's defaults.
| |
*/ */
return [ return [
'encrypt' => env('SESSION_ENCRYPT', true),
'cookie' => env( 'cookie' => env(
'SESSION_COOKIE', 'SESSION_COOKIE',
Str::slug((string) env('APP_NAME', 'laravel')).'-session' Str::slug((string) env('APP_NAME', 'laravel')).'-session'
+6 -5
View File
@@ -4,12 +4,13 @@
# #
# Quick start: # Quick start:
# 1. Copy this file: cp docker-compose.example.yml docker-compose.yml # 1. Copy this file: cp docker-compose.example.yml docker-compose.yml
# 2. Edit the settings below (APP_URL is required; uploads need HTTPS, see below) # 2. Edit the settings below (APP_URL and APP_KEY are required; uploads need HTTPS, see below)
# 3. Start: docker compose up -d # 3. Start: docker compose up -d
# 4. Open your browser to your configured domain # 4. Open your browser to your configured domain
# #
# Note: APP_KEY is auto-generated on first start if not set. # APP_KEY is required: the container does not start without it. Create one with
# Copy it from the logs into your docker-compose.yml to persist across restarts. # docker run --rm --entrypoint php gitea.nonameweb.ch/nonameweb/sealshare:latest artisan key:generate --show
# and keep it: it decrypts the shares, so a new key makes the existing ones unreadable.
# #
# ============================================ # ============================================
@@ -32,7 +33,7 @@ services:
environment: environment:
# --- REQUIRED --- # --- REQUIRED ---
APP_URL: # Your full URL, e.g. https://share.example.com APP_URL: # Your full URL, e.g. https://share.example.com
# APP_KEY: # Auto-generated if not set. Copy from logs to persist across restarts. APP_KEY: # Required. Create one with php artisan key:generate --show (see above)
DB_DATABASE: /app/database/sqlite/database.sqlite # The SQLite file in sealshare_database DB_DATABASE: /app/database/sqlite/database.sqlite # The SQLite file in sealshare_database
# --- HTTPS --- # --- HTTPS ---
@@ -90,7 +91,7 @@ services:
- sealshare_storage:/app/storage/app - sealshare_storage:/app/storage/app
- sealshare_database:/app/database/sqlite - sealshare_database:/app/database/sqlite
environment: environment:
# APP_KEY: # Same key as the app service above (auto-generated if not set) APP_KEY: # Same key as the app service above
APP_URL: # Same URL as the app service above APP_URL: # Same URL as the app service above
DB_DATABASE: /app/database/sqlite/database.sqlite # Same as the app service above DB_DATABASE: /app/database/sqlite/database.sqlite # Same as the app service above
depends_on: depends_on:
+7 -6
View File
@@ -3,13 +3,14 @@ set -e
cd /app cd /app
# Auto-generate APP_KEY if not provided # APP_KEY decrypts the shares, so it must stay the same across restarts: a key made up here would
# change on the next start and leave every existing share unreadable.
if [ -z "$APP_KEY" ]; then if [ -z "$APP_KEY" ]; then
echo "[entrypoint] No APP_KEY set, generating one..." echo "[entrypoint] APP_KEY is not set. Create one and set it for the app and the scheduler:" >&2
APP_KEY=$(php artisan key:generate --show) echo "[entrypoint] docker run --rm --entrypoint php <this image> artisan key:generate --show" >&2
export APP_KEY echo "[entrypoint] If this install ran without one before, use the key from its old logs" >&2
echo "[entrypoint] Generated APP_KEY: $APP_KEY" echo "[entrypoint] (\"Generated APP_KEY: ...\") so its shares stay readable." >&2
echo "[entrypoint] WARNING: Set this APP_KEY in your docker-compose.yml to persist across restarts!" exit 1
fi fi
# A docker-compose.yml from before 2.1.1 mounts the SQLite volume over all of /app/database, so the # A docker-compose.yml from before 2.1.1 mounts the SQLite volume over all of /app/database, so the
+90 -90
View File
@@ -18,18 +18,18 @@
} }
}, },
"node_modules/@oxc-project/types": { "node_modules/@oxc-project/types": {
"version": "0.150.0", "version": "0.153.0",
"resolved": "https://registry.npmjs.org/@oxc-project/types/-/types-0.150.0.tgz", "resolved": "https://registry.npmjs.org/@oxc-project/types/-/types-0.153.0.tgz",
"integrity": "sha512-rDS5/31E9HfPl/CIzGrn0DOlvBbXFseQ5URJ9sYMfstbKLD/c6Gm9vmRzRGDdAXyOIL4zmO37lc9RIwYqVruZw==", "integrity": "sha512-jSNrRIyvPVLL5E1z/tS5zLAprosGz/FuI1PWwEOz59j3E4TTTzSpqKb/RDGqJhhW0QHYISGXxq582wGx6T11Tw==",
"license": "MIT", "license": "MIT",
"funding": { "funding": {
"url": "https://github.com/sponsors/oxc-project" "url": "https://github.com/sponsors/oxc-project"
} }
}, },
"node_modules/@rolldown/binding-android-arm-eabi": { "node_modules/@rolldown/binding-android-arm-eabi": {
"version": "1.2.9", "version": "1.2.13",
"resolved": "https://registry.npmjs.org/@rolldown/binding-android-arm-eabi/-/binding-android-arm-eabi-1.2.9.tgz", "resolved": "https://registry.npmjs.org/@rolldown/binding-android-arm-eabi/-/binding-android-arm-eabi-1.2.13.tgz",
"integrity": "sha512-tNISae1QEf/vkb3xkRcjV5SEdzPE97We5IVaa2Z8jSszQPZ8U60B/YCYpw4QI7VidYsBtKavczXf+DyDs9WGxw==", "integrity": "sha512-Vu/NICrgdRvUOeaJZIyB2FP63s6fO/4ud5l8dXmxDx9yDyn+mN0y+gsvsVviSli+T361Aqo0h46EuMoobrwawA==",
"cpu": [ "cpu": [
"arm" "arm"
], ],
@@ -43,9 +43,9 @@
} }
}, },
"node_modules/@rolldown/binding-android-arm64": { "node_modules/@rolldown/binding-android-arm64": {
"version": "1.2.9", "version": "1.2.13",
"resolved": "https://registry.npmjs.org/@rolldown/binding-android-arm64/-/binding-android-arm64-1.2.9.tgz", "resolved": "https://registry.npmjs.org/@rolldown/binding-android-arm64/-/binding-android-arm64-1.2.13.tgz",
"integrity": "sha512-YC8YsI30o606GTZi0VyzYlsDKFP8W61i/QzayHDkLbNEz/IShqAmTa+hsJRj13xTHA0H+6fk4b2UmGn+Q/cMlg==", "integrity": "sha512-6LEoIrGy5vvCd2boNnv2soPSUZj/PRvhp8R/t9KlX+mIZxThIE/ZqxrGXxmuNX0FuvQFvLdZr7S4HrYpYBVhEQ==",
"cpu": [ "cpu": [
"arm64" "arm64"
], ],
@@ -59,9 +59,9 @@
} }
}, },
"node_modules/@rolldown/binding-darwin-arm64": { "node_modules/@rolldown/binding-darwin-arm64": {
"version": "1.2.9", "version": "1.2.13",
"resolved": "https://registry.npmjs.org/@rolldown/binding-darwin-arm64/-/binding-darwin-arm64-1.2.9.tgz", "resolved": "https://registry.npmjs.org/@rolldown/binding-darwin-arm64/-/binding-darwin-arm64-1.2.13.tgz",
"integrity": "sha512-IwhlH3qK5urrY8hZiEgGkHKEFN901p/p2bjxCxJlr4GyNnF7wYpUvK+Y43uaRYuC4hpfjzbR3SJC3arX1jGvmw==", "integrity": "sha512-CaJSRzlQ6Q+zkDMVA9OkVxBjVoPRCDEE3v0FSJ9kIQBgRjFApA3Si4ijhbNVUji7ZJt+PfO0e46qy4nPInHUPA==",
"cpu": [ "cpu": [
"arm64" "arm64"
], ],
@@ -75,9 +75,9 @@
} }
}, },
"node_modules/@rolldown/binding-darwin-x64": { "node_modules/@rolldown/binding-darwin-x64": {
"version": "1.2.9", "version": "1.2.13",
"resolved": "https://registry.npmjs.org/@rolldown/binding-darwin-x64/-/binding-darwin-x64-1.2.9.tgz", "resolved": "https://registry.npmjs.org/@rolldown/binding-darwin-x64/-/binding-darwin-x64-1.2.13.tgz",
"integrity": "sha512-XxpJfVzFh+jilRxIXUqcfYAYcunIc/XEzIizsOL1fcJee5Sf7H3mH8WlLmfHfluz5amqR88QQo9izKtmMlavAw==", "integrity": "sha512-e4r340I5hxSzJkD3YJBxgzq/rJ3wwxwdLLb2FPt1Zpyem20nrQPT11DDEEkazwxaHumH8wpglsp/Ozgj/wT6mw==",
"cpu": [ "cpu": [
"x64" "x64"
], ],
@@ -91,9 +91,9 @@
} }
}, },
"node_modules/@rolldown/binding-freebsd-x64": { "node_modules/@rolldown/binding-freebsd-x64": {
"version": "1.2.9", "version": "1.2.13",
"resolved": "https://registry.npmjs.org/@rolldown/binding-freebsd-x64/-/binding-freebsd-x64-1.2.9.tgz", "resolved": "https://registry.npmjs.org/@rolldown/binding-freebsd-x64/-/binding-freebsd-x64-1.2.13.tgz",
"integrity": "sha512-kSfvhmgeWyfkbT3p/1s5vSgboogoah2zkm9fX2zjg2hHxSV7T4KhMWRUUaRk4OXNqoD3QAUeRqLcs1aZOK4U1g==", "integrity": "sha512-hoBWDZ4/K/mJKVMbsgUd1jfpA2DiOrJ54mpegObU9TBHBBrtX4FLIXJJQRDPZ/2Dn91GvPob+Z2hwKJzf4E5SQ==",
"cpu": [ "cpu": [
"x64" "x64"
], ],
@@ -107,9 +107,9 @@
} }
}, },
"node_modules/@rolldown/binding-linux-arm-gnueabihf": { "node_modules/@rolldown/binding-linux-arm-gnueabihf": {
"version": "1.2.9", "version": "1.2.13",
"resolved": "https://registry.npmjs.org/@rolldown/binding-linux-arm-gnueabihf/-/binding-linux-arm-gnueabihf-1.2.9.tgz", "resolved": "https://registry.npmjs.org/@rolldown/binding-linux-arm-gnueabihf/-/binding-linux-arm-gnueabihf-1.2.13.tgz",
"integrity": "sha512-1RVzG17pxqbTfYLC352JlLt6kKLG+6Hr30n8DlIJqsnV5luUDd2Qdx9Ayw1Cabfyb1K9k0jXEZ7evxkRoT+uiw==", "integrity": "sha512-oF9fZu3vTWnTiVAkDFxU9PJLt1nh20K9RRpuHsR7ZnE2L7XookBbDBVLojCVSLGbvtSlxeUNnjAj6DbNsKyzbg==",
"cpu": [ "cpu": [
"arm" "arm"
], ],
@@ -123,9 +123,9 @@
} }
}, },
"node_modules/@rolldown/binding-linux-arm64-gnu": { "node_modules/@rolldown/binding-linux-arm64-gnu": {
"version": "1.2.9", "version": "1.2.13",
"resolved": "https://registry.npmjs.org/@rolldown/binding-linux-arm64-gnu/-/binding-linux-arm64-gnu-1.2.9.tgz", "resolved": "https://registry.npmjs.org/@rolldown/binding-linux-arm64-gnu/-/binding-linux-arm64-gnu-1.2.13.tgz",
"integrity": "sha512-BXqPvZ2drqVD+/Z8UpKwcs4Mp7grM+eGFku4CAEKrEtcbAsUpzREphK1sogCRZGreVPiMkiiBtw0n3TPteuqvw==", "integrity": "sha512-DTpb/+jMiqWMPgphn4ksW1zW+XLJ6dJJ9FMvnIk9I291LhCctMPhMYJrP5t9p6C9qa3KXadDdUEZHBaPh3kNxQ==",
"cpu": [ "cpu": [
"arm64" "arm64"
], ],
@@ -142,9 +142,9 @@
} }
}, },
"node_modules/@rolldown/binding-linux-arm64-musl": { "node_modules/@rolldown/binding-linux-arm64-musl": {
"version": "1.2.9", "version": "1.2.13",
"resolved": "https://registry.npmjs.org/@rolldown/binding-linux-arm64-musl/-/binding-linux-arm64-musl-1.2.9.tgz", "resolved": "https://registry.npmjs.org/@rolldown/binding-linux-arm64-musl/-/binding-linux-arm64-musl-1.2.13.tgz",
"integrity": "sha512-11vWvo8YDwLzukt27J3aYDWU+gg2P7J+ZOmiJ0hkF5BXZDW7pVya7r40MXDy6ya0i9KamoENSVKIugvJNgFXIA==", "integrity": "sha512-xU+Kvv9N2A3SY35zFh1FWWNjxbadE/BKeqnkXe7vScU4GZsw757BlVmDLITZEq8DPpk6m7uoDYkK7P+x/uU5Ow==",
"cpu": [ "cpu": [
"arm64" "arm64"
], ],
@@ -161,9 +161,9 @@
} }
}, },
"node_modules/@rolldown/binding-linux-ppc64-gnu": { "node_modules/@rolldown/binding-linux-ppc64-gnu": {
"version": "1.2.9", "version": "1.2.13",
"resolved": "https://registry.npmjs.org/@rolldown/binding-linux-ppc64-gnu/-/binding-linux-ppc64-gnu-1.2.9.tgz", "resolved": "https://registry.npmjs.org/@rolldown/binding-linux-ppc64-gnu/-/binding-linux-ppc64-gnu-1.2.13.tgz",
"integrity": "sha512-a1tijMkdwsIARtc0F39ApURROkf3NwqinI6TOiSSWCTR7dT96dffNvMUtDHnq64wKNTIZOIlzKrFvvFUznJiyw==", "integrity": "sha512-XMk/hnhh25oQ756Lclb1Q11h4ll0xC0Esa5w4Vzp+mAE2S3AGJgeM0SonrIgY8fHhjarb6hcoTuwoFG0VVP2ig==",
"cpu": [ "cpu": [
"ppc64" "ppc64"
], ],
@@ -180,9 +180,9 @@
} }
}, },
"node_modules/@rolldown/binding-linux-s390x-gnu": { "node_modules/@rolldown/binding-linux-s390x-gnu": {
"version": "1.2.9", "version": "1.2.13",
"resolved": "https://registry.npmjs.org/@rolldown/binding-linux-s390x-gnu/-/binding-linux-s390x-gnu-1.2.9.tgz", "resolved": "https://registry.npmjs.org/@rolldown/binding-linux-s390x-gnu/-/binding-linux-s390x-gnu-1.2.13.tgz",
"integrity": "sha512-x6SQNdAvv4c3hWqTMaWuawzMX9myaCs/yEmlGsxJzkdClnHW7FbrjQuSiRDhuSYzEYoEMhsaJy9qHG/XNemJPQ==", "integrity": "sha512-U1BoTHYmlywE2n3HUWjzZ+8EQsKr+OwpxYuDWaubx42tUL8QSL7nOqRz/NVHanibbFP3M1Rxuprz/wNcbMKjqw==",
"cpu": [ "cpu": [
"s390x" "s390x"
], ],
@@ -199,9 +199,9 @@
} }
}, },
"node_modules/@rolldown/binding-linux-x64-gnu": { "node_modules/@rolldown/binding-linux-x64-gnu": {
"version": "1.2.9", "version": "1.2.13",
"resolved": "https://registry.npmjs.org/@rolldown/binding-linux-x64-gnu/-/binding-linux-x64-gnu-1.2.9.tgz", "resolved": "https://registry.npmjs.org/@rolldown/binding-linux-x64-gnu/-/binding-linux-x64-gnu-1.2.13.tgz",
"integrity": "sha512-9s0AZ8BFK5/n7B/TBoa2yJE3gI3KURrbXcPBlsAsvjU4VeJKgE90y1YtNxyEUIcHPQkg6/yfF3qihUrcM/Kf0Q==", "integrity": "sha512-J4cm80Pc6wEwV5AZ42o62sIQgDk+Y7R2s646jIwuvO+4V46QB58N4vVuMPWCBaNgursXLpmUWJV//WQAkPvHBQ==",
"cpu": [ "cpu": [
"x64" "x64"
], ],
@@ -218,9 +218,9 @@
} }
}, },
"node_modules/@rolldown/binding-linux-x64-musl": { "node_modules/@rolldown/binding-linux-x64-musl": {
"version": "1.2.9", "version": "1.2.13",
"resolved": "https://registry.npmjs.org/@rolldown/binding-linux-x64-musl/-/binding-linux-x64-musl-1.2.9.tgz", "resolved": "https://registry.npmjs.org/@rolldown/binding-linux-x64-musl/-/binding-linux-x64-musl-1.2.13.tgz",
"integrity": "sha512-P7VWAmV+WdJluH7ovnRGoiv2i8To7GAZ+kGzfGup635cyL7SyYl3lSUaA3Gp5THf0n/Co5EyEqb2zbqq+nMOHQ==", "integrity": "sha512-W0euZS40U4V6JkmEnVCIX9mcsL6cbXQ4X8c2w+MMOIjFg68TXUW+u3RT+2e1t1pv9mg/EP3pDtK3POXdQ7Rxyw==",
"cpu": [ "cpu": [
"x64" "x64"
], ],
@@ -237,9 +237,9 @@
} }
}, },
"node_modules/@rolldown/binding-openharmony-arm64": { "node_modules/@rolldown/binding-openharmony-arm64": {
"version": "1.2.9", "version": "1.2.13",
"resolved": "https://registry.npmjs.org/@rolldown/binding-openharmony-arm64/-/binding-openharmony-arm64-1.2.9.tgz", "resolved": "https://registry.npmjs.org/@rolldown/binding-openharmony-arm64/-/binding-openharmony-arm64-1.2.13.tgz",
"integrity": "sha512-1qixtsE4BK8h+yS3BfmZ09UhA7O/N4IACva6YBr7EBvCJraByTuRcgOTaiA62Tm0vey3UcKXLOaoGHtYmNGEVg==", "integrity": "sha512-do/AF/4n9MRshia3a5aXoy8xM2c6mgfT6D7H/dY6my5z+hfCIR4ab7mk4IRj++nsEQpKy39kd0DQnDq+r692tw==",
"cpu": [ "cpu": [
"arm64" "arm64"
], ],
@@ -253,9 +253,9 @@
} }
}, },
"node_modules/@rolldown/binding-win32-arm64-msvc": { "node_modules/@rolldown/binding-win32-arm64-msvc": {
"version": "1.2.9", "version": "1.2.13",
"resolved": "https://registry.npmjs.org/@rolldown/binding-win32-arm64-msvc/-/binding-win32-arm64-msvc-1.2.9.tgz", "resolved": "https://registry.npmjs.org/@rolldown/binding-win32-arm64-msvc/-/binding-win32-arm64-msvc-1.2.13.tgz",
"integrity": "sha512-ok8IQjcEPs1AKZfuEUznVBrJw+gK4soq+bx8b1X2XoMqVClarc1q5JDmVtWXY1xfr6ZuHTAsPXHTgTrqKTZeww==", "integrity": "sha512-6FtUf2cJZobutJdxnGYX8z0vtbgqU0b2v8vfBhkXb9wp2MppMFtkunE+IaOntyi01rkIQoPW2GHABtfzsC0BRQ==",
"cpu": [ "cpu": [
"arm64" "arm64"
], ],
@@ -269,9 +269,9 @@
} }
}, },
"node_modules/@rolldown/binding-win32-x64-msvc": { "node_modules/@rolldown/binding-win32-x64-msvc": {
"version": "1.2.9", "version": "1.2.13",
"resolved": "https://registry.npmjs.org/@rolldown/binding-win32-x64-msvc/-/binding-win32-x64-msvc-1.2.9.tgz", "resolved": "https://registry.npmjs.org/@rolldown/binding-win32-x64-msvc/-/binding-win32-x64-msvc-1.2.13.tgz",
"integrity": "sha512-Ip2mXoU0hM0boq3Rf+ekuT653OROSo6aSYcPT1VHE4q52KvyxgFkQgrgb/IEsxOuvQ2fZZbs8khJAyCEPM24/g==", "integrity": "sha512-UKhFaZTeTcbKrb3iU82m17jVcPEAoqDkCN5MBqgPyZSwp/cQmib21crTS0DdH7T1B7wZRWEI89YQAOJMet5yhg==",
"cpu": [ "cpu": [
"x64" "x64"
], ],
@@ -634,9 +634,9 @@
} }
}, },
"node_modules/nanoid": { "node_modules/nanoid": {
"version": "3.3.19", "version": "3.3.20",
"resolved": "https://registry.npmjs.org/nanoid/-/nanoid-3.3.19.tgz", "resolved": "https://registry.npmjs.org/nanoid/-/nanoid-3.3.20.tgz",
"integrity": "sha512-Y2tUNy4ouw6tq5oDSKeQYGOyhkUBhNOcGV/02KC+6kd9eDGqdZd++mjMiIDilrBYvjEnCYvVtsuHCuP+okSfug==", "integrity": "sha512-uKdg2G3GNCKQn9byYOpxbGqrT2fGO5KRt5J/8b3pok8rT6qxGWF6hxMyJiEYtAf+FVyYuD9hRaDqX5uPFYJ4ZQ==",
"funding": [ "funding": [
{ {
"type": "github", "type": "github",
@@ -670,13 +670,13 @@
} }
}, },
"node_modules/playwright": { "node_modules/playwright": {
"version": "1.63.0", "version": "1.64.0",
"resolved": "https://registry.npmjs.org/playwright/-/playwright-1.63.0.tgz", "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.64.0.tgz",
"integrity": "sha512-+7ziBLidS4NaNCdt57SUDT+wYmmd5fmiQejUic/kb+YsYSCPyOOE9sebzMjNmQrsnNpDJqd4WHvV/8lfKfUDUg==", "integrity": "sha512-kVzTnYFYEyQ9RGzBjNCd2+yEqWmVbxl3AHPynv3qQ6JTjv4a+kwRcnqQwIpuP3NnrnIrE/Q6wWAIAvMfIE2/Yg==",
"dev": true, "dev": true,
"license": "Apache-2.0", "license": "Apache-2.0",
"dependencies": { "dependencies": {
"playwright-core": "1.63.0" "playwright-core": "1.64.0"
}, },
"bin": { "bin": {
"playwright": "cli.js" "playwright": "cli.js"
@@ -686,9 +686,9 @@
} }
}, },
"node_modules/playwright-core": { "node_modules/playwright-core": {
"version": "1.63.0", "version": "1.64.0",
"resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.63.0.tgz", "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.64.0.tgz",
"integrity": "sha512-rYCsBF/M5HjUch52bbtVONEFjv6Xu8sm8h72dNlR5bzIE1fvC/bxgspzkjSfU+MweEMmPM8KJebG6nnyxo5mCg==", "integrity": "sha512-T9r+MZkTECl2+oUcZ26YgZzTrYidTsIhYYkJix+6iDOymOb1FB2RLLSOxRGnZGv5DStt+aduIVbt+E8WygXYpg==",
"dev": true, "dev": true,
"license": "Apache-2.0", "license": "Apache-2.0",
"bin": { "bin": {
@@ -699,9 +699,9 @@
} }
}, },
"node_modules/postcss": { "node_modules/postcss": {
"version": "8.5.28", "version": "8.5.29",
"resolved": "https://registry.npmjs.org/postcss/-/postcss-8.5.28.tgz", "resolved": "https://registry.npmjs.org/postcss/-/postcss-8.5.29.tgz",
"integrity": "sha512-RRuzqDtt5Y9h3quz5hWhK+TPnsmVs6WwSU6LkJMeY4HstUEDuYTG8UJSdawMRzmzAtV+KEoG8N3Qg2qLy5vM/A==", "integrity": "sha512-49cGhUbXj8Qenv0iTMxA1cFBzxXoctpC9Ujd77t1WcbJIr6nF/eI7g/8MgxrYldFRuAXvja7xQRwavoW7kgrxQ==",
"funding": [ "funding": [
{ {
"type": "opencollective", "type": "opencollective",
@@ -718,9 +718,9 @@
], ],
"license": "MIT", "license": "MIT",
"dependencies": { "dependencies": {
"nanoid": "^3.3.18", "nanoid": "^3.3.19",
"picocolors": "^1.1.1", "picocolors": "^1.1.1",
"source-map-js": "^1.2.1" "source-map-js": "^1.2.2"
}, },
"engines": { "engines": {
"node": "^10 || ^12 || >=14" "node": "^10 || ^12 || >=14"
@@ -741,12 +741,12 @@
} }
}, },
"node_modules/rolldown": { "node_modules/rolldown": {
"version": "1.2.9", "version": "1.2.13",
"resolved": "https://registry.npmjs.org/rolldown/-/rolldown-1.2.9.tgz", "resolved": "https://registry.npmjs.org/rolldown/-/rolldown-1.2.13.tgz",
"integrity": "sha512-hx/Pv0N1haXRb11qkfnK5MXB/iqr7i0yjWQqmO9uHqZpBgQSqzc8UsSnEpalsh+j1I8qQ2CkXAkJC8Br3dKSlg==", "integrity": "sha512-/5apOkwWxtACcQtZ5WlrAsKS4JwXVThQPJZ3RqIruRY9UG9M8e0VlXN068xum/JRKA4aIUoJ13ghe/kGCvidiQ==",
"license": "MIT", "license": "MIT",
"dependencies": { "dependencies": {
"@oxc-project/types": "=0.150.0", "@oxc-project/types": "=0.153.0",
"@rolldown/pluginutils": "^1.0.0" "@rolldown/pluginutils": "^1.0.0"
}, },
"bin": { "bin": {
@@ -756,27 +756,27 @@
"node": "^20.19.0 || >=22.12.0" "node": "^20.19.0 || >=22.12.0"
}, },
"optionalDependencies": { "optionalDependencies": {
"@rolldown/binding-android-arm-eabi": "1.2.9", "@rolldown/binding-android-arm-eabi": "1.2.13",
"@rolldown/binding-android-arm64": "1.2.9", "@rolldown/binding-android-arm64": "1.2.13",
"@rolldown/binding-darwin-arm64": "1.2.9", "@rolldown/binding-darwin-arm64": "1.2.13",
"@rolldown/binding-darwin-x64": "1.2.9", "@rolldown/binding-darwin-x64": "1.2.13",
"@rolldown/binding-freebsd-x64": "1.2.9", "@rolldown/binding-freebsd-x64": "1.2.13",
"@rolldown/binding-linux-arm-gnueabihf": "1.2.9", "@rolldown/binding-linux-arm-gnueabihf": "1.2.13",
"@rolldown/binding-linux-arm64-gnu": "1.2.9", "@rolldown/binding-linux-arm64-gnu": "1.2.13",
"@rolldown/binding-linux-arm64-musl": "1.2.9", "@rolldown/binding-linux-arm64-musl": "1.2.13",
"@rolldown/binding-linux-ppc64-gnu": "1.2.9", "@rolldown/binding-linux-ppc64-gnu": "1.2.13",
"@rolldown/binding-linux-s390x-gnu": "1.2.9", "@rolldown/binding-linux-s390x-gnu": "1.2.13",
"@rolldown/binding-linux-x64-gnu": "1.2.9", "@rolldown/binding-linux-x64-gnu": "1.2.13",
"@rolldown/binding-linux-x64-musl": "1.2.9", "@rolldown/binding-linux-x64-musl": "1.2.13",
"@rolldown/binding-openharmony-arm64": "1.2.9", "@rolldown/binding-openharmony-arm64": "1.2.13",
"@rolldown/binding-win32-arm64-msvc": "1.2.9", "@rolldown/binding-win32-arm64-msvc": "1.2.13",
"@rolldown/binding-win32-x64-msvc": "1.2.9" "@rolldown/binding-win32-x64-msvc": "1.2.13"
} }
}, },
"node_modules/source-map-js": { "node_modules/source-map-js": {
"version": "1.2.1", "version": "1.2.2",
"resolved": "https://registry.npmjs.org/source-map-js/-/source-map-js-1.2.1.tgz", "resolved": "https://registry.npmjs.org/source-map-js/-/source-map-js-1.2.2.tgz",
"integrity": "sha512-UXWMKhLOwVKb728IUtQPXxfYU+usdybtUrK/8uGE8CQMvrhOpwvzDBwj0QhSL7MQc7vIsISBG8VQ8+IDQxpfQA==", "integrity": "sha512-KGj/8Y43x35aZVDtt+J4mK1hoLGHULMYfSkODJNQjNDC3oW1PqPoxMwo0pLUsWM/UEGzON/NxeHywEfNXNP3Vw==",
"license": "BSD-3-Clause", "license": "BSD-3-Clause",
"engines": { "engines": {
"node": ">=0.10.0" "node": ">=0.10.0"
@@ -799,15 +799,15 @@
} }
}, },
"node_modules/vite": { "node_modules/vite": {
"version": "8.3.0", "version": "8.3.4",
"resolved": "https://registry.npmjs.org/vite/-/vite-8.3.0.tgz", "resolved": "https://registry.npmjs.org/vite/-/vite-8.3.4.tgz",
"integrity": "sha512-lhZBVvEHefgE+HQZC9O7EBJgCU/nVzFNl7vkS4RE0APtWLP02/8QVIkQtzBxPquh7lq5/78NHipTj7ODQ6XuyQ==", "integrity": "sha512-IftLE8phJhdNRIGNEV4JCCvfNScoZQVfcXaN8TQropWGJtOHcu+iAB9pHcuGvmEb/kddw0LBe/jS8ztdC6xdiQ==",
"license": "MIT", "license": "MIT",
"dependencies": { "dependencies": {
"lightningcss": "^1.33.0", "lightningcss": "^1.33.0",
"picomatch": "^4.0.7", "picomatch": "^4.0.7",
"postcss": "^8.5.28", "postcss": "^8.5.29",
"rolldown": "~1.2.6", "rolldown": "~1.2.12",
"tinyglobby": "^0.2.17" "tinyglobby": "^0.2.17"
}, },
"bin": { "bin": {
+10
View File
@@ -243,6 +243,16 @@
block-size: 100%; block-size: 100%;
} }
/*
* resources/views/livewire/share-download.blade.php: a long file list scrolls on its own, as the
* upload page's does, so the download buttons stay near the top of the page. It is the page's main
* content, so it may take more of the window.
*/
.share-file-list {
max-block-size: min(32rem, 60dvh);
overflow-y: auto;
}
/* /*
* resources/views/livewire/share-download.blade.php: the private text once the recipient shows it, * resources/views/livewire/share-download.blade.php: the private text once the recipient shows it,
* as it was typed — its line breaks kept and a long word or key wrapped rather than overflowing. * as it was typed — its line breaks kept and a long word or key wrapped rather than overflowing.
+1
View File
@@ -2,3 +2,4 @@
import '../../vendor/nonameweb/livewire-material/resources/js/material.js' import '../../vendor/nonameweb/livewire-material/resources/js/material.js'
import './share-created.js' import './share-created.js'
import './share-uploader.js' import './share-uploader.js'
import './share-downloader.js'
+251
View File
@@ -0,0 +1,251 @@
/**
* `shareDownloader`: the download page's file list. It remembers, in this browser, which files the
* recipient has downloaded, and where the browser can write to a folder (the File System Access
* API: Chrome and Edge on a computer) it downloads every file into the folder the recipient picks,
* one at a time, in its folder path.
*
* One request per file keeps every request short enough for a proxy in front of the server. A
* request that breaks off is retried after 1, 2, 4, 8 and 16 seconds from the byte the file on
* disk has reached (an HTTP Range request); a file already there at its full size is skipped, so
* running it again after a stop picks up where it stopped. A file that still fails is listed for
* the Retry button; a share that is gone (404) stops the run.
*/
const RETRY_DELAYS = [1000, 2000, 4000, 8000, 16000]
const UNITS = ['B', 'KB', 'MB', 'GB', 'TB']
function formatSize(bytes) {
let unit = 0
while (bytes >= 1024 && unit < UNITS.length - 1) {
bytes /= 1024
unit++
}
return `${bytes.toFixed(unit === 0 ? 0 : 1)} ${UNITS[unit]}`
}
function readStored(key) {
try {
return JSON.parse(window.localStorage.getItem(key)) ?? []
} catch {
return []
}
}
/** The file's handle under the picked folder, creating its subfolders; never a path out of it. */
async function fileHandle(directory, path) {
const segments = path.split('/').filter((segment) => segment !== '' && segment !== '.' && segment !== '..')
const name = segments.pop()
for (const segment of segments) {
directory = await directory.getDirectoryHandle(segment, { create: true })
}
return directory.getFileHandle(name, { create: true })
}
document.addEventListener('alpine:init', () => {
window.Alpine.data('shareDownloader', ({ token, files, messages }) => {
const storageKey = `sealshare.downloaded.${token}`
const total = files.reduce((sum, file) => sum + file.size, 0)
// Kept out of Alpine's reactive data: a proxied native handle throws on its own methods.
let directory = null
let controller = null
return {
supported: window.isSecureContext && 'showDirectoryPicker' in window,
/** The ids of the files this browser has downloaded. */
done: readStored(storageKey),
running: false,
/** Bytes of the run's files on disk, for the progress bar. */
received: 0,
/** How many of the run's files are in the folder. */
saved: 0,
/** The file on its way: its path for the status line, its id for its row in the list. */
current: null,
currentId: null,
/** The files that failed, kept for the Retry button. */
failed: [],
/** Why the run ended early, if it did. */
error: null,
finished: false,
get progress() {
return total === 0 ? 100 : (this.received / total) * 100
},
get status() {
return messages.progress
.replace(':saved', this.saved)
.replace(':count', files.length)
.replace(':received', formatSize(this.received))
.replace(':total', formatSize(total))
},
isDone(id) {
return this.done.includes(id)
},
markDone(id) {
if (this.done.includes(id)) {
return
}
this.done.push(id)
try {
window.localStorage.setItem(storageKey, JSON.stringify(this.done))
} catch {
// Private mode or storage blocked: the marks last as long as the page.
}
},
async downloadAll() {
try {
directory = await window.showDirectoryPicker({ id: 'sealshare', mode: 'readwrite' })
} catch {
return
}
this.run(files)
},
retry() {
this.run(this.failed)
},
cancel() {
controller?.abort()
},
async run(list) {
controller = new AbortController()
this.running = true
this.finished = false
this.error = null
this.failed = []
this.saved = files.length - list.length
this.received = total - list.reduce((sum, file) => sum + file.size, 0)
this.downloaded = true
for (const file of list) {
const before = this.received
this.current = file.path
this.currentId = file.id
try {
await this.save(file, controller.signal)
this.saved++
this.markDone(file.id)
} catch (error) {
if (controller.signal.aborted) {
break
}
if (error.status === 404) {
this.error = messages.gone
break
}
this.failed.push(file)
this.received = before + file.size
}
}
this.running = false
this.current = null
this.currentId = null
this.finished = ! controller.signal.aborted
},
async save(file, signal) {
const handle = await fileHandle(directory, file.path)
const before = this.received
// ponytail: a file is matched by name and size only, so a different file of the same name and size already in the picked folder is kept; compare a checksum if that ever bites.
let written = (await handle.getFile()).size
if (written > file.size) {
written = 0
}
for (let attempt = 0; written < file.size; attempt++) {
try {
written = await this.fetchInto(handle, file, written, signal, (bytes) => (this.received = before + bytes))
} catch (error) {
if (signal.aborted || error.status === 404 || attempt >= RETRY_DELAYS.length) {
throw error
}
await new Promise((resolve) => setTimeout(resolve, RETRY_DELAYS[attempt]))
written = (await handle.getFile()).size
}
}
this.received = before + file.size
},
/** Write the file from byte `offset` on; the bytes that arrived are kept even when the connection breaks. */
async fetchInto(handle, file, offset, signal, onProgress) {
const response = await fetch(file.url, {
headers: offset > 0 ? { Range: `bytes=${offset}-` } : {},
signal,
})
if (! response.ok) {
throw Object.assign(new Error(`HTTP ${response.status}`), { status: response.status })
}
if (response.status !== 206) {
offset = 0
}
const writable = await handle.createWritable({ keepExistingData: offset > 0 })
const reader = response.body.getReader()
try {
await writable.truncate(offset)
await writable.seek(offset)
for (;;) {
const { done, value } = await reader.read()
if (done) {
break
}
await writable.write(value)
offset += value.length
onProgress(offset)
}
} finally {
// Closing commits what was written, so a retry continues from there.
await writable.close().catch(() => {})
}
if (offset < file.size) {
throw new Error('The download ended early')
}
return offset
},
warnBeforeLeaving(event) {
if (this.running) {
event.preventDefault()
event.returnValue = ''
}
},
}
})
})
+2 -1
View File
@@ -53,7 +53,8 @@ document.addEventListener('alpine:init', () => {
}, },
choose(event) { choose(event) {
this.add([...event.target.files].map((file) => ({ file, path: null }))) // A chosen folder's files carry their path from it, as a dropped folder's do.
this.add([...event.target.files].map((file) => ({ file, path: file.webkitRelativePath || null })))
event.target.value = '' event.target.value = ''
}, },
@@ -45,9 +45,14 @@
<p class="md-type-body-md md-ink-variant md-text-center">{{ __('or click to browse') }}</p> <p class="md-type-body-md md-ink-variant md-text-center">{{ __('or click to browse') }}</p>
</x-stack> </x-stack>
{{-- The button is the tab stop and opens the browser's own picker; the input only carries the selection. --}} {{-- Each button is a tab stop and opens the browser's own picker, for files or for a folder with
<x-button :label="__('Browse Files')" icon="folder_open" variant="outlined" x-on:click="$refs.picker.click()" x-bind:disabled="! secure" /> everything in it; the inputs only carry the selection. --}}
<x-row gap="space100" justify="center" wrap>
<x-button :label="__('Browse Files')" icon="upload_file" variant="outlined" x-on:click="$refs.picker.click()" x-bind:disabled="! secure" />
<x-button :label="__('Browse Folder')" icon="folder_open" variant="outlined" x-on:click="$refs.folderPicker.click()" x-bind:disabled="! secure" data-test="browse-folder" />
</x-row>
<input type="file" multiple hidden x-ref="picker" x-on:change="choose($event)" x-bind:disabled="! secure" data-test="file-input" /> <input type="file" multiple hidden x-ref="picker" x-on:change="choose($event)" x-bind:disabled="! secure" data-test="file-input" />
<input type="file" webkitdirectory hidden x-ref="folderPicker" x-on:change="choose($event)" x-bind:disabled="! secure" data-test="folder-input" />
</x-stack> </x-stack>
</div> </div>
@@ -73,28 +73,88 @@
@endif @endif
@if ($files->isNotEmpty()) @if ($files->isNotEmpty())
<x-card :title="__('Shared Files')" heading="h2" variant="outlined"> {{-- Which files this browser has downloaded is remembered per share (resources/js/share-downloader.js),
<x-stack gap="space200"> and where the browser can write to a folder, "Download all to a folder" fetches them one at a
<x-list :label="__('Shared Files')"> time, each resumable, which a single ZIP of a large share is not. --}}
@foreach ($files as $file) <x-card
<x-list-item :title="__('Shared Files')"
:title="$file->relative_path ?: $file->original_name" :subtitle="trans_choice('{1} :count file, :size|[2,*] :count files, :size', $files->count(), ['size' => Number::fileSize($files->sum('file_size'))])"
icon="description" heading="h2"
wire:key="file-{{ $file->id }}" variant="outlined"
> >
<x-slot:description><span class="md-tabular">{{ Number::fileSize($file->file_size) }}</span></x-slot:description> <x-stack
<x-slot:end> gap="space200"
<x-button icon="download" :link="route('share.download.file', [$share, $file])" no-wire-navigate :aria-label="__('Download :name', ['name' => $file->original_name])" x-on:click="downloaded = true" /> x-data="shareDownloader({
</x-slot:end> token: {{ \Illuminate\Support\Js::from($share->token) }},
</x-list-item> files: {{ \Illuminate\Support\Js::from($downloads) }},
@endforeach messages: {{ \Illuminate\Support\Js::from([
</x-list> 'progress' => __(':saved of :count files, :received of :total'),
'gone' => __('This share is no longer available.'),
]) }},
})"
x-on:beforeunload.window="warnBeforeLeaving($event)"
>
<div class="share-file-list" data-test="share-file-list">
<x-list :label="__('Shared Files')">
@foreach ($files as $file)
<x-list-item
:title="$file->relative_path ?: $file->original_name"
icon="description"
wire:key="file-{{ $file->id }}"
>
<x-slot:description><span class="md-tabular">{{ Number::fileSize($file->file_size) }}</span></x-slot:description>
<x-slot:end>
<x-row gap="space100">
{{-- The file the folder download is on; its row, always shown, is brought into view in the list as it starts. --}}
<span
x-show="currentId === {{ $file->id }}"
x-effect="if (currentId === {{ $file->id }}) $el.closest('[data-md-list-item]').scrollIntoView({ block: 'nearest' })"
x-cloak
data-test="file-downloading"
>
<x-loading size="24" :label="__('Downloading')" />
</span>
<span x-show="isDone({{ $file->id }}) && currentId !== {{ $file->id }}" x-cloak data-test="file-downloaded">
<x-icon name="download_done" class="md-ink-success" :label="__('Downloaded')" />
</span>
<x-button icon="download" :link="route('share.download.file', [$share, $file])" no-wire-navigate :aria-label="__('Download :name', ['name' => $file->original_name])" x-on:click="downloaded = true; markDone({{ $file->id }})" />
</x-row>
</x-slot:end>
</x-list-item>
@endforeach
</x-list>
</div>
<x-row justify="end"> <div x-show="running || finished" x-cloak data-test="folder-download">
<x-stack gap="space100">
<x-row justify="between">
<span class="md-type-label-lg md-tabular" x-text="status"></span>
<x-button :label="__('Cancel')" size="xs" x-show="running" x-on:click="cancel()" />
</x-row>
<x-progress bind="progress" :label="__('Downloading')" />
<p class="md-type-body-sm md-ink-variant" x-show="running" x-text="current"></p>
<p class="md-type-body-sm md-ink-success" x-show="finished && failed.length === 0">{{ __('All files are in the folder.') }}</p>
</x-stack>
</div>
<div x-show="error" x-cloak>
<x-alert color="error" assertive><span x-text="error"></span></x-alert>
</div>
<div x-show="! running && failed.length > 0" x-cloak>
<x-alert color="error" assertive>
{{ __('Files that could not be downloaded:') }} <span class="md-tabular" x-text="failed.length"></span>
<x-slot:actions><x-button :label="__('Retry')" x-on:click="retry()" /></x-slot:actions>
</x-alert>
</div>
<x-row justify="end" gap="space100" wrap x-show="! running">
@if ($files->count() > 1) @if ($files->count() > 1)
<x-button :label="__('Download All as ZIP')" icon="download" variant="filled" :link="route('share.download.all', $share)" no-wire-navigate x-on:click="downloaded = true" /> <x-button :label="__('Download All as ZIP')" icon="folder_zip" variant="tonal" :link="route('share.download.all', $share)" no-wire-navigate x-show="supported" x-cloak x-on:click="downloaded = true" />
<x-button :label="__('Download all to a folder')" icon="download" variant="filled" x-show="supported" x-cloak x-on:click="downloadAll()" data-test="download-to-folder" />
<x-button :label="__('Download All as ZIP')" icon="download" variant="filled" :link="route('share.download.all', $share)" no-wire-navigate x-show="! supported" x-on:click="downloaded = true" />
@else @else
<x-button :label="__('Download')" icon="download" variant="filled" :link="route('share.download.file', [$share, $files->first()])" no-wire-navigate x-on:click="downloaded = true" /> <x-button :label="__('Download')" icon="download" variant="filled" :link="route('share.download.file', [$share, $files->first()])" no-wire-navigate x-on:click="downloaded = true; markDone({{ $files->first()->id }})" />
@endif @endif
</x-row> </x-row>
</x-stack> </x-stack>
+108
View File
@@ -242,3 +242,111 @@ test('the admin settings page has six sections, each a card headed by an h2', fu
expect($result['cardCount'])->toBe(6); expect($result['cardCount'])->toBe(6);
expect($result['everyCardHeaded'])->toBeTrue(); expect($result['everyCardHeaded'])->toBeTrue();
}); });
test('download all to a folder writes every file in its folder path, resumes a partial file and marks them downloaded', function () {
config(['uploads.chunk_size' => 1000]);
$binary = random_bytes(2500);
$share = app(ShareService::class)->createShare([
['file' => UploadedFile::fake()->createWithContent('notes.txt', 'hello folder download'), 'relativePath' => null],
['file' => UploadedFile::fake()->createWithContent('photo.bin', $binary), 'relativePath' => 'holiday/photo.bin'],
]);
$page = ready(visit(route('share.download', $share, false)));
// The browser's private file system stands in for the folder the recipient would pick; notes.txt
// is already half there, as a stopped run leaves it.
$page->script("(async () => {
const root = await navigator.storage.getDirectory();
for await (const name of root.keys()) { await root.removeEntry(name, { recursive: true }); }
const partial = await (await root.getFileHandle('notes.txt', { create: true })).createWritable();
await partial.write('hello ');
await partial.close();
window.showDirectoryPicker = () => Promise.resolve(root);
Alpine.\$data(document.querySelector('[data-test=download-to-folder]')).supported = true;
})()");
$page->click('[data-test="download-to-folder"]');
$page->assertScript("Alpine.\$data(document.querySelector('[data-test=folder-download]')).finished === true");
$files = $page->script("(async () => {
const root = await navigator.storage.getDirectory();
const notes = await (await root.getFileHandle('notes.txt')).getFile();
const photo = await (await (await root.getDirectoryHandle('holiday')).getFileHandle('photo.bin')).getFile();
const bytes = new Uint8Array(await photo.arrayBuffer());
return { notes: await notes.text(), photo: btoa(String.fromCharCode(...bytes)) };
})()");
expect($files['notes'])->toBe('hello folder download');
expect(base64_decode($files['photo']))->toBe($binary);
$page->assertScript("[...document.querySelectorAll('[data-test=file-downloaded]')].filter((mark) => mark.offsetParent !== null).length === 2")
->assertNoJavaScriptErrors();
});
test('Browse Folder picks a whole folder and keeps each file\'s path in it', function () {
$page = ready(visit('/upload'));
$page->assertScript("document.querySelector('[data-test=folder-input]').webkitdirectory === true");
// A folder picker's files, as the browser hands them over: each with its path from the folder.
$page->script("(() => {
const file = new File(['inside the folder'], 'notes.txt', { type: 'text/plain' });
Object.defineProperty(file, 'webkitRelativePath', { value: 'holiday/docs/notes.txt' });
Alpine.\$data(document.querySelector('[data-test=drop-zone]')).choose({ target: { files: [file], value: '' } });
})()");
$page->assertSee('holiday/docs/notes.txt')
->assertNoJavaScriptErrors();
});
test('a long file list scrolls on its own and keeps the download buttons on the first screen', function () {
$share = app(ShareService::class)->createShare(collect(range(1, 40))->map(fn (int $number): array => [
'file' => UploadedFile::fake()->createWithContent("file-{$number}.txt", "file {$number}"),
'relativePath' => null,
])->all());
$page = ready(visit(route('share.download', $share, false))->resize(1280, 800));
$page->assertScript("(() => {
const list = document.querySelector('[data-test=share-file-list]');
return list.scrollHeight > list.clientHeight && getComputedStyle(list).overflowY === 'auto';
})()")
->assertScript("[...document.querySelectorAll('[data-md-button]')].filter((button) => button.offsetParent !== null && button.textContent.trim().toLowerCase().startsWith('download all')).every((button) => button.getBoundingClientRect().bottom <= window.innerHeight)")
->assertNoJavaScriptErrors();
});
test('the folder download marks the file it is on and scrolls the list to it', function () {
$share = app(ShareService::class)->createShare(collect(range(1, 40))->map(fn (int $number): array => [
'file' => UploadedFile::fake()->createWithContent("file-{$number}.txt", "file {$number}"),
'relativePath' => null,
])->all());
$last = $share->files->last();
$page = ready(visit(route('share.download', $share, false))->resize(1280, 800));
// Every file but the last is already in the folder, and the last one's request never answers,
// so the run stays on it.
$page->script("(async () => {
const root = await navigator.storage.getDirectory();
for await (const name of root.keys()) { await root.removeEntry(name, { recursive: true }); }
for (let number = 1; number < 40; number++) {
const writable = await (await root.getFileHandle(`file-\${number}.txt`, { create: true })).createWritable();
await writable.write(`file \${number}`);
await writable.close();
}
window.showDirectoryPicker = () => Promise.resolve(root);
window.fetch = () => new Promise(() => {});
Alpine.\$data(document.querySelector('[data-test=download-to-folder]')).supported = true;
})()");
$page->click('[data-test="download-to-folder"]');
$page->assertScript("[...document.querySelectorAll('[data-test=file-downloading]')].filter((mark) => mark.offsetParent !== null).length === 1")
->assertScript("(() => {
const mark = [...document.querySelectorAll('[data-test=file-downloading]')].find((mark) => mark.offsetParent !== null);
const row = mark.closest('[data-md-list-item]');
const list = document.querySelector('[data-test=share-file-list]').getBoundingClientRect();
const rect = row.getBoundingClientRect();
return row.textContent.includes('{$last->original_name}') && rect.top >= list.top - 1 && rect.bottom <= list.bottom + 1;
})()")
->assertNoJavaScriptErrors();
});
+14
View File
@@ -20,6 +20,20 @@ test('reset password link can be requested', function () {
Notification::assertSentTo($user, ResetPassword::class); Notification::assertSentTo($user, ResetPassword::class);
}); });
test('the reset link points at APP_URL, whatever host the request claims', function () {
Notification::fake();
config(['app.url' => 'https://share.example.com']);
$user = User::factory()->create();
$this->withHeader('X-Forwarded-Host', 'attacker.example')
->post(route('password.request'), ['email' => $user->email]);
Notification::assertSentTo($user, ResetPassword::class, function (ResetPassword $notification) use ($user) {
return str_starts_with($notification->toMail($user)->actionUrl, 'https://share.example.com/reset-password/');
});
});
test('reset password screen can be rendered', function () { test('reset password screen can be rendered', function () {
Notification::fake(); Notification::fake();
+17
View File
@@ -10,6 +10,7 @@ use App\Services\ShareService;
use Illuminate\Http\UploadedFile; use Illuminate\Http\UploadedFile;
use Illuminate\Support\Facades\RateLimiter; use Illuminate\Support\Facades\RateLimiter;
use Illuminate\Support\Facades\Storage; use Illuminate\Support\Facades\Storage;
use Livewire\Features\SupportLockedProperties\CannotUpdateLockedPropertyException;
use Livewire\Livewire; use Livewire\Livewire;
// --- Session stores derived key, not plaintext password --- // --- Session stores derived key, not plaintext password ---
@@ -35,6 +36,22 @@ test('session stores derived encryption key instead of plaintext password', func
expect(strlen(session('share_key_'.$share->token)))->toBe(64); expect(strlen(session('share_key_'.$share->token)))->toBe(64);
}); });
// --- The password gate cannot be opened from the browser ---
test('a visitor without the password cannot unlock a share\'s file list from the browser', function () {
Storage::fake('shares');
$share = app(ShareService::class)->createShare([
['file' => UploadedFile::fake()->createWithContent('salary-review.pdf', 'secret'), 'relativePath' => null],
], [
'password' => 'test-password-secure',
]);
Livewire::test(ShareDownload::class, ['share' => $share])
->assertDontSee('salary-review.pdf')
->set('authenticated', true);
})->throws(CannotUpdateLockedPropertyException::class);
// --- Rate limiting on password verification --- // --- Rate limiting on password verification ---
test('rate limiting blocks after 5 failed password attempts', function () { test('rate limiting blocks after 5 failed password attempts', function () {
+71 -2
View File
@@ -18,6 +18,15 @@ test('share download page renders for valid share', function () {
$response->assertOk(); $response->assertOk();
}); });
test('share download page says how many files the share holds and their size', function () {
Storage::fake('shares');
$share = createShareWithFiles();
$response = $this->get(route('share.download', $share));
$response->assertSee('3 files, 31 B');
});
test('share download page returns 404 for expired share', function () { test('share download page returns 404 for expired share', function () {
$share = Share::factory()->expired()->create(); $share = Share::factory()->expired()->create();
@@ -100,7 +109,10 @@ test('zip download streams a valid archive with every file\'s original content',
]); ]);
$zipPath = tempnam(sys_get_temp_dir(), 'zip'); $zipPath = tempnam(sys_get_temp_dir(), 'zip');
file_put_contents($zipPath, $this->get(route('share.download.all', $share))->streamedContent()); $response = $this->get(route('share.download.all', $share));
file_put_contents($zipPath, $content = $response->streamedContent());
$response->assertHeader('Content-Length', strlen($content));
$zip = new ZipArchive; $zip = new ZipArchive;
expect($zip->open($zipPath))->toBeTrue(); expect($zip->open($zipPath))->toBeTrue();
@@ -111,6 +123,46 @@ test('zip download streams a valid archive with every file\'s original content',
unlink($zipPath); unlink($zipPath);
}); });
test('a range request gets the file from that byte on, decrypted across chunks', function (string $range, int $start, int $end) {
Storage::fake('shares');
config(['uploads.chunk_size' => 1000]);
$binary = random_bytes(2500);
$share = app(ShareService::class)->createShare([
['file' => UploadedFile::fake()->createWithContent('photo.bin', $binary), 'relativePath' => null],
]);
$response = $this->get(route('share.download.file', [$share, $share->files->first()]), ['Range' => $range]);
$response->assertStatus(206)
->assertHeader('Content-Range', "bytes {$start}-{$end}/2500")
->assertHeader('Content-Length', $end - $start + 1);
expect($response->streamedContent())->toBe(substr($binary, $start, $end - $start + 1));
})->with([
'to the end' => ['bytes=1500-', 1500, 2499],
'across a chunk boundary' => ['bytes=999-1000', 999, 1000],
'the last bytes' => ['bytes=-10', 2490, 2499],
]);
test('a range request for another version of the file gets the whole file', function () {
Storage::fake('shares');
$share = createShareWithFile(content: 'whole file');
$response = $this->get(route('share.download.file', [$share, $share->files->first()]), ['Range' => 'bytes=6-', 'If-Range' => '"other"']);
$response->assertOk()->assertHeader('Accept-Ranges', 'bytes');
expect($response->streamedContent())->toBe('whole file');
});
test('a range past the end of the file is refused and uses no download', function () {
Storage::fake('shares');
$share = createShareWithFile(content: 'short');
$response = $this->get(route('share.download.file', [$share, $share->files->first()]), ['Range' => 'bytes=5-']);
$response->assertStatus(416)->assertHeader('Content-Range', 'bytes */5');
expect($share->fresh()->download_count)->toBe(0);
});
test('the last download streams and the share stays for the cleanup, with the time of that download', function () { test('the last download streams and the share stays for the cleanup, with the time of that download', function () {
Storage::fake('shares'); Storage::fake('shares');
$this->freezeSecond(); $this->freezeSecond();
@@ -170,6 +222,20 @@ test('the recipient who took the last download can no longer open the share an h
'download one file' => 'share.download.file', 'download one file' => 'share.download.file',
]); ]);
test('each download keeps the recipient\'s window open', function () {
Storage::fake('shares');
$share = createShareWithFiles(maxDownloads: 1);
$this->get(route('share.download.file', [$share, $share->files->first()]));
$this->travel(50)->minutes();
$this->get(route('share.download.file', [$share, $share->files->first()]));
$this->travel(50)->minutes();
$response = $this->get(route('share.download.file', [$share, $share->files->last()]));
$response->assertOk();
expect($share->fresh()->download_count)->toBe(1);
});
test('a recipient whose window has ended uses another download when one is left', function () { test('a recipient whose window has ended uses another download when one is left', function () {
Storage::fake('shares'); Storage::fake('shares');
$share = createShareWithFiles(maxDownloads: 2); $share = createShareWithFiles(maxDownloads: 2);
@@ -368,7 +434,10 @@ test('the zip of a mixed share has only the files, not the private text', functi
); );
$zipPath = tempnam(sys_get_temp_dir(), 'zip'); $zipPath = tempnam(sys_get_temp_dir(), 'zip');
file_put_contents($zipPath, $this->get(route('share.download.all', $share))->streamedContent()); $response = $this->get(route('share.download.all', $share));
file_put_contents($zipPath, $content = $response->streamedContent());
$response->assertHeader('Content-Length', strlen($content));
$zip = new ZipArchive; $zip = new ZipArchive;
expect($zip->open($zipPath))->toBeTrue(); expect($zip->open($zipPath))->toBeTrue();