surtic86andClaude Opus 5.5
84c8b81f0a
Fixes the nine findings of security audit run 1 on 2.4.1 (T1-T11). F1: Uploads that are not complete now count only the bytes the server received, and a chunk that goes above the storage quota gets 422. An anonymous uploader can no longer fill the quota with declared sizes. F2: The share password and the admin login have a second limit without the address (20 attempts per minute per share and per e-mail), because a forged X-Forwarded-For changes the address. F3: The system password gate and the admin check now also run on Livewire updates, so an old uploader snapshot cannot register files. F4: The session keeps a fingerprint of the system password's hash. When the admin changes the system password, earlier verifications end. F5: The page after the upload opens only in the session that created the share, and only while recipients can still reach the share. F6: The share password limit counts an attempt before the password is checked, so parallel attempts cannot pass it. F7: The system password has the same two limits (5 per address, 20 in total per minute). F8: A password change or reset signs the user's other sessions out. F9: The only admin cannot delete the account, which would open /setup to every visitor. The setup wizard also holds the admin password to the password defaults, and Livewire applies EnsureAdmin to updates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
48 lines
1.4 KiB
PHP
48 lines
1.4 KiB
PHP
<?php
|
|
|
|
namespace App\Livewire;
|
|
|
|
use App\Models\Setting;
|
|
use App\Models\Share;
|
|
use App\Services\QrCodeService;
|
|
use Illuminate\Support\Facades\Crypt;
|
|
use Livewire\Attributes\Layout;
|
|
use Livewire\Attributes\Locked;
|
|
use Livewire\Component;
|
|
|
|
#[Layout('layouts.app')]
|
|
class ShareCreated extends Component
|
|
{
|
|
public Share $share;
|
|
|
|
/** The share's password, offered once to the uploader who just set it; `null` on a reload. */
|
|
#[Locked]
|
|
public ?string $password = null;
|
|
|
|
public function mount(Share $share): void
|
|
{
|
|
// Only for the session that created the share, and only while recipients can still reach it.
|
|
abort_unless($share->isCompleted() && ! $share->isExpired() && ! $share->hasReachedDownloadLimit()
|
|
&& in_array($share->token, session('created_shares', []), true), 404);
|
|
|
|
$this->share = $share;
|
|
|
|
$flashedPassword = session('share_password');
|
|
|
|
if (is_array($flashedPassword) && ($flashedPassword['token'] ?? null) === $share->token) {
|
|
$this->password = Crypt::decryptString($flashedPassword['password']);
|
|
}
|
|
}
|
|
|
|
public function render(): mixed
|
|
{
|
|
$shareUrl = route('share.download', $this->share);
|
|
|
|
return view('livewire.share-created', [
|
|
'shareUrl' => $shareUrl,
|
|
'qrCodeSvg' => app(QrCodeService::class)->svg($shareUrl),
|
|
'siteTitle' => Setting::get('site_title') ?: config('app.name'),
|
|
]);
|
|
}
|
|
}
|