Andreas Reinhold / reiniandClaude Opus 5
5853f1f7d6
The pages were built five ways: two layouts, seven widths from 28 to 64rem and four heading styles. Every page now looks like the share pages: a centred heading over one 40rem column of outlined cards, with the floating toolbar below. - <x-page> (components/page.blade.php) is the root of every page. It draws the h1 and its line (`brand` takes the site's logo, title and description from Admin settings), an optional `mark` and `navigation` slot, then the content. It has no width prop: every page is the same <x-pane width="narrow">. - The sign-in, password reset, confirm, verify email, two-factor challenge, setup and system password pages move onto layouts/app with the brand heading and their form in a card titled with the task. layouts/auth, auth-header and the settings heading partial are gone, and so is the per-page width CSS. - Settings put their section nav under the heading; the admin pages get a description line each. FileUploader and ShareDownload no longer pass the branding to their views. - The admin dashboard's table needed about 49rem, so its shares are a list: created above the token, which opens the share, then files, size, downloads and expiry on two lines that wrap instead of clipping, and one delete button. A "Sort by" select replaces the column headers (newest, oldest, expiring soonest with never-expiring last, largest, most downloads, most files) and resets the page. The stats stay two by two. table.css and sort-header.css are no longer imported. - Branding hints in Admin settings name every page the title shows on. - Tests: PageTemplateTest renders every page once and checks one page template, one h1 and the width, and the brand heading with its fallbacks. FrameTest measures the page column instead of the auth card and the 64rem main; dashboard tests follow the list and the sort select, including expiry order. .ai/rules/views.md records <x-page>, the CHANGELOG notes the change and the website screenshots are regenerated. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
77 lines
4.1 KiB
PHP
77 lines
4.1 KiB
PHP
<?php
|
|
|
|
use App\Models\Setting;
|
|
use App\Models\Share;
|
|
use App\Models\User;
|
|
use Illuminate\Support\Facades\Storage;
|
|
use Illuminate\Testing\TestResponse;
|
|
use Tests\TestCase;
|
|
|
|
/**
|
|
* The opening tag of the page template's pane (resources/views/components/page.blade.php).
|
|
*/
|
|
function pageTag(string $html): string
|
|
{
|
|
preg_match('/<div\s[^>]*data-test="page"[^>]*>/', $html, $matches);
|
|
|
|
return $matches[0] ?? '';
|
|
}
|
|
|
|
test('every page is one page template, one h1 and the same width', function (Closure $visit) {
|
|
$html = $visit($this)->assertOk()->getContent();
|
|
|
|
expect(substr_count($html, 'data-test="page"'))->toBe(1)
|
|
->and(preg_match_all('/<h1[\s>]/', $html))->toBe(1)
|
|
->and(pageTag($html))->toContain('data-md-width="narrow"');
|
|
})->with([
|
|
'upload' => [fn (TestCase $test): TestResponse => $test->get(route('upload'))],
|
|
'download' => [fn (TestCase $test): TestResponse => $test->get(route('share.download', Share::factory()->withPassword()->create()))],
|
|
'share created' => [fn (TestCase $test): TestResponse => $test->get(route('share.created', Share::factory()->create()))],
|
|
'login' => [fn (TestCase $test): TestResponse => $test->get(route('login'))],
|
|
'forgot password' => [fn (TestCase $test): TestResponse => $test->get(route('password.request'))],
|
|
'reset password' => [fn (TestCase $test): TestResponse => $test->get(route('password.reset', 'token'))],
|
|
'two-factor challenge' => [fn (TestCase $test): TestResponse => $test->withSession(['login.id' => User::factory()->withTwoFactor()->create()->id])->get(route('two-factor.login'))],
|
|
'setup' => [function (TestCase $test): TestResponse {
|
|
User::query()->where('is_admin', true)->delete();
|
|
|
|
return $test->get(route('setup'));
|
|
}],
|
|
'system password' => [function (TestCase $test): TestResponse {
|
|
Setting::set('system_password', bcrypt('system-secret'));
|
|
|
|
return $test->get(route('system-password'));
|
|
}],
|
|
'verify email' => [fn (TestCase $test): TestResponse => $test->actingAs(User::factory()->unverified()->create())->get(route('verification.notice'))],
|
|
'confirm password' => [fn (TestCase $test): TestResponse => $test->actingAs(User::factory()->create())->get(route('password.confirm'))],
|
|
'profile' => [fn (TestCase $test): TestResponse => $test->actingAs(User::factory()->create())->get(route('profile.edit'))],
|
|
'password' => [fn (TestCase $test): TestResponse => $test->actingAs(User::factory()->create())->get(route('user-password.edit'))],
|
|
'two-factor settings' => [fn (TestCase $test): TestResponse => $test->actingAs(User::factory()->create())->withSession(['auth.password_confirmed_at' => time()])->get(route('two-factor.show'))],
|
|
'appearance' => [fn (TestCase $test): TestResponse => $test->actingAs(User::factory()->create())->get(route('appearance.edit'))],
|
|
'admin settings' => [fn (TestCase $test): TestResponse => $test->actingAs(User::factory()->admin()->create())->get(route('admin.settings'))],
|
|
'admin dashboard' => [fn (TestCase $test): TestResponse => $test->actingAs(User::factory()->admin()->create())->get(route('admin.dashboard'))],
|
|
]);
|
|
|
|
test("a brand page is headed by the site's own logo, title and description", function () {
|
|
Setting::set('site_title', 'Acme Files');
|
|
Setting::set('site_description', 'Send files to Acme Engineering.');
|
|
Setting::set('site_logo', 'branding/acme.png');
|
|
|
|
$html = $this->get(route('login'))
|
|
->assertOk()
|
|
->assertSeeInOrder(['data-test="page-logo"', '<h1', 'Send files to Acme Engineering.'], false)
|
|
->assertSee(Storage::disk('public')->url('branding/acme.png'), false)
|
|
->getContent();
|
|
|
|
expect($html)->toMatch('/<h1[^>]*>\s*Acme Files\s*<\/h1>/');
|
|
});
|
|
|
|
test('a brand page falls back to the app name and SealShare\'s own line without branding', function () {
|
|
$html = $this->get(route('upload'))
|
|
->assertOk()
|
|
->assertSeeInOrder(['<h1', 'Share your files safely and securely'], false)
|
|
->assertDontSee('data-test="page-logo"', false)
|
|
->getContent();
|
|
|
|
expect($html)->toMatch('/<h1[^>]*>\s*'.preg_quote(config('app.name'), '/').'\s*<\/h1>/');
|
|
});
|