Files
SealShare/tests/Feature/SecurityAuditTest.php
Andreas Reinhold / reiniandClaude Opus 5 40e35bab0e Encrypt uploads in the browser and send them in chunks
A 6 GB upload kept a customer waiting long after its progress bar
reached 100%. The server wrote every upload three times: PHP's
temporary file, Livewire's copy of it ("Processing files...") and the
encrypted file ("Create Share Link"), each a full rewrite of a slow
disk. The unencrypted copy also stayed behind in livewire-tmp.

Now the uploader's browser encrypts each file in 16 MB chunks with
WebCrypto and PUTs them one at a time; the server checks each chunk in
memory and writes it once, already encrypted. Creating the share only
wraps its key and saves the options. A 200 MB upload through the
Docker image took 2.8 s, and its download matched byte for byte.

- SEALCHK2: a 19-byte header (chunk size, 7-byte nonce prefix), then
  ciphertext and tag per chunk. Each nonce holds the chunk index and a
  last-chunk flag (the STREAM construction), so cut or reordered files
  fail to decrypt. SEALCHK1 and the single-block format still read.
- Envelope encryption: one random key per share. With a password it is
  wrapped with Argon2id (sodium, libsodium's interactive limits) in
  shares.wrapped_key, which names its parameters. Password shares from
  before keep their PBKDF2-derived key.
- The upload page registers each selection with FileUploader into a
  pending share of its own, lists the files with their progress, retries
  a failed chunk after 1-16 s, then offers Retry; Remove and Cancel
  abort. UploadChunkController only accepts chunks from the session that
  started the share: a repeat is acknowledged, a skip gets 409 with the
  count stored. Chunks go out as Blobs, which Chromium sends about eight
  times faster than ArrayBuffers.
- Uploads need a secure context: over plain HTTP the page says HTTPS is
  needed and takes no files. The Docker image gains AUTO_HTTPS, which
  serves Let's Encrypt on 443 for SERVER_NAME and redirects 80; without
  it the container stays on HTTP 80 behind a proxy. docker/Caddyfile was
  never loaded and is gone; docker/healthcheck.sh covers both modes.
- "Download all" streams the ZIP with maennchen/zipstream-php (STORE,
  ZIP64) instead of decrypting whole files into memory and writing the
  archive unencrypted to /tmp.
- Pending shares count towards the quota, stay out of the admin
  dashboard and 404 everywhere else. shares:cleanup deletes uploads idle
  for 4 hours and Livewire temporary files older than that.
- PHP's upload limits no longer cap the admin's max file size and
  default to 64M; LIVEWIRE_MAX_UPLOAD_TIME is gone and
  UPLOAD_CHUNK_SIZE_MB is new.
- Tests cover the format, key wrapping, registration limits, the chunk
  endpoint's answers, completing a share, the streamed ZIP, cleanup,
  and in Chromium a real chunked upload and the HTTPS warning; the
  selected-files overflow test runs again. README, website, CHANGELOG
  and .ai/rules follow.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-16 20:49:17 +02:00

227 lines
7.2 KiB
PHP

<?php
use App\Livewire\Admin\AdminSettings;
use App\Livewire\FileUploader;
use App\Livewire\ShareDownload;
use App\Models\Share;
use App\Models\ShareFile;
use App\Models\User;
use App\Services\ShareService;
use Illuminate\Http\UploadedFile;
use Illuminate\Support\Facades\RateLimiter;
use Illuminate\Support\Facades\Storage;
use Livewire\Livewire;
// --- Session stores derived key, not plaintext password ---
test('session stores derived encryption key instead of plaintext password', function () {
Storage::fake('shares');
$service = app(ShareService::class);
$file = UploadedFile::fake()->create('file.txt', 100);
$share = $service->createShare([
['file' => $file, 'relativePath' => null],
], [
'password' => 'test-password-secure',
]);
Livewire::test(ShareDownload::class, ['share' => $share])
->set('password', 'test-password-secure')
->call('verifyPassword');
expect(session('share_key_'.$share->token))->not->toBeNull();
expect(session('share_key_'.$share->token))->not->toBe('test-password-secure');
expect(strlen(session('share_key_'.$share->token)))->toBe(64);
});
// --- Rate limiting on password verification ---
test('rate limiting blocks after 5 failed password attempts', function () {
Storage::fake('shares');
$service = app(ShareService::class);
$file = UploadedFile::fake()->create('file.txt', 100);
$share = $service->createShare([
['file' => $file, 'relativePath' => null],
], [
'password' => 'correct-password',
]);
$component = Livewire::test(ShareDownload::class, ['share' => $share]);
for ($i = 0; $i < 5; $i++) {
$component->set('password', 'wrong-password')
->call('verifyPassword')
->assertHasErrors(['password']);
}
$component->set('password', 'correct-password')
->call('verifyPassword')
->assertHasErrors(['password'])
->assertSet('authenticated', false);
});
test('rate limiter clears after successful password verification', function () {
Storage::fake('shares');
$service = app(ShareService::class);
$file = UploadedFile::fake()->create('file.txt', 100);
$share = $service->createShare([
['file' => $file, 'relativePath' => null],
], [
'password' => 'correct-password',
]);
$component = Livewire::test(ShareDownload::class, ['share' => $share]);
$component->set('password', 'wrong-password')
->call('verifyPassword')
->assertHasErrors(['password']);
$component->set('password', 'correct-password')
->call('verifyPassword')
->assertSet('authenticated', true);
$rateLimitKey = 'share-password:'.$share->token.'|127.0.0.1';
expect(RateLimiter::remaining($rateLimitKey, 5))->toBe(5);
});
// --- Share password minimum length ---
test('share password must be at least 8 characters', function () {
Storage::fake('shares');
Livewire::test(FileUploader::class)
->set('usePassword', true)
->set('password', 'short')
->call('createShare')
->assertHasErrors(['password' => 'min']);
});
test('share password of 8 characters is accepted', function () {
Storage::fake('shares');
Livewire::test(FileUploader::class)
->set('usePassword', true)
->set('password', 'longenough')
->call('createShare')
->assertHasNoErrors(['password']);
});
// --- is_admin not mass assignable ---
test('is_admin is not mass assignable on User model', function () {
$user = User::query()->create([
'name' => 'Test User',
'email' => 'mass-assign-test@example.com',
'password' => bcrypt('password'),
'is_admin' => true,
]);
expect($user->is_admin)->toBeFalsy();
});
// --- Setup wizard guard prevents duplicate admins ---
test('setup wizard createAdmin is blocked when admin already exists', function () {
$adminCountBefore = User::query()->where('is_admin', true)->count();
$this->post(route('setup'), [
'name' => 'Second Admin',
'email' => 'second-admin@example.com',
'password' => 'password123',
'password_confirmation' => 'password123',
]);
expect(User::query()->where('email', 'second-admin@example.com')->exists())->toBeFalse();
expect(User::query()->where('is_admin', true)->count())->toBe($adminCountBefore);
});
// --- Content-Disposition sanitization ---
test('content disposition handles special characters in filename', function () {
Storage::fake('shares');
$share = app(ShareService::class)->createShare([
['file' => UploadedFile::fake()->createWithContent('normal.txt', 'test content'), 'relativePath' => null],
]);
$shareFile = $share->files->first();
$shareFile->update(['original_name' => 'file"with"quotes.txt']);
$response = $this->get(route('share.download.file', [$share, $shareFile]));
expect($response->headers->get('Content-Disposition'))
->toContain('attachment')
->not->toContain('file"with"quotes.txt');
});
// --- SVG upload rejected ---
test('svg upload is rejected for site logo', function () {
$admin = User::query()->where('is_admin', true)->first();
Livewire::actingAs($admin)
->test(AdminSettings::class)
->set('maxFileSize', 100)
->set('siteLogo', UploadedFile::fake()->create('logo.svg', 100, 'image/svg+xml'))
->call('saveSettings')
->assertHasErrors(['siteLogo']);
});
// --- Relative path validation (Zip Slip prevention) ---
test('relative paths from a dropped folder that could reach outside the share are dropped', function (string $relativePath) {
Storage::fake('shares');
Livewire::test(FileUploader::class)
->call('registerFiles', [['name' => 'file.txt', 'size' => 100, 'path' => $relativePath]]);
expect(ShareFile::query()->sole()->relative_path)->toBeNull();
})->with([
'directory traversal' => '../../etc/passwd',
'absolute path' => '/etc/passwd',
'windows traversal' => '..\\..\\windows\\system.ini',
]);
test('valid relative paths are preserved', function () {
Storage::fake('shares');
Livewire::test(FileUploader::class)
->call('registerFiles', [['name' => 'file.txt', 'size' => 100, 'path' => 'folder/subfolder/file.txt']]);
expect(ShareFile::query()->sole()->relative_path)->toBe('folder/subfolder/file.txt');
});
// --- Security headers ---
test('security headers are present on responses', function () {
$response = $this->get(route('upload'));
$response->assertHeader('X-Content-Type-Options', 'nosniff');
$response->assertHeader('X-Frame-Options', 'DENY');
$response->assertHeader('Referrer-Policy', 'strict-origin-when-cross-origin');
$response->assertHeader('Permissions-Policy', 'camera=(), microphone=(), geolocation=()');
});
// --- Token collision retry ---
test('share service generates unique tokens', function () {
Storage::fake('shares');
$service = app(ShareService::class);
$shares = [];
for ($i = 0; $i < 5; $i++) {
$file = UploadedFile::fake()->create("file{$i}.txt", 100);
$shares[] = $service->createShare([
['file' => $file, 'relativePath' => null],
]);
}
$tokens = array_map(fn ($s) => $s->token, $shares);
expect(array_unique($tokens))->toHaveCount(5);
});