Slide the sheets and close the search view out in Firefox too
The side sheet, the bottom sheet's panel and the docked search's scrim and view kept `display` alive through their exit with `transition-behavior: allow-discrete`. Firefox does not transition `display` (Chrome 117 and Safari 18 do), and `x-show` sets `display: none` in the frame the exit starts, so in Firefox the sheets vanished instead of sliding out and the search view and scrim vanished instead of fading. The docked search had a second problem in every engine: neither the view nor the scrim had a closed state to transition to, so where `display` was held (Chrome, Safari) the view stood at full opacity for its duration and then disappeared. Each element now carries `x-transition:enter`/`:leave="md-transition"`, the approach the two sheet scrims already took (renamed from `md-scrim-transition` to one name for all of them). The class only switches Alpine to CSS-transition mode, so `x-show` holds `display` for the element's computed transition-duration before hiding it, in every engine, and a reopen during the exit cancels the pending hide; nothing styles it. `display` and `allow-discrete` leave the transitions so Chrome and Safari do not hold a second time. Alpine reads the first `transition-duration` listed, which is the closing slide or fade in each list (the preset panel lists translate before height). The search view now closes back into the bar (opacity 0, `scale: 1 0.9`, the reverse of its `@starting-style` entry) and its scrim fades out on close and when the search turns full screen. Under reduced motion the durations are zero and every one of them closes at once. Four browser tests sample each exit mid-way in the page, in the same round trip as the close: the sheets part of the way to their closed offset, the search scrim and view part of the way faded, each still displayed, then `display: none`. All four fail on main in Firefox (the two search tests in Chrome too) and pass in Chrome, Firefox and Safari. OverlayTest pins the drawer's new transition and the view's markup. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
92e560bef6
commit
15e4fa7ed1
@@ -175,6 +175,55 @@ it('says so when nothing matches, and closes on a press outside or a chosen resu
|
||||
->assertScript("getComputedStyle({$view}).display === 'none'");
|
||||
});
|
||||
|
||||
/**
|
||||
* Presses the open docked search's scrim and samples, in the page and in the same round trip,
|
||||
* whether `$expression` (a number) was ever caught strictly between `$from` and `$to` while the
|
||||
* element was still displayed: the exit ran, rather than the element vanishing at once.
|
||||
*/
|
||||
function searchCloseSample(string $element, string $expression): string
|
||||
{
|
||||
return <<<JS
|
||||
(async () => {
|
||||
const root = document.querySelector('[data-md-search]:has(#find)')
|
||||
root.querySelector('[data-md-search-scrim]').dispatchEvent(new PointerEvent('pointerdown', { bubbles: true }))
|
||||
|
||||
for (let i = 0; i < 80; i++) {
|
||||
const element = root.querySelector('{$element}')
|
||||
const value = {$expression}
|
||||
if (getComputedStyle(element).display !== 'none' && value > 0.02 && value < 0.98) return true
|
||||
await new Promise((resolve) => setTimeout(resolve, 5))
|
||||
}
|
||||
return false
|
||||
})()
|
||||
JS;
|
||||
}
|
||||
|
||||
it('fades the docked search\'s scrim out on close, rather than making it vanish', function () {
|
||||
$root = "document.querySelector('[data-md-search]:has(#find)')";
|
||||
|
||||
$page = pickProbe()
|
||||
->click('#find')
|
||||
// Displayed as well as opaque: until the first frame of its entry the scrim is still
|
||||
// `display: none` at the open state's full opacity.
|
||||
->assertScript("(({ display, opacity }) => display !== 'none' && opacity === '1')(getComputedStyle({$root}.querySelector('[data-md-search-scrim]')))");
|
||||
|
||||
expect($page->script(searchCloseSample('[data-md-search-scrim]', 'parseFloat(getComputedStyle(element).opacity)')))->toBeTrue();
|
||||
|
||||
$page->assertScript("getComputedStyle({$root}.querySelector('[data-md-search-scrim]')).display === 'none'");
|
||||
});
|
||||
|
||||
it('closes the docked search view back into its bar, rather than making it vanish', function () {
|
||||
$view = "document.querySelector('#find-view')";
|
||||
|
||||
$page = pickProbe()
|
||||
->click('#find')
|
||||
->assertScript("getComputedStyle({$view}).display !== 'none' && getComputedStyle({$view}).opacity === '1'");
|
||||
|
||||
expect($page->script(searchCloseSample('[data-md-search-view]', 'parseFloat(getComputedStyle(element).opacity)')))->toBeTrue();
|
||||
|
||||
$page->assertScript("getComputedStyle({$view}).display === 'none'");
|
||||
});
|
||||
|
||||
it('takes the whole screen on a compact window, with a back arrow', function () {
|
||||
$page = pickProbe()->resize(400, 800);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user