Square the full-screen dialog with the M3 corner token, and guard every package view
The one rounded-none left behind by the scale clearing becomes rounded-corner-none, so the design guard's test of the package's own views needs no filter any more: the breakpoint migration landed too. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwx5USif3wFFmxtHg5U1g9
This commit is contained in:
co-authored by
Claude Fable 5.1
parent
f4f0ecb3b8
commit
216a15307a
Generated
+1
-1
@@ -1,5 +1,5 @@
|
|||||||
{
|
{
|
||||||
"name": "agent-afa50210f14592c5f",
|
"name": "livewire-material",
|
||||||
"lockfileVersion": 3,
|
"lockfileVersion": 3,
|
||||||
"requires": true,
|
"requires": true,
|
||||||
"packages": {
|
"packages": {
|
||||||
|
|||||||
@@ -65,7 +65,7 @@
|
|||||||
>
|
>
|
||||||
<div @class([
|
<div @class([
|
||||||
'flex max-h-[inherit] flex-col overflow-y-auto rounded-corner-xl bg-surface-container-high p-6 shadow-elevation-3',
|
'flex max-h-[inherit] flex-col overflow-y-auto rounded-corner-xl bg-surface-container-high p-6 shadow-elevation-3',
|
||||||
'max-medium:h-full max-medium:rounded-none max-medium:p-0 max-medium:pt-[var(--material-safe-top,env(safe-area-inset-top))]' => $fullscreen,
|
'max-medium:h-full max-medium:rounded-corner-none max-medium:p-0 max-medium:pt-[var(--material-safe-top,env(safe-area-inset-top))]' => $fullscreen,
|
||||||
$boxClass,
|
$boxClass,
|
||||||
])>
|
])>
|
||||||
@if ($fullscreen)
|
@if ($fullscreen)
|
||||||
|
|||||||
@@ -196,14 +196,5 @@ it('bans any further pattern', function () {
|
|||||||
it('passes the package\'s own views', function () {
|
it('passes the package\'s own views', function () {
|
||||||
$violations = DesignGuard::scan([__DIR__.'/../../resources/views', __DIR__.'/../../resources/js', __DIR__.'/../../src'])->violations();
|
$violations = DesignGuard::scan([__DIR__.'/../../resources/views', __DIR__.'/../../resources/js', __DIR__.'/../../src'])->violations();
|
||||||
|
|
||||||
// Two checks the package's own views do not pass yet, each owned by another step of
|
expect($violations)->toBe([]);
|
||||||
// docs/plans/material-3-alignment.md. Drop the filter as each lands:
|
|
||||||
// - step 15 migrates every `sm:`/`md:`/`lg:`/`xl:` in these views to M3's window size
|
|
||||||
// classes; until then the breakpoint check reports ~150 of them.
|
|
||||||
// - step 2 replaced the package's own `rounded-full` with `rounded-corner-full` and left
|
|
||||||
// one `rounded-none` in `modal.blade.php` behind.
|
|
||||||
$outstanding = array_values(array_filter($violations, fn (string $violation): bool => ! str_contains($violation, 'Tailwind breakpoint `')
|
|
||||||
&& ! str_contains($violation, 'value outside the M3 scale `rounded-none`')));
|
|
||||||
|
|
||||||
expect($outstanding)->toBe([]);
|
|
||||||
});
|
});
|
||||||
|
|||||||
Reference in New Issue
Block a user