Cut duplicated and speculative code across the package
An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
471d927e64
commit
247c596c3a
+6
-15
@@ -41,15 +41,6 @@ const RETURN_GUARD_MS = 250
|
||||
// counting, so the live region speaks once.
|
||||
const SETTLE_MS = 120
|
||||
|
||||
/** The longest `transition-duration` + `transition-delay` on an element, in ms: zero under reduced motion. */
|
||||
const longestTransition = (element) => {
|
||||
const style = getComputedStyle(element)
|
||||
const ms = (value) => parseFloat(value) * (value.trim().endsWith('ms') ? 1 : 1000)
|
||||
const delays = style.transitionDelay.split(',').map(ms)
|
||||
|
||||
return Math.max(0, ...style.transitionDuration.split(',').map((duration, index) => ms(duration) + (delays[index % delays.length] || 0)))
|
||||
}
|
||||
|
||||
document.addEventListener('alpine:init', () => {
|
||||
window.Alpine.data('materialSearch', (docked = false, announce = {}, trigger = 'bar') => ({
|
||||
open: false,
|
||||
@@ -162,9 +153,9 @@ document.addEventListener('alpine:init', () => {
|
||||
},
|
||||
|
||||
/**
|
||||
* Keeps the full-screen layout for the length of the view's exit. The closed state's
|
||||
* durations are read a frame on, once they are the ones computed; reopening, which counts
|
||||
* `leavings` up, lets a pending end go by.
|
||||
* Keeps the full-screen layout for the length of the view's exit: until the animations the
|
||||
* closed state starts, a frame on, have finished (at once when none run); reopening, which
|
||||
* counts `leavings` up, lets a pending end go by.
|
||||
*/
|
||||
hold() {
|
||||
const leaving = ++this.leavings
|
||||
@@ -172,13 +163,13 @@ document.addEventListener('alpine:init', () => {
|
||||
this.leaving = true
|
||||
|
||||
requestAnimationFrame(() => {
|
||||
const duration = this.$refs.view ? longestTransition(this.$refs.view) : 0
|
||||
const animations = this.$refs.view?.getAnimations() ?? []
|
||||
|
||||
setTimeout(() => {
|
||||
Promise.allSettled(animations.map((animation) => animation.finished)).then(() => {
|
||||
if (leaving === this.leavings) {
|
||||
this.leaving = false
|
||||
}
|
||||
}, duration)
|
||||
})
|
||||
})
|
||||
},
|
||||
|
||||
|
||||
Reference in New Issue
Block a user