Cut duplicated and speculative code across the package
An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
471d927e64
commit
247c596c3a
@@ -17,13 +17,13 @@
|
||||
With a build, the app's own Vite entries (`livewire-material.showcase.vite`) bring the
|
||||
foundation, tokens, scheme and font, and a `<style data-md-error-styles>` beside them inlines
|
||||
this layout's own resources/css/components/error-page.css with the button and shape
|
||||
stylesheets it imports (`ErrorPage::layoutStyles()`, `Stylesheets::bundle()`, cached). An app
|
||||
stylesheets it imports (`ErrorPage::layoutStyles()`, prebuilt in resources/dist/). An app
|
||||
whose entry imports them too (`all.css`) gets the same layered rules twice, which is harmless:
|
||||
the second copy repeats the first, in the same layers. But an error page is also what shows
|
||||
while a deploy has no build yet, so when those tags cannot be made the page brings a
|
||||
stylesheet built in PHP instead: the foundation and this layout's own rules, inlined the same
|
||||
way rather than copied by hand, plus the app's scheme from its scheme data in the same
|
||||
selector shape `material:scheme` writes (`src/Support/ErrorPage.php::fallbackStyles()`). The
|
||||
while a deploy has no build yet, so when those tags cannot be made the page brings a whole
|
||||
stylesheet instead: the foundation and this layout's own rules, prebuilt the same way rather
|
||||
than copied by hand, plus the app's scheme from its scheme data in the same selector shape
|
||||
`material:scheme` writes (`src/Support/ErrorPage.php::fallbackStyles()`). The
|
||||
two paths draw the same `data-md-error-*` hooks by construction, nothing to keep in step by
|
||||
hand. The shape turns once a minute, unless the visitor asks for reduced motion. --}}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user