Cut duplicated and speculative code across the package
An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
471d927e64
commit
247c596c3a
@@ -0,0 +1,45 @@
|
||||
<?php
|
||||
|
||||
use NoNameWeb\LivewireMaterial\Tests\Support\ComponentStylesheet;
|
||||
|
||||
/**
|
||||
* The shared colour-role table badge.css, slider.css, button.css, alert.css and progress.css read
|
||||
* instead of each carrying its own copy: `data-md-color` picks primary, secondary, tertiary,
|
||||
* error, success, warning or info, and each maps to the same four generic variables.
|
||||
*/
|
||||
it('maps every hue to its own role and its tonal container', function (string $color, array $roles) {
|
||||
expect(ComponentStylesheet::read('color')->declarations("[data-md-color='{$color}']"))->toBe([
|
||||
'--md-color' => "var(--md-sys-color-{$roles[0]})",
|
||||
'--md-on-color' => "var(--md-sys-color-{$roles[1]})",
|
||||
'--md-container' => "var(--md-sys-color-{$roles[2]})",
|
||||
'--md-on-container' => "var(--md-sys-color-{$roles[3]})",
|
||||
]);
|
||||
})->with([
|
||||
'primary' => ['primary', ['primary', 'on-primary', 'primary-container', 'on-primary-container']],
|
||||
'secondary' => ['secondary', ['secondary', 'on-secondary', 'secondary-container', 'on-secondary-container']],
|
||||
'tertiary' => ['tertiary', ['tertiary', 'on-tertiary', 'tertiary-container', 'on-tertiary-container']],
|
||||
'error' => ['error', ['error', 'on-error', 'error-container', 'on-error-container']],
|
||||
'success' => ['success', ['success', 'on-success', 'success-container', 'on-success-container']],
|
||||
'warning' => ['warning', ['warning', 'on-warning', 'warning-container', 'on-warning-container']],
|
||||
'info' => ['info', ['info', 'on-info', 'info-container', 'on-info-container']],
|
||||
]);
|
||||
|
||||
it('keeps the generic variables on the element that names the colour', function () {
|
||||
$css = (string) file_get_contents(__DIR__.'/../../../resources/css/components/color.css');
|
||||
|
||||
foreach (['--md-color', '--md-on-color', '--md-container', '--md-on-container'] as $property) {
|
||||
expect($css)->toMatch('/@property '.preg_quote($property, '/')."\\s*\\{\\s*syntax: '\\*';\\s*inherits: false;\\s*\\}/");
|
||||
}
|
||||
});
|
||||
|
||||
it('imports the table from every stylesheet that reads it', function () {
|
||||
$readers = collect(glob(__DIR__.'/../../../resources/css/components/*.css'))
|
||||
->reject(fn (string $file): bool => basename($file) === 'color.css')
|
||||
->filter(fn (string $file): bool => preg_match('/var\(--md-(?:on-)?(?:color|container)\b/', (string) file_get_contents($file)) === 1);
|
||||
|
||||
expect($readers)->not->toBeEmpty();
|
||||
|
||||
foreach ($readers as $file) {
|
||||
expect(str_contains((string) file_get_contents($file), "@import './color.css';"))->toBeTrue(basename($file).' reads the colour table without importing it');
|
||||
}
|
||||
});
|
||||
Reference in New Issue
Block a user