Take full on the searchable choice and the pickers, as on every field
`full` takes the 40rem bound off `[data-md-field]` from `medium`, and `<x-input>`, `<x-password>`, `<x-textarea>`, `<x-select>` and `<x-file>` pass it to the field they draw. `<x-choices searchable>`, `<x-datepicker>` and `<x-timepicker>` draw the same field but did not declare the prop, and their roots only forward `class` and `style`, so `full` reached no element and the field stopped at 40rem: ReStride's time zone choice stood narrower than the rows filling its card. The three now declare `full` and pass it to their field (the date picker's own field, not the dialog's entry fields). `<x-choices>`' chips are not a field and have no bound, so they take `full` and render nothing for it, and a call site can switch `searchable` on and off without it. The docblocks and the skill list every component that takes it. The browser test that bounds a field at 600px now measures a bounded and a `full` searchable choice, date picker and time picker too; it fails without the change in Chrome, Firefox and Safari. A feature test renders `full` on every field-shaped component and none on the chips. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
6d4487feb3
commit
7aa6dc7d33
@@ -81,6 +81,12 @@
|
||||
`medium` it is the disabled filled button, as before. A `spinner` that disables the button while
|
||||
its action runs leaves the FAB on screen. An application's own `hide-below` or condition around
|
||||
a disabled fab button can go.
|
||||
- **`<x-choices searchable>`, `<x-datepicker>` and `<x-timepicker>` take `full`**, as `<x-input>`,
|
||||
`<x-textarea>`, `<x-select>` and `<x-file>` do, to take the 40rem bound off a field from
|
||||
`medium`; the prop did nothing there, so the field stopped at 40rem beside rows that filled their
|
||||
card. `<x-choices>`' chips have no bound and take `full` without a change, so a call site can
|
||||
switch `searchable` on and off. A width rule an application wrote around one of them for this
|
||||
can go.
|
||||
|
||||
## From 2.0.0 to 2.1.0
|
||||
|
||||
|
||||
Reference in New Issue
Block a user