Keep open menus and rich tooltips open through a Livewire render

<x-menu>, <x-fab-menu> and <x-rich-tooltip> gave their popover an id that is new with every render, and Livewire's morph matches an element without a wire:key by its id. So every render of the component around them swapped the popover for a closed copy: an open menu closed, its listeners stayed behind on the old element (Escape or a press outside then left aria-expanded="true" on the trigger and focus unreturned), a keep-open item's wire:click closed its menu when the response came, and a rich tooltip went on showing the detached bubble, so it never opened again. <x-carousel>'s row had the same kind of id: after a render it scrolled without its listeners, and its items stopped re-masking. The popover, the bubble and the row now carry a wire:key, so the morph patches them in place and changes the id and anchor name together with the trigger's, as it already did for everything else. The key goes through an attribute bag: Livewire compiles a wire:key written in a template into the key of the loop iteration around it, which would have given every child component after the menu in a row the same key. A morph also removes the menu button's ARIA attributes, which only script writes. menu.js now writes them again after every morph, so the button of a menu that stays open, and a FAB menu's close look, still say it is open, and aria-controls names the popover's new id. A second press on an open menu's button opened it again, render or not: the popover closes on the press, and the guard against the click that follows was timed from the toggle event, which is queued and arrives after that click. It is timed from beforetoggle now. Browser tests with Livewire probes in Chromium, Firefox and WebKit, and a render test for the keys and the keys of the child components after. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RHoXZSHc8gGpZjFmA5fPc2
2026-09-13 18:50:14 +02:00
parent ab7317faae
commit 8640d815c8
10 changed files with 405 additions and 21 deletions
@@ -1,5 +1,44 @@
 <?php

+use Illuminate\Support\Facades\Blade;
+use Illuminate\Support\Facades\Route;
+use Livewire\Component;
+use Livewire\Livewire;
+
+/**
+ * A Livewire component that renders again while a rich tooltip is open, from the tooltip's own
+ * action.
+ */
+class RichTooltipMorphProbe extends Component
+{
+    public int $renders = 0;
+
+    public function touch(): void
+    {
+        $this->renders++;
+    }
+
+    public function render(): string
+    {
+        return <<<'BLADE'
+            <div class="p-4">
+                <p id="outside">renders: <span id="renders">{{ $renders }}</span></p>
+
+                <x-rich-tooltip title="Expiry" text="Recipients lose access after this time." persistent>
+                    <x-button label="Details" data-test="details" />
+                    <x-slot:actions><x-button label="Refresh" wire:click="touch" data-test="refresh" /></x-slot:actions>
+                </x-rich-tooltip>
+
+                <div style="margin-top: 200px">
+                    <x-rich-tooltip text="Shown on hover.">
+                        <x-button label="Hint" data-test="hint" />
+                    </x-rich-tooltip>
+                </div>
+            </div>
+            BLADE;
+    }
+}
+
 const SNACKBAR = "document.querySelector('[x-data=\"materialSnackbar\"] [aria-live]')";

 const TOAST = "document.querySelector('[data-toast]')";
@@ -108,3 +147,46 @@ it('opens a persistent rich tooltip on press', function () {
        ->click('#communication button:has-text("Press for details")')
        ->assertScript("{$bubble}.matches(':popover-open')");
 });
+
+it('keeps a rich tooltip open while its action renders the component, and opens it again after', function () {
+    Livewire::component('rich-tooltip-morph-probe', RichTooltipMorphProbe::class);
+
+    Route::middleware('web')->get('/rich-tooltip-morph-probe', fn () => Blade::render(<<<'BLADE'
+        <!DOCTYPE html>
+        <html>
+            <head>
+                <x-theme-script />
+                @vite(config('livewire-material.showcase.vite'))
+                @livewireStyles
+            </head>
+            <body class="bg-surface">
+                <livewire:rich-tooltip-morph-probe />
+                @livewireScripts
+            </body>
+        </html>
+        BLADE));
+
+    $persistent = "document.querySelector('[role=\"dialog\"][popover]')";
+    $transient = "document.querySelector('[role=\"tooltip\"][popover]')";
+
+    $page = visit('/rich-tooltip-morph-probe')->waitForEvent('networkidle')
+        ->assertScript("document.readyState === 'complete' && typeof window.Alpine !== 'undefined' && typeof window.Livewire !== 'undefined'")
+        ->assertNoJavaScriptErrors();
+
+    $page->click('@details')
+        ->assertScript("{$persistent}.matches(':popover-open')")
+        ->click('@refresh')
+        ->assertSeeIn('#renders', '1')
+        ->assertScript("{$persistent}.matches(':popover-open')");
+
+    $page->click('#outside')
+        ->assertScript("! {$persistent}.matches(':popover-open')");
+
+    $page->click('@details')
+        ->assertScript("{$persistent}.matches(':popover-open')");
+
+    $page->click('#outside')
+        ->hover('@hint')
+        ->assertScript("{$transient}.matches(':popover-open')")
+        ->assertNoJavaScriptErrors();
+});