Land a caller's class and style on the scaffold and tooltip roots
Plan step 39 (part 0): the step 38 review found <x-scaffold> and <x-tooltip> never referencing $attributes, so a caller's class and style were silently dropped. The scaffold's root is its single data-md-scaffold div; the tooltip's root, documented in its header, is the standalone wrapper it draws around a trigger (data-md-tooltip-anchor, merged with its own anchor-name) — passed an anchor instead, it renders only a popover fragment beside another component's root and takes nothing of the caller's. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwx5USif3wFFmxtHg5U1g9
This commit is contained in:
co-authored by
Claude Sonnet 5
parent
783f7902cc
commit
cfc57a9867
@@ -101,7 +101,8 @@
|
||||
window never clips what overhangs on purpose.
|
||||
|
||||
Nothing application-specific belongs in here: an app's destinations and chrome come in through
|
||||
the props and slots. --}}
|
||||
the props and slots. The caller's `class` and `style` land on the root, `data-md-scaffold`
|
||||
itself — the element `style="--material-banner: 4rem"` above sets a custom property on. --}}
|
||||
|
||||
@props([
|
||||
'destinations' => [],
|
||||
@@ -137,7 +138,7 @@
|
||||
$groups = $items->chunkWhile(fn (array $item, int $key, $chunk): bool => $item['section'] === $chunk->last()['section']);
|
||||
@endphp
|
||||
|
||||
<div data-md-scaffold>
|
||||
<div data-md-scaffold {{ $attributes->only(['class', 'style']) }}>
|
||||
<a href="#content" data-md-skip-link>{{ __('Skip to content') }}</a>
|
||||
|
||||
@isset($banner)
|
||||
|
||||
@@ -14,7 +14,14 @@
|
||||
Drawn by resources/css/components/tooltip.css.
|
||||
|
||||
It is aria-hidden: an icon button takes the same words as its aria-label, and a labelled
|
||||
control would otherwise read them twice. --}}
|
||||
control would otherwise read them twice.
|
||||
|
||||
The caller's `class` and `style` land on the root — standalone, that is the wrapper this
|
||||
component draws around the trigger (`data-md-tooltip-anchor`), merged with its own
|
||||
`anchor-name`. Passed an `anchor` instead, the component renders no wrapper of its own: only
|
||||
the popover bubble, a fragment beside another component's root (`<x-button tooltip>` and
|
||||
friends never forward a caller's attributes to it), so there is nothing of the caller's to
|
||||
place. --}}
|
||||
|
||||
@props([
|
||||
'text',
|
||||
@@ -29,7 +36,7 @@
|
||||
@endphp
|
||||
|
||||
@if ($standalone)
|
||||
<span data-md-tooltip-anchor style="anchor-name: {{ $anchor }}">
|
||||
<span data-md-tooltip-anchor {{ $attributes->merge(['style' => "anchor-name: {$anchor}"]) }}>
|
||||
{{ $slot }}
|
||||
@endif
|
||||
|
||||
|
||||
Reference in New Issue
Block a user