Press once whatever a second press would open over or undo

The browser plugin runs every call on a page again when its first
attempt takes over a second, and on the runner a press can. For most
presses that costs nothing. For two kinds it breaks the test: a press
that opens a dialog, a sheet, a full-screen view or a modal rail over
its own trigger, whose second press can never land, and a press that
changes state a second one would change again — a menu trigger, a
toggle, a chip, a range picker's day, a paging key, a Save. The bottom
sheet with preset heights timed out on WebKit that way after the date
picker had on Firefox.

Every such press in the browser suite now goes through pressOnce(), 253
of them across sixteen files, not only the ones the runner happened to
catch; focus moves inside an open view, Escape, links and plain "set"
actions keep the retry, which is harmless for them.

Two samples that were still racing the machine:

- The standard side sheet's exit is caught half-way with its motion
  stretched, as every other mid-exit sample is, and fullSpeed() takes
  the stretch off again before the test times a reopen against the real
  exit. Under load on Linux WebKit it had failed two runs in five; it
  passes ten in ten.
- The switch-and-checkbox row measures its widths once, so it now waits
  for the resize to land and the brand face to load before it does.

Browser 300 passed on Firefox and WebKitGTK in a Linux container held to
two busy cores, and on Chrome, Firefox and WebKit on macOS. Feature 1159
passed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

tests/Browser/PickingTest.php

@@ -80,12 +80,17 @@ function pickProbe()
 }
 
 it('keeps the values of filter chips as the property\'s own type', function () {
-    pickProbe()
-        ->assertAttribute('button[aria-pressed="true"]', 'aria-pressed', 'true')
-        ->click('button:has-text("Mon")')
-        ->assertSeeIn('#days', '[2,1]')
-        ->click('button:has-text("Tue")')
-        ->assertSeeIn('#days', '[1]')
+    $page = pickProbe()
+        ->assertAttribute('button[aria-pressed="true"]', 'aria-pressed', 'true');
+
+    // A filter chip toggles on every press: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('button:has-text("Mon")');
+
+    $page->assertSeeIn('#days', '[2,1]');
+
+    pressOnce($page)->click('button:has-text("Tue")');
+
+    $page->assertSeeIn('#days', '[1]')
         ->assertScript("[...document.querySelectorAll('[aria-pressed=\"true\"]')].map((chip) => chip.textContent.trim()).join() === 'Mon'");
 });
 
@@ -93,9 +98,12 @@ it('filters a searchable choice as it is typed and chooses from the keyboard', f
     $list = "document.querySelector('#zone-field-list')";
 
     $page = pickProbe()
-        ->assertValue('#zone-field', 'Zurich')
-        ->click('#zone-field')
-        ->assertScript("{$list}.matches(':popover-open')")
+        ->assertValue('#zone-field', 'Zurich');
+
+    // Opens the searchable choice's list over the field that triggers it: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('#zone-field');
+
+    $page->assertScript("{$list}.matches(':popover-open')")
         ->assertAttribute('#zone-field', 'aria-expanded', 'true');
 
     $page->type('#zone-field', 'ber')
@@ -108,20 +116,30 @@ it('filters a searchable choice as it is typed and chooses from the keyboard', f
 });
 
 it('puts a searchable choice back on Escape and never chooses a disabled option', function () {
-    $page = pickProbe()->click('#zone-field')->type('#zone-field', 'ber');
+    $page = pickProbe();
+
+    // Opens the searchable choice's list over the field that triggers it: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('#zone-field');
+
+    $page->type('#zone-field', 'ber');
 
     $page->keys('#zone-field', 'Escape')
         ->assertValue('#zone-field', 'Zurich')
         ->assertSeeIn('#zone', 'Europe/Zurich');
 
-    $page->click('#zone-field')->type('#zone-field', 'UTC')->keys('#zone-field', 'Enter')
+    pressOnce($page)->click('#zone-field');
+
+    $page->type('#zone-field', 'UTC')->keys('#zone-field', 'Enter')
         ->assertSeeIn('#zone', 'Europe/Zurich');
 });
 
 it('opens a searchable choice\'s list above a container that clips', function () {
-    pickProbe()
-        ->click('#zone-field')
-        ->assertScript(<<<'JS'
+    $page = pickProbe();
+
+    // Opens the searchable choice's list over the field that triggers it: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('#zone-field');
+
+    $page->assertScript(<<<'JS'
             (() => {
                 const list = document.querySelector('#zone-field-list');
                 const clip = document.querySelector('#clip').getBoundingClientRect();
@@ -164,12 +182,18 @@ it('hangs a searchable choice\'s list under its field and as wide, bounded at 40
 
     $page = ready(visit('/wide-choices-probe')->resize(1280, 800), livewire: false);
 
-    $page->click('#bounded-zone')->assertScript("document.getElementById('bounded-zone-list').matches(':popover-open')");
+    // Opens the searchable choice's list over the field that triggers it: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('#bounded-zone');
+
+    $page->assertScript("document.getElementById('bounded-zone-list').matches(':popover-open')");
 
     expect($page->script($placed('bounded-zone')))->toBe([640, 640, 0]);
 
     $page->keys('#bounded-zone', 'Escape')->assertScript("! document.getElementById('bounded-zone-list').matches(':popover-open')");
-    $page->click('#full-zone')->assertScript("document.getElementById('full-zone-list').matches(':popover-open')");
+
+    pressOnce($page)->click('#full-zone');
+
+    $page->assertScript("document.getElementById('full-zone-list').matches(':popover-open')");
 
     expect($page->script($placed('full-zone')))->toBe([1168, 1168, 0]);
 });
@@ -178,9 +202,12 @@ it('opens the search view with the results Livewire renders for the query', func
     $view = "document.querySelector('#find-view')";
 
     // The combobox is the wrapper around the input, which carries `aria-expanded`.
-    $page = pickProbe()
-        ->click('#find')
-        ->assertScript("getComputedStyle({$view}).display !== 'none'")
+    $page = pickProbe();
+
+    // Opens the search view over the field that triggers it: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('#find');
+
+    $page->assertScript("getComputedStyle({$view}).display !== 'none'")
         ->assertAttribute('[role="combobox"]:has(> #find)', 'aria-expanded', 'true');
 
     $page->type('#find', 'con')
@@ -199,21 +226,29 @@ it('opens the search view with the results Livewire renders for the query', func
 it('says so when nothing matches, and closes on a press outside or a chosen result', function () {
     $view = "document.querySelector('#find-view')";
 
-    $page = pickProbe()
-        ->click('#find')
-        ->type('#find', 'zzz')
+    $page = pickProbe();
+
+    // Opens the search view over the field that triggers it: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('#find');
+
+    $page->type('#find', 'zzz')
         ->assertSeeIn('#find-view', 'No files match.');
 
-    // The docked view opens over a scrim that covers the rest of the page, so a
-    // press outside the view lands on the scrim.
-    $page->click('[data-md-search]:has(#find) [data-md-search-scrim]')
-        ->assertScript("getComputedStyle({$view}).display === 'none'");
+    // The docked view opens over a scrim that covers the rest of the page, so a press outside the
+    // view lands on the scrim, which closes the view: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('[data-md-search]:has(#find) [data-md-search-scrim]');
 
-    $page->click('#find')
-        ->clear('#find')
-        ->assertScript("{$view}.querySelectorAll('button').length === 3")
-        ->click('#find-view button:has-text("review.mp4")')
-        ->assertScript("getComputedStyle({$view}).display === 'none'");
+    $page->assertScript("getComputedStyle({$view}).display === 'none'");
+
+    pressOnce($page)->click('#find');
+
+    $page->clear('#find')
+        ->assertScript("{$view}.querySelectorAll('button').length === 3");
+
+    // Selecting a result closes the view: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('#find-view button:has-text("review.mp4")');
+
+    $page->assertScript("getComputedStyle({$view}).display === 'none'");
 });
 
 /**
@@ -242,8 +277,12 @@ function searchCloseSample(string $element, string $expression): string
 it('fades the docked search\'s scrim out on close, rather than making it vanish', function () {
     $root = "document.querySelector('[data-md-search]:has(#find)')";
 
-    $page = pickProbe()
-        ->click('#find')
+    $page = pickProbe();
+
+    // Opens the search view over the field that triggers it: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('#find');
+
+    $page
         // Displayed as well as opaque: until the first frame of its entry the scrim is still
         // `display: none` at the open state's full opacity. And settled, not still fading in: an
         // engine reads a transition's end value until its next refresh tick, so an opacity of 1
@@ -262,9 +301,12 @@ it('fades the docked search\'s scrim out on close, rather than making it vanish'
 it('keeps the docked search above the page while its view closes', function () {
     $view = "document.querySelector('#find-view')";
 
-    $page = pickProbe()
-        ->click('#find')
-        ->assertScript("getComputedStyle({$view}).display !== 'none' && getComputedStyle({$view}).opacity === '1'")
+    $page = pickProbe();
+
+    // Opens the search view over the field that triggers it: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('#find');
+
+    $page->assertScript("getComputedStyle({$view}).display !== 'none' && getComputedStyle({$view}).opacity === '1'")
         // Settled, not still fading in: see the scrim's fade above.
         ->assertScript(settled($view));
 
@@ -279,20 +321,28 @@ it('keeps the docked search above the page while its view closes', function () {
 it('takes the whole screen on a compact window, with a back arrow', function () {
     $page = pickProbe()->resize(400, 800);
 
-    $page->click('#find')
-        ->assertScript("document.querySelector('[data-md-search]').hasAttribute('data-md-full-screen')")
-        ->assertScript("(() => { const box = document.querySelector('#find-view').getBoundingClientRect(); return box.top === 0 && box.width === 400; })()")
-        ->click('[data-md-search]:has(#find) [data-md-search-back]')
-        ->assertScript("! document.querySelector('[data-md-search]').hasAttribute('data-md-open')");
+    // Opens the search view over the field that triggers it: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('#find');
+
+    $page->assertScript("document.querySelector('[data-md-search]').hasAttribute('data-md-full-screen')")
+        ->assertScript("(() => { const box = document.querySelector('#find-view').getBoundingClientRect(); return box.top === 0 && box.width === 400; })()");
+
+    // The back arrow closes the search: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('[data-md-search]:has(#find) [data-md-search-back]');
+
+    $page->assertScript("! document.querySelector('[data-md-search]').hasAttribute('data-md-open')");
 });
 
 it('says how many results there are, politely, as they change', function () {
     $status = "document.querySelector('[data-md-search]:has(#find) [data-md-search-status]')";
 
     $page = pickProbe()
-        ->assertScript("{$status}.getAttribute('aria-live') === 'polite' && {$status}.getAttribute('aria-atomic') === 'true'")
-        ->click('#find')
-        ->assertScript("{$status}.textContent === '3 results'");
+        ->assertScript("{$status}.getAttribute('aria-live') === 'polite' && {$status}.getAttribute('aria-atomic') === 'true'");
+
+    // Opens the search view over the field that triggers it: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('#find');
+
+    $page->assertScript("{$status}.textContent === '3 results'");
 
     $page->type('#find', 'con')
         ->assertSeeIn('#query', 'con')
@@ -323,8 +373,10 @@ it('expands the search icon into the full-screen view, and hands focus back to t
         ->assertScript("getComputedStyle({$root}.querySelector('[data-md-search-bar]')).display === 'none'")
         ->assertScript("{$root}.getBoundingClientRect().width === 48 && {$trigger}.getAttribute('aria-expanded') === 'false'");
 
-    $page->click('[data-md-search]:has(#find-icon) [data-md-search-trigger]')
-        ->assertScript("{$root}.hasAttribute('data-md-open') && {$root}.hasAttribute('data-md-full-screen')")
+    // Opens the search view over the trigger that expands it: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('[data-md-search]:has(#find-icon) [data-md-search-trigger]');
+
+    $page->assertScript("{$root}.hasAttribute('data-md-open') && {$root}.hasAttribute('data-md-full-screen')")
         ->assertScript("document.activeElement.id === 'find-icon'")
         ->assertScript("(() => { const view = {$root}.querySelector('[data-md-search-view]').getBoundingClientRect(); return view.top === 0 && view.left === 0 && view.width === innerWidth; })()")
         // The toolbar does not shift under the expanded search.
@@ -367,9 +419,12 @@ it('closes the full-screen view and its bar together, back into the search icon'
     $root = "document.querySelector('[data-md-search]:has(#find-icon)')";
     $trigger = "{$root}.querySelector('[data-md-search-trigger]')";
 
-    $page = pickProbe()
-        ->click('[data-md-search]:has(#find-icon) [data-md-search-trigger]')
-        ->assertScript("{$root}.hasAttribute('data-md-full-screen')")
+    $page = pickProbe();
+
+    // Opens the search view over the trigger that expands it: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('[data-md-search]:has(#find-icon) [data-md-search-trigger]');
+
+    $page->assertScript("{$root}.hasAttribute('data-md-full-screen')")
         // Its entry run: Firefox reads a transition's end value until its next refresh tick, so an
         // opacity of 1 alone does not say the view has finished fading in.
         ->assertScript(settled($root, subtree: true));
@@ -391,8 +446,10 @@ it('closes a compact window\'s full-screen view and its bar together, back into
 
     $page = pickProbe()->resize(400, 800);
 
-    $page->click('#find')
-        ->assertScript("{$root}.hasAttribute('data-md-full-screen')")
+    // Opens the search view over the field that triggers it: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('#find');
+
+    $page->assertScript("{$root}.hasAttribute('data-md-full-screen')")
         ->assertScript(settled($root, subtree: true));
 
     slowMotion($page);
@@ -410,9 +467,12 @@ it('shows the suggestions until the first key, then the results, and counts whic
     $root = "document.querySelector('[data-md-search]:has(#find-icon)')";
     $shown = fn (string $list): string => "{$root}.querySelector('[data-md-search-{$list}]').checkVisibility()";
 
-    $page = pickProbe()
-        ->click('[data-md-search]:has(#find-icon) [data-md-search-trigger]')
-        ->assertScript("({$shown('suggestions')}) && ! ({$shown('results')})")
+    $page = pickProbe();
+
+    // Opens the search view over the trigger that expands it: pressOnce(), tests/Pest.php.
+    pressOnce($page)->click('[data-md-search]:has(#find-icon) [data-md-search-trigger]');
+
+    $page->assertScript("({$shown('suggestions')}) && ! ({$shown('results')})")
         ->assertScript("{$root}.querySelector('[data-md-search-status]').textContent === '3 suggestions'");
 
     $page->type('#find-icon', 'h')