An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
94 lines
3.8 KiB
JavaScript
94 lines
3.8 KiB
JavaScript
/**
|
|
* `materialRichTooltip`: shows an `<x-rich-tooltip>`.
|
|
*
|
|
* Transient (the default): like a plain tooltip (tooltip.js) — after a short hover on a pointer
|
|
* that can hover, at once on keyboard focus (not the focus a sheet or dialog moves to it as it
|
|
* opens, layers.js), and standing for 1.5s once the pointer or the focus
|
|
* leaves, which M3 gives plain and rich tooltips alike (docs/reference/m3/
|
|
* components-actions-communication-containment.md § Tooltips). The bubble is inside the
|
|
* wrapper, so moving onto it to reach its actions, by pointer or by Tab, is no leave at all; Escape
|
|
* hides it at once. Persistent: a press on the trigger opens it as a light-dismiss popover.
|
|
*
|
|
* The trigger is pointed at the bubble with `aria-describedby`, so the explanation — the whole
|
|
* point of a rich tooltip — is read out with the control rather than never at all; a persistent
|
|
* one also says `aria-haspopup="dialog"` and whether it is open. The server cannot write any of
|
|
* it: the trigger comes from a slot, and only script knows which element in it takes the focus.
|
|
* A Livewire morph strips attributes the server did not render and gives the bubble a new id, so
|
|
* they are written again whenever the trigger is reached.
|
|
*/
|
|
import { hoverPopover, LEAVE_DELAY_MS } from './tooltip.js'
|
|
import { reopenGuard } from './util.js'
|
|
|
|
document.addEventListener('alpine:init', () => {
|
|
window.Alpine.data('materialRichTooltip', (persistent = false) => ({
|
|
stop: null,
|
|
|
|
init() {
|
|
const bubble = this.$refs.bubble
|
|
const wrapper = this.$el
|
|
const open = () => bubble.matches(':popover-open')
|
|
|
|
const control = () => [...wrapper.querySelectorAll('button, a[href], [tabindex]')].find((element) => !bubble.contains(element))
|
|
|
|
const describe = () => {
|
|
const trigger = control()
|
|
|
|
if (!trigger) {
|
|
return
|
|
}
|
|
|
|
trigger.setAttribute('aria-describedby', bubble.id)
|
|
|
|
if (persistent) {
|
|
trigger.setAttribute('aria-haspopup', 'dialog')
|
|
trigger.setAttribute('aria-expanded', String(open()))
|
|
}
|
|
}
|
|
|
|
describe()
|
|
bubble.addEventListener('toggle', describe)
|
|
wrapper.addEventListener('focusin', describe)
|
|
wrapper.addEventListener('pointerenter', describe)
|
|
|
|
if (persistent) {
|
|
// A persistent bubble is a `popover="auto"`, and its trigger is outside it: the
|
|
// press on the trigger light-dismisses the open bubble, and the click that
|
|
// follows would open it again, so a second press never closed it.
|
|
const guard = reopenGuard()
|
|
|
|
bubble.addEventListener('beforetoggle', (event) => guard.beforeToggle(event))
|
|
|
|
wrapper.addEventListener('click', (event) => {
|
|
if (bubble.contains(event.target)) {
|
|
return
|
|
}
|
|
|
|
if (open()) {
|
|
guard.closing()
|
|
bubble.hidePopover()
|
|
} else if (guard.canOpen()) {
|
|
bubble.showPopover()
|
|
}
|
|
})
|
|
|
|
return
|
|
}
|
|
|
|
const popover = hoverPopover(wrapper, {
|
|
open,
|
|
show: () => bubble.showPopover(),
|
|
hide: () => bubble.hidePopover(),
|
|
focusable: (event) => event.target.matches(':focus-visible'),
|
|
})
|
|
|
|
wrapper.addEventListener('focusout', (event) => !wrapper.contains(event.relatedTarget) && popover.hide(LEAVE_DELAY_MS), { signal: popover.signal })
|
|
|
|
this.stop = popover.destroy
|
|
},
|
|
|
|
destroy() {
|
|
this.stop?.()
|
|
},
|
|
}))
|
|
})
|