Andreas Reinhold / reiniandClaude Opus 5
247c596c3a
An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
91 lines
4.2 KiB
PHP
91 lines
4.2 KiB
PHP
{{-- One item of an `<x-carousel>`: a slide of art — an `<img>`, which fills and crops to the
|
|
item, or any element sized to fill it.
|
|
|
|
<x-carousel-item label="Lake Constance">
|
|
<img src="{{ $photo->url }}" alt="Lake Constance at dusk" />
|
|
</x-carousel-item>
|
|
|
|
`label` lays a short line of text over the bottom of the art, on a scrim, pinned to the
|
|
item's visible edge and fading out as the item narrows — Compose's carousel sample, which
|
|
fades its label chip in once the mask is wide enough to hold it. The scrim is what M3 asks
|
|
for under text on an image, and the scrim is `--md-sys-color-scrim` — black in every scheme,
|
|
theme and contrast level — so its ink is the one absolute the theme keeps, `white`; a role
|
|
(`inverse-on-surface`) is dark ink in a dark scheme and fails on the scrim there
|
|
(deliberately kept).
|
|
|
|
A focusable `group` with `aria-roledescription="slide"`, named "n of m" by the carousel
|
|
around it. M3 puts the tab stop on the item, not on the row: Tab reaches the first item, the
|
|
arrow keys move between them and Space or Enter opens the focused one
|
|
(docs/reference/m3/components-actions-communication-containment.md § Carousel →
|
|
Accessibility). It renders the shared `md-focus-ring` class (foundation/interaction.css)
|
|
rather than a hand-rolled ring — the box the class draws is the item's own whole hit area —
|
|
which resources/css/components/carousel-item.css refines to an inset ring: an outward offset
|
|
would draw under the next item, since items sit edge to edge in the row.
|
|
|
|
The item is laid out at the carousel's large size and masked: the surface inside is clipped
|
|
by `--material-carousel-inset` from both sides with M3's extra-large corner (28px,
|
|
CarouselDefaults' item shape) and moved by `--material-carousel-shift`, both written by
|
|
resources/js/carousel.js. Without script the item shows unmasked, at its `item-width`. In a
|
|
`full-screen` carousel it is none of that: the item fills the row, edge to edge, with no
|
|
corner and no mask.
|
|
|
|
In a `multi-aspect` carousel the item is as wide as its own `aspect` makes it at the row's
|
|
height, and nothing masks it: M3's uncontained multi-aspect-ratio layout is for items whose
|
|
widths "vary… ranging from a 9:16 minimum to a 16:9 maximum aspect ratio", so `aspect` is
|
|
held inside that range (`16/9`, `16:9` or a plain number; a square by default, and ignored in
|
|
every other layout, where the keylines size the items)
|
|
(docs/reference/m3/components-actions-communication-containment.md § Carousel → Variants,
|
|
Specs). Only inside `<x-carousel>`. --}}
|
|
|
|
@props([
|
|
'label' => null,
|
|
'aspect' => null,
|
|
])
|
|
|
|
{{-- The layout of the `<x-carousel>` around it: the full-screen one is a vertical row of
|
|
edge-to-edge items, which M3 gives no corner and no mask, and the multi-aspect one sizes each
|
|
item by its own aspect ratio and masks none of them. --}}
|
|
@aware([
|
|
'layout' => 'multi-browse',
|
|
])
|
|
|
|
@php
|
|
$multiAspect = $layout === 'multi-aspect';
|
|
|
|
// M3's 9:16 minimum and 16:9 maximum. `16/9`, `16:9` and `1.78` all say the same thing.
|
|
$ratio = null;
|
|
|
|
if ($multiAspect) {
|
|
$value = $aspect ?? 1;
|
|
|
|
if (is_string($value) && preg_match('/^\s*([\d.]+)\s*[\/:]\s*([\d.]+)\s*$/', $value, $parts) && (float) $parts[2] > 0) {
|
|
$value = (float) $parts[1] / (float) $parts[2];
|
|
}
|
|
|
|
$ratio = round(min(max((float) $value, 9 / 16), 16 / 9), 4);
|
|
}
|
|
@endphp
|
|
|
|
<div {{ $attributes
|
|
->class('md-focus-ring')
|
|
->merge(array_filter([
|
|
'role' => 'group',
|
|
'aria-roledescription' => __('slide'),
|
|
'aria-label' => '[material-carousel-position]',
|
|
'data-md-carousel-item' => true,
|
|
'tabindex' => '0',
|
|
'style' => $ratio === null ? null : "aspect-ratio: {$ratio}",
|
|
], fn ($value): bool => $value !== null)) }}>
|
|
<div data-md-carousel-surface>
|
|
<div data-md-carousel-content>
|
|
{{ $slot }}
|
|
</div>
|
|
|
|
@if (filled($label))
|
|
<div data-md-carousel-label>
|
|
<span data-md-carousel-label-text>{{ $label }}</span>
|
|
</div>
|
|
@endif
|
|
</div>
|
|
</div>
|