Andreas Reinhold / reiniandClaude Opus 5
247c596c3a
An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
72 lines
3.5 KiB
PHP
72 lines
3.5 KiB
PHP
<?php
|
|
|
|
use NoNameWeb\LivewireMaterial\Tests\Support\ComponentStylesheet;
|
|
|
|
it('states a notice in its state\'s container, with the state\'s icon', function () {
|
|
$html = (string) $this->blade('<x-alert title="Storage almost full" description="3.8 of 4 GB" color="warning" />');
|
|
|
|
expect($html)
|
|
->toContain('role="status"')
|
|
->toContain('data-md-alert')
|
|
->toContain('data-md-color="warning"')
|
|
->toContain('Storage almost full')
|
|
->toContain('3.8 of 4 GB')
|
|
->toContain('<svg')
|
|
// Every hue but neutral comes from the shared colour-role table (color.css, ColorTest.php);
|
|
// the alert reads its container role straight off it, info by default.
|
|
->and(ComponentStylesheet::read('alert')->declarations('[data-md-alert]'))->toMatchArray([
|
|
'background-color' => 'var(--md-container, var(--md-sys-color-info-container))',
|
|
'color' => 'var(--md-on-container, var(--md-sys-color-on-info-container))',
|
|
]);
|
|
});
|
|
|
|
it('is a status whatever its colour, and interrupts only when asked to', function () {
|
|
expect((string) $this->blade('<x-alert description="Saved." tone="success" />'))->toContain('role="status"')->toContain('data-md-color="success"')
|
|
->and((string) $this->blade('<x-alert description="Heads up." />'))->toContain('role="status"')->toContain('data-md-color="info"')
|
|
->and((string) $this->blade('<x-alert description="Broken." color="error" />'))->toContain('role="status"')
|
|
->and((string) $this->blade('<x-alert description="Broken." color="error" assertive />'))->toContain('role="alert"');
|
|
});
|
|
|
|
it('falls back to info for an unknown colour', function () {
|
|
expect((string) $this->blade('<x-alert description="Odd." color="purple" />'))->toContain('data-md-color="info"');
|
|
});
|
|
|
|
it('takes actions, drops its icon on request, and can be dismissed', function () {
|
|
$html = (string) $this->blade(<<<'BLADE'
|
|
<x-alert :icon="false" dismissible>
|
|
The connection dropped.
|
|
<x-slot:actions><x-button label="Try again" /></x-slot:actions>
|
|
</x-alert>
|
|
BLADE);
|
|
|
|
expect($html)
|
|
->toContain('The connection dropped.')
|
|
->toContain('data-md-alert-actions')
|
|
->toContain('Try again')
|
|
->toContain('x-data="{ shown: true }"')
|
|
->toContain('data-md-alert-dismiss')
|
|
->toContain('aria-label="Dismiss"')
|
|
->and(substr_count($html, '<svg'))->toBe(1);
|
|
});
|
|
|
|
it('reaches 48px from its 40px dismiss button, from the foundation\'s class, not a copy', function () {
|
|
$css = ComponentStylesheet::read('alert');
|
|
|
|
expect($css->declarations('[data-md-alert-dismiss]'))->toMatchArray([
|
|
'width' => 'var(--md-sys-measurement-space500)',
|
|
'height' => 'var(--md-sys-measurement-space500)',
|
|
])
|
|
->and($css->has('[data-md-alert-dismiss]::after'))->toBeFalse()
|
|
->and($css->has('[data-md-alert-dismiss]::before'))->toBeFalse()
|
|
->and((string) $this->blade('<x-alert description="Draft." dismissible />'))
|
|
->toMatch('/class="md-state-layer md-focus-ring md-touch-target" data-md-alert-dismiss/');
|
|
});
|
|
|
|
it('draws neutral in surface-container-high, on-surface', function () {
|
|
expect((string) $this->blade('<x-alert description="Draft." color="neutral" />'))->toContain('data-md-color="neutral"')
|
|
->and(ComponentStylesheet::read('alert')->declarations("[data-md-alert][data-md-color='neutral']"))->toBe([
|
|
'background-color' => 'var(--md-sys-color-surface-container-high)',
|
|
'color' => 'var(--md-sys-color-on-surface)',
|
|
]);
|
|
});
|