An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
110 lines
4.3 KiB
PHP
110 lines
4.3 KiB
PHP
<?php
|
|
|
|
use Livewire\Component;
|
|
use Livewire\Livewire;
|
|
|
|
it('lays every option out as a filter chip', function () {
|
|
$html = (string) $this->blade('<x-choices label="Days" hint="Pick any" :value="[2]" :options="[[\'id\' => 1, \'name\' => \'Mon\'], [\'id\' => 2, \'name\' => \'Tue\'], [\'id\' => 3, \'name\' => \'Wed\', \'disabled\' => true]]" />');
|
|
|
|
expect($html)
|
|
->toMatch('/<div\\s+data-md-choices\\s/')
|
|
->not->toContain('data-md-searchable')
|
|
->toContain('role="group"')
|
|
->toContain('Days')
|
|
->toContain('Pick any')
|
|
->toContain('x-modelable="selection"')
|
|
->toContain('x-on:click="toggle(0)"')
|
|
->toContain('x-bind:aria-pressed="selected(2).toString()"')
|
|
->and(substr_count($html, 'aria-pressed="true"'))->toBe(1)
|
|
->and(substr_count($html, 'aria-pressed="false"'))->toBe(2)
|
|
->and($html)->toContain('disabled');
|
|
});
|
|
|
|
it('entangles the selection with its Livewire property and renders it as the property says', function () {
|
|
Livewire::component('choices-probe', new class extends Component
|
|
{
|
|
/** @var list<int> */
|
|
public array $days = [1, 3];
|
|
|
|
public function render(): string
|
|
{
|
|
return '<div><x-choices wire:model.live="days" :options="[[\'id\' => 1, \'name\' => \'Mon\'], [\'id\' => 2, \'name\' => \'Tue\'], [\'id\' => 3, \'name\' => \'Wed\']]" /></div>';
|
|
}
|
|
});
|
|
|
|
$html = Livewire::test('choices-probe')->html();
|
|
|
|
expect($html)
|
|
->toContain(".entangle('days').live")
|
|
->not->toContain('x-modelable')
|
|
->and(substr_count($html, 'aria-pressed="true"'))->toBe(2);
|
|
});
|
|
|
|
it('draws a searchable combobox with a popover list', function () {
|
|
$html = (string) $this->blade('<x-choices id="zone" label="Time zone" searchable icon="public" value="Europe/Zurich" :options="[[\'id\' => \'Europe/Zurich\', \'name\' => \'Zurich\']]" />');
|
|
|
|
expect($html)
|
|
->toMatch('/<div\\s+data-md-choices\\s+data-md-searchable\\s/')
|
|
->toContain('role="combobox"')
|
|
->toContain('aria-controls="zone-list"')
|
|
->toContain('aria-expanded="false"')
|
|
->toContain('<ul')
|
|
->toContain('id="zone-list"')
|
|
->toContain('role="listbox"')
|
|
->toContain('popover="manual"')
|
|
->toMatch('/anchor-name: (--material-choices-[a-z0-9]{10})/')
|
|
->toContain('x-modelable="value"')
|
|
->toContain('data-md-field-arrow')
|
|
// WAI-ARIA's combobox keyboard, Home and End included.
|
|
->toContain('x-on:keydown.home="jump($event, false)"')
|
|
->toContain('x-on:keydown.end="jump($event, true)"')
|
|
->toContain('<li x-show="filtered.length === 0" data-md-choices-empty>Nothing matches</li>')
|
|
->toContain('data-md-field-menu')
|
|
->toContain('data-md-field-option')
|
|
->not->toContain('class=');
|
|
|
|
preg_match('/anchor-name: (--material-choices-[a-z0-9]{10})/', $html, $anchor);
|
|
|
|
expect($html)->toContain("position-anchor: {$anchor[1]}");
|
|
});
|
|
|
|
it('shows the errors for the property and its items', function () {
|
|
Livewire::component('choices-errors', new class extends Component
|
|
{
|
|
/** @var list<int> */
|
|
public array $days = [];
|
|
|
|
public ?string $zone = null;
|
|
|
|
public function mount(): void
|
|
{
|
|
$this->addError('days.0', 'Mon is not a working day.');
|
|
$this->addError('zone', 'Choose a time zone.');
|
|
}
|
|
|
|
public function render(): string
|
|
{
|
|
return <<<'BLADE'
|
|
<div>
|
|
<x-choices wire:model="days" :options="[['id' => 1, 'name' => 'Mon']]" />
|
|
<x-choices wire:model="zone" searchable :options="[['id' => 'UTC', 'name' => 'UTC']]" />
|
|
</div>
|
|
BLADE;
|
|
}
|
|
});
|
|
|
|
expect(Livewire::test('choices-errors')->html())
|
|
->toContain('Mon is not a working day.')
|
|
->toContain('Choose a time zone.')
|
|
->toContain('aria-invalid="true"');
|
|
});
|
|
|
|
it('brings the stylesheets of what it renders, and draws its empty row', function () {
|
|
$css = (string) file_get_contents(__DIR__.'/../../../resources/css/components/choices.css');
|
|
|
|
expect($css)->toContain("@import './field.css';")
|
|
->toContain("@import './chip-set.css';")
|
|
->toContain("@import './chip.css';")
|
|
->toContain('[data-md-choices-empty] {');
|
|
});
|