Andreas Reinhold / reiniandClaude Opus 5
247c596c3a
An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
38 lines
1.6 KiB
PHP
38 lines
1.6 KiB
PHP
<?php
|
|
|
|
use Illuminate\Support\Facades\Process;
|
|
|
|
/**
|
|
* PHP cannot open a woff2 without the Brotli extension, so the axes are read by Node:
|
|
* bin/check-font.mjs (fontkit) prints them as JSON. Without Node every test here is skipped, the
|
|
* way `material:scheme` reports the same missing binary instead of guessing.
|
|
*/
|
|
beforeEach(function () {
|
|
$this->node = config('livewire-material.node', 'node');
|
|
|
|
if (Process::run([$this->node, '--version'])->failed() || ! is_dir(__DIR__.'/../../node_modules/fontkit')) {
|
|
$this->markTestSkipped("Node ({$this->node}) or fontkit is missing; bin/check-font.mjs reads the woff2's axes.");
|
|
}
|
|
});
|
|
|
|
it('keeps the variable axes the typescale depends on in the packaged font', function () {
|
|
$result = Process::run([$this->node, __DIR__.'/../../bin/check-font.mjs']);
|
|
|
|
expect($result->successful())->toBeTrue($result->errorOutput());
|
|
|
|
$font = json_decode($result->output(), true, flags: JSON_THROW_ON_ERROR);
|
|
|
|
expect($font['axes'])->toHaveKeys(['wght', 'ROND'])
|
|
// font.css declares `font-weight: 400 700`; every typescale weight is inside it.
|
|
->and($font['axes']['wght'])->toMatchArray(['min' => 400, 'max' => 700])
|
|
// The axis every `type-emphasized-*` utility sets to 100; a re-subset must keep it.
|
|
->and($font['axes']['ROND'])->toMatchArray(['min' => 0, 'max' => 100]);
|
|
});
|
|
|
|
it('fails loudly when the font file cannot be opened', function () {
|
|
$result = Process::run([$this->node, __DIR__.'/../../bin/check-font.mjs', __DIR__.'/../Fixtures/no-such-font.woff2']);
|
|
|
|
expect($result->failed())->toBeTrue()
|
|
->and($result->errorOutput())->toContain('no-such-font.woff2');
|
|
});
|