Andreas Reinhold / reiniandClaude Opus 5
247c596c3a
An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
48 lines
1.9 KiB
PHP
48 lines
1.9 KiB
PHP
{{-- A group of items in an `<x-menu>`, labelled ("Sort by", "Share with"), set apart by a gap, or
|
|
both.
|
|
|
|
M3 Expressive gives a menu two ways to break its items into clusters, and they are not
|
|
interchangeable:
|
|
|
|
- `<x-menu-separator />`, a line. M3: "dividers are more subtle and are the right choice for
|
|
scrollable menus or text-field dropdowns", and "on web, use dividers to separate items".
|
|
The default answer, and the only one for a menu long enough to scroll.
|
|
- `<x-menu-group gap>`, the Expressive "Grouped" layout: no line, a gap. M3: "gaps are the
|
|
more expressive way to separate item clusters" — but "limit to one or two gaps per menu",
|
|
"don't vary gap size", and "never use gaps in a scrollable menu" (unsupported).
|
|
|
|
A gapped cluster sets its items 2px apart (SegmentedMenuTokens.SegmentedGap = 2dp) and holds
|
|
them in a box of their own, so the two ends of the cluster round the way the ends of a whole
|
|
list round and each cluster reads as one block. Clusters stand 8px apart, the same 8px a
|
|
separator keeps above and below its line, so a menu is the same height whichever it uses.
|
|
SegmentedMenuTokens' own GroupShape is 8dp where the library's list ends are 12dp; the
|
|
library's shape wins, so a cluster's ends and a list's ends match.
|
|
|
|
Drawn by resources/css/components/menu-group.css from `data-md-gap`. --}}
|
|
|
|
@props([
|
|
'label' => null,
|
|
'gap' => false,
|
|
])
|
|
|
|
@php
|
|
$attributes = $attributes->merge([
|
|
'data-md-menu-group' => true,
|
|
'data-md-gap' => $gap ? true : null,
|
|
'role' => 'group',
|
|
'aria-label' => filled($label) ? $label : null,
|
|
]);
|
|
@endphp
|
|
|
|
<div {{ $attributes }}>
|
|
@if (filled($label))
|
|
<div data-md-menu-group-label aria-hidden="true">{{ $label }}</div>
|
|
@endif
|
|
|
|
@if ($gap)
|
|
<div data-md-menu-group-items>{{ $slot }}</div>
|
|
@else
|
|
{{ $slot }}
|
|
@endif
|
|
</div>
|