An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
79 lines
4.1 KiB
PHP
79 lines
4.1 KiB
PHP
<?php
|
|
|
|
it('draws a content region with a body and no app bar when it has no title', function () {
|
|
$html = (string) $this->blade('<x-pane>The page</x-pane>');
|
|
|
|
expect(layoutRoot($html))->toMatchArray(['<' => 'div', 'data-md-pane' => 'data-md-pane'])
|
|
->not->toHaveKeys(['data-md-width', 'data-md-hide-below', 'data-md-hide-from'])
|
|
->and($html)->toMatch('/<div data-md-pane-body>The page<\/div>/')
|
|
->not->toContain('data-md-app-bar')
|
|
->not->toContain('data-md-pane-navigation');
|
|
});
|
|
|
|
it('gives the pane its own app bar, a direct child spanning it, with the title, subtitle and actions', function () {
|
|
$html = (string) $this->blade(<<<'BLADE'
|
|
<x-pane title="Settings" subtitle="Your account" heading="h2">
|
|
<x-slot:actions><span>ACTIONS</span></x-slot:actions>
|
|
BODY
|
|
</x-pane>
|
|
BLADE);
|
|
|
|
expect($html)
|
|
->toMatch('/^\s*<div data-md-pane[^>]*>\s*<header\b[^>]*data-md-app-bar[^>]*data-md-pane-bar/s')
|
|
->toContain('<h2 data-md-app-bar-title>Settings</h2>')
|
|
->toContain('<p data-md-app-bar-subtitle>Your account</p>')
|
|
->toMatch('/<div data-md-app-bar-trailing><span>ACTIONS<\/span><\/div>/')
|
|
->toContain('data-md-sticky')
|
|
->toMatch('/<\/header>\s*<div data-md-pane-body>\s*BODY\s*<\/div>/s')
|
|
->and((string) $this->blade('<x-pane title="Settings" :sticky="false" />'))->not->toContain('data-md-sticky');
|
|
});
|
|
|
|
it('draws a bar for actions alone, and names the heading h1 by default', function () {
|
|
expect((string) $this->blade('<x-pane><x-slot:actions><span>ACTIONS</span></x-slot:actions></x-pane>'))->toContain('data-md-pane-bar')
|
|
->and((string) $this->blade('<x-pane title="Inbox" />'))->toContain('<h1 data-md-app-bar-title>Inbox</h1>');
|
|
});
|
|
|
|
it('puts the section navigation under the bar and above the body', function () {
|
|
$html = (string) $this->blade(<<<'BLADE'
|
|
<x-pane title="Settings">
|
|
<x-slot:navigation><nav>SECTIONS</nav></x-slot:navigation>
|
|
BODY
|
|
</x-pane>
|
|
BLADE);
|
|
|
|
expect($html)->toMatch('/<\/header>\s*<div data-md-pane-navigation><nav>SECTIONS<\/nav><\/div>\s*<div data-md-pane-body>\s*BODY/s')
|
|
// It is the pane's section navigation, not the bar's leading button.
|
|
->not->toContain('data-md-app-bar-leading');
|
|
});
|
|
|
|
it('leads the bar with a back link, a back action for a list-detail, or the leading slot', function () {
|
|
$link = (string) $this->blade('<x-pane title="Recipients" back="/shares" />');
|
|
$action = (string) $this->blade('<x-pane title="Message" back />');
|
|
$leading = (string) $this->blade('<x-pane title="Inbox" back><x-slot:leading><button>MENU</button></x-slot:leading></x-pane>');
|
|
|
|
expect($link)->toMatch('/data-md-app-bar-leading><span data-md-pane-back\s*>/')
|
|
->toMatch('/<a[^>]*href="\/shares"[^>]*aria-label="Back"/s')
|
|
->not->toContain('data-md-list-detail-back')
|
|
->and($action)->toMatch('/<span data-md-pane-back\s+data-md-list-detail-back\s*>/')
|
|
->toMatch('/<button[^>]*aria-label="Back"[^>]*x-on:click="back\(\)"/s')
|
|
->and($leading)->toContain('<div data-md-app-bar-leading><button>MENU</button></div>')
|
|
->not->toContain('data-md-pane-back');
|
|
});
|
|
|
|
it('caps its width with M3\'s narrow measure or the wider steps', function () {
|
|
foreach (['full', 'narrow', 'medium', 'wide'] as $width) {
|
|
expect(layoutRoot((string) $this->blade('<x-pane :width="$width" />', ['width' => $width]))['data-md-width'])->toBe($width);
|
|
}
|
|
|
|
expect(layoutRoot((string) $this->blade('<x-pane width="40rem" />')))->not->toHaveKey('data-md-width');
|
|
});
|
|
|
|
it('keeps M3\'s margin on the body, once', function () {
|
|
$css = (string) file_get_contents(__DIR__.'/../../../resources/css/layout/pane.css');
|
|
|
|
expect($css)->toContain('padding-inline: var(--md-layout-margin, var(--md-sys-measurement-space200));')
|
|
->toContain("@media (width >= 600px) {\n padding-inline: var(--md-layout-margin, var(--md-sys-measurement-space300));")
|
|
->toContain("[data-md-pane-body] > * {\n --md-layout-margin: 0px;")
|
|
->toContain("[data-md-pane][data-md-width='narrow'] {\n max-inline-size: 40rem;");
|
|
});
|