An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
122 lines
5.5 KiB
PHP
122 lines
5.5 KiB
PHP
<?php
|
|
|
|
it('draws a search bar whose combobox controls the view', function () {
|
|
$html = (string) $this->blade('<x-search id="find" placeholder="Search shares" wire:model.live.debounce.300ms="query" />');
|
|
|
|
expect($html)
|
|
->toContain('data-md-search')
|
|
->toContain('data-md-trigger="bar"')
|
|
->toContain('x-bind:data-md-open="open ? \'\' : null"')
|
|
->toContain('x-bind:data-md-full-screen="fullScreen ? \'\' : null"')
|
|
->toContain('role="search"')
|
|
->toContain('type="search"')
|
|
->toContain('placeholder="Search shares"')
|
|
->toContain('aria-label="Search shares"')
|
|
->toContain('role="combobox"')
|
|
->toContain('aria-haspopup="dialog"')
|
|
->toContain('aria-controls="find-view"')
|
|
->toContain('aria-expanded="false"')
|
|
->toContain('wire:model.live.debounce.300ms="query"')
|
|
->toContain('id="find-view"')
|
|
->toContain('data-md-search-clear')
|
|
->toContain('data-md-search-scrim')
|
|
->toContain('aria-label="Back"')
|
|
->toContain('materialSearch(false,')
|
|
->not->toContain('data-md-search-results')
|
|
// Split so the string never reads as a literal class="..." attribute to the design guard's
|
|
// own scan of this file — Tailwind's `relative` utility, which the field used to carry.
|
|
->not->toContain('class="'.'relative"');
|
|
|
|
// The state belongs to the combobox, never to the bare textbox ARIA gives it to.
|
|
expect($html)->toMatch('/<span\s+data-md-search-field[^>]*aria-expanded/s');
|
|
expect($html)->not->toMatch('/<input[^>]*aria-expanded/s');
|
|
});
|
|
|
|
it('announces how many results there are, politely', function () {
|
|
$html = (string) $this->blade('<x-search />');
|
|
|
|
expect($html)
|
|
->toContain('data-md-search-status class="md-visually-hidden"')
|
|
->toContain('aria-live="polite"')
|
|
->toContain('aria-atomic="true"')
|
|
->toContain('No results')
|
|
->toContain('1 result')
|
|
->toContain(':count results');
|
|
});
|
|
|
|
it('shows the results as a list, or what to say when there are none', function () {
|
|
expect((string) $this->blade('<x-search><a href="/shares/1">holiday.zip</a></x-search>'))
|
|
->toContain('data-md-search-results role="list"')
|
|
->toContain('<a href="/shares/1">holiday.zip</a>')
|
|
->and((string) $this->blade('<x-search><x-slot:empty>No shares match.</x-slot:empty></x-search>'))
|
|
->toContain('<p data-md-search-empty>No shares match.</p>')
|
|
->not->toContain('data-md-search-results role="list"');
|
|
});
|
|
|
|
it('offers M3\'s search-icon entry point', function () {
|
|
$html = (string) $this->blade('<x-search id="find" trigger="icon" label="Search shares" />');
|
|
|
|
expect($html)
|
|
->toContain('data-md-trigger="icon"')
|
|
->toContain('data-md-search-trigger')
|
|
->toContain('x-ref="trigger"')
|
|
->toContain('x-on:click="expand()"')
|
|
->toContain('aria-label="Search shares"')
|
|
->toContain('aria-haspopup="dialog"')
|
|
->toContain('aria-controls="find-view"')
|
|
->toContain('materialSearch(false,')
|
|
->toContain("'icon'")
|
|
// The bar is still there: it becomes the expanded view's header.
|
|
->toContain('data-md-search-bar');
|
|
|
|
expect((string) $this->blade('<x-search />'))
|
|
->toContain('data-md-trigger="bar"')
|
|
->not->toContain('data-md-search-trigger');
|
|
});
|
|
|
|
it('shows suggestions until the first keystroke, then the results', function () {
|
|
$html = (string) $this->blade(<<<'BLADE'
|
|
<x-search>
|
|
<a href="/shares/1">holiday.zip</a>
|
|
<x-slot:suggestions><a href="/recent">Recent shares</a></x-slot:suggestions>
|
|
</x-search>
|
|
BLADE);
|
|
|
|
expect($html)
|
|
->toContain('data-md-search-suggestions role="list"')
|
|
->toContain('x-show="query === \'\'"')
|
|
->toContain('Recent shares')
|
|
->toContain('x-show="query !== \'\'"')
|
|
->toContain('holiday.zip')
|
|
->toContain('1 suggestion')
|
|
->toContain(':count suggestions');
|
|
|
|
// Without the slot the results stand alone and are never hidden.
|
|
expect((string) $this->blade('<x-search><a href="/shares/1">holiday.zip</a></x-search>'))
|
|
->not->toContain('data-md-search-suggestions')
|
|
->not->toContain('x-show="query !== \'\'"');
|
|
});
|
|
|
|
it('names the input, trails the bar, and stays docked on request', function () {
|
|
$html = (string) $this->blade('<x-search label="Search your shares" icon="travel_explore" docked><x-slot:trailing><button>AR</button></x-slot:trailing></x-search>');
|
|
|
|
expect($html)
|
|
->toContain('placeholder="Search"')
|
|
->toContain('aria-label="Search your shares"')
|
|
->toContain('data-md-search-trailing')
|
|
->toContain('<button>AR</button>')
|
|
->toContain('materialSearch(true,');
|
|
});
|
|
|
|
it('draws the bar and the view from its stylesheet, at M3\'s widths', function () {
|
|
$css = (string) file_get_contents(__DIR__.'/../../../resources/css/components/search.css');
|
|
|
|
expect($css)->toContain('@layer material.components')
|
|
->toMatch('/\\[data-md-search\\] \\{\\s*--search-height: 56px;[^}]*--search-open-width: 720px;/')
|
|
->toContain('[data-md-search][data-md-full-screen] [data-md-search-view] {')
|
|
->toContain("[data-md-search][data-md-trigger='icon']:not([data-md-open], [data-md-full-screen]) [data-md-search-bar] {")
|
|
// Leaving full screen, the header bar fades with the view instead of going on the first frame.
|
|
->toContain('[data-md-search][data-md-full-screen]:not([data-md-open]) [data-md-search-bar] {')
|
|
->not->toMatch('/\\d(?:\\.\\d+)?rem/');
|
|
});
|