Andreas Reinhold / reiniandClaude Opus 5
247c596c3a
An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
64 lines
2.8 KiB
PHP
64 lines
2.8 KiB
PHP
<?php
|
|
|
|
use Illuminate\Support\Collection;
|
|
use Illuminate\Support\Facades\Blade;
|
|
use Illuminate\Support\Facades\File;
|
|
use Illuminate\Support\ServiceProvider;
|
|
use NoNameWeb\LivewireMaterial\LivewireMaterialServiceProvider;
|
|
|
|
/**
|
|
* The anonymous component paths Blade holds for this package's components.
|
|
*
|
|
* @return Collection<int, array{path: string, prefix: ?string, prefixHash: string}>
|
|
*/
|
|
function packageComponentPaths(): Collection
|
|
{
|
|
$components = realpath(__DIR__.'/../../resources/views/components');
|
|
|
|
return collect(Blade::getAnonymousComponentPaths())
|
|
->filter(fn (array $entry): bool => realpath($entry['path']) === $components)
|
|
->values();
|
|
}
|
|
|
|
it('registers the components under its own name when no prefix is configured', function () {
|
|
expect(packageComponentPaths())->toHaveCount(1)
|
|
->and(packageComponentPaths()->first()['prefix'])->toBe('livewire-material')
|
|
->and(Blade::render('<x-badge value="New" tonal />'))->toContain('New');
|
|
});
|
|
|
|
it('compiles an unprefixed component to the same view on every machine', function () {
|
|
$compiled = Blade::compileString('<x-input label="Name" />');
|
|
|
|
expect($compiled)->toContain("'view' => '".hash('xxh128', 'livewire-material')."::input'")
|
|
->not->toContain(hash('xxh128', LivewireMaterialServiceProvider::componentPath()));
|
|
});
|
|
|
|
it('registers the components under a configured prefix', function () {
|
|
config(['livewire-material.prefix' => 'm']);
|
|
|
|
$provider = app()->getProvider(LivewireMaterialServiceProvider::class);
|
|
(fn () => $this->registerComponents())->call($provider);
|
|
|
|
expect(packageComponentPaths()->last()['prefix'])->toBe('m');
|
|
});
|
|
|
|
it('keeps blade-icons from registering an <x-icon> that would shadow ours', function () {
|
|
expect(Blade::getClassComponentAliases())->not->toHaveKey('icon');
|
|
});
|
|
|
|
it('publishes the error pages into the application\'s errors folder', function () {
|
|
expect(ServiceProvider::pathsToPublish(LivewireMaterialServiceProvider::class, 'livewire-material-errors'))->toBe([
|
|
LivewireMaterialServiceProvider::errorViewPath().'/errors' => resource_path('views/errors'),
|
|
]);
|
|
});
|
|
|
|
it('publishes the mail components where Laravel looks for them', function () {
|
|
expect(ServiceProvider::pathsToPublish(LivewireMaterialServiceProvider::class, 'livewire-material-mail'))->toBe([
|
|
LivewireMaterialServiceProvider::mailComponentPath().'/html' => resource_path('views/vendor/mail/html'),
|
|
LivewireMaterialServiceProvider::mailComponentPath().'/text' => resource_path('views/vendor/mail/text'),
|
|
])->and(config('mail.markdown.paths'))->toContain(resource_path('views/vendor/mail'));
|
|
|
|
expect(File::files(LivewireMaterialServiceProvider::mailComponentPath().'/html'))->not->toBeEmpty()
|
|
->and(File::files(LivewireMaterialServiceProvider::mailComponentPath().'/text'))->not->toBeEmpty();
|
|
});
|