Andreas Reinhold / reiniandClaude Opus 5
247c596c3a
An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
76 lines
3.1 KiB
CSS
76 lines
3.1 KiB
CSS
/*
|
|
* <x-section-nav>: the navigation inside one area of an application — M3's secondary tabs from
|
|
* `medium` (600px), five or more of them the scrollable tab bar M3's own accessibility page
|
|
* blesses rather than a grid that would break the tab bar's divider and strand the upper rows'
|
|
* indicators against nothing; below `medium`, where a row of them never fits, a button naming the
|
|
* current section opens the same list as a menu.
|
|
*
|
|
* [data-md-section-nav] min-inline-size: 0
|
|
* [data-md-section-nav-picker] hidden from medium
|
|
* [data-md-section-nav-trigger] 48px, an outlined field-like button
|
|
* [data-md-section-nav-trigger-label] the current section's title, truncated
|
|
* nav hidden below medium
|
|
* [data-md-tabs-bar] tabs.css, reused whole
|
|
*
|
|
* Reuses `<x-tabs>`'s own hooks and stylesheet rather than a tab bar of its own: a link marked
|
|
* `aria-current="page"` takes the same active indicator and colour tabs.css already draws for
|
|
* `aria-selected="true"`, so nothing here repeats a rule tabs.css owns; the only addition is
|
|
* this bar's own list items — flex rows, so tabs.css's `li > [data-md-tab]` share of the width
|
|
* applies, and `min-inline-size: 0`, so a long title in a fixed row wraps to its second line and
|
|
* truncates there (tabs.css, M3's "may wrap to a max second line if needed with truncation")
|
|
* instead of widening its item — which `<x-tabs>`'s buttons, direct children of the bar, never
|
|
* need. Its tabs render `<x-tabs>`'s label anatomy (`data-md-tab-label` around
|
|
* `data-md-tab-text`), so that rule draws both. The picker's trigger is not one of M3's controls
|
|
* — an outlined field-like button naming the current section, 48px tall to meet the target M3 asks
|
|
* for everywhere, in body-large type (a text class on the view, `md-type-body-lg
|
|
* md-ink md-text-start`, since it is prose on a plain button rather than a component's own type).
|
|
*/
|
|
|
|
@layer material.reset, material.tokens, material.base, material.layout, material.components, material.text, material.visibility;
|
|
|
|
@import './tabs.css';
|
|
@import './icon.css';
|
|
@import './menu.css';
|
|
@import './menu-item.css';
|
|
@import './badge.css';
|
|
|
|
@layer material.components {
|
|
[data-md-section-nav] {
|
|
min-inline-size: 0;
|
|
}
|
|
|
|
[data-md-section-nav-picker] {
|
|
@media (width >= 600px) {
|
|
display: none;
|
|
}
|
|
}
|
|
|
|
[data-md-section-nav] > nav {
|
|
@media (width < 600px) {
|
|
display: none;
|
|
}
|
|
}
|
|
|
|
[data-md-section-nav-trigger] {
|
|
display: flex;
|
|
align-items: center;
|
|
gap: 12px;
|
|
block-size: var(--md-sys-measurement-space600);
|
|
inline-size: min(320px, calc(100vw - 32px));
|
|
cursor: pointer;
|
|
border: 1px solid var(--md-sys-color-outline);
|
|
border-radius: var(--md-sys-shape-corner-xs);
|
|
padding-inline: var(--md-sys-measurement-space200);
|
|
}
|
|
|
|
[data-md-section-nav-trigger-label] {
|
|
min-inline-size: 0;
|
|
flex: 1 1 0%;
|
|
}
|
|
|
|
[data-md-section-nav] [data-md-tabs-bar] > li {
|
|
display: flex;
|
|
min-inline-size: 0;
|
|
}
|
|
}
|