Andreas Reinhold / reiniandClaude Opus 5
247c596c3a
An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
86 lines
3.0 KiB
JavaScript
86 lines
3.0 KiB
JavaScript
/**
|
|
* What the form controls need from script, which is little: both are kept off Alpine so they work
|
|
* in any markup and before Alpine starts.
|
|
*
|
|
* `<x-textarea>` grows with its text. CSS does that where the browser can size a field to its
|
|
* content (`field-sizing: content`, components/field.css); elsewhere the height is set here from
|
|
* the scroll height, on every input and whenever a Livewire render or navigation puts a new value
|
|
* in.
|
|
*
|
|
* `<x-checkbox indeterminate>`: HTML has no attribute for a checkbox's mixed state, only the
|
|
* `indeterminate` property, so the component marks the input `data-md-indeterminate` and this keeps
|
|
* the property in step with the mark — when the page loads, and when a render adds or removes the
|
|
* mark. A person pressing the box clears the property as the browser always does; the mark stays
|
|
* until the server decides again.
|
|
*/
|
|
const GROWING = 'textarea[data-md-autogrow]'
|
|
const MIXED = 'input[type="checkbox"][data-md-indeterminate]'
|
|
|
|
const growsByItself = window.CSS?.supports?.('field-sizing', 'content') ?? false
|
|
|
|
function grow(textarea) {
|
|
textarea.style.height = 'auto'
|
|
textarea.style.height = `${textarea.scrollHeight + textarea.offsetHeight - textarea.clientHeight}px`
|
|
}
|
|
|
|
/** `root` itself, if it matches `selector`, together with its matching descendants. */
|
|
function matching(root, selector) {
|
|
const descendants = [...root.querySelectorAll(selector)]
|
|
|
|
return root instanceof Element && root.matches(selector) ? [root, ...descendants] : descendants
|
|
}
|
|
|
|
function growAll(root) {
|
|
if (! growsByItself) {
|
|
matching(root, GROWING).forEach(grow)
|
|
}
|
|
}
|
|
|
|
function markAll(root) {
|
|
matching(root, MIXED).forEach((input) => (input.indeterminate = true))
|
|
}
|
|
|
|
if (! growsByItself) {
|
|
document.addEventListener('input', (event) => {
|
|
if (event.target instanceof HTMLTextAreaElement && event.target.matches(GROWING)) {
|
|
grow(event.target)
|
|
}
|
|
})
|
|
|
|
document.addEventListener('livewire:init', () => {
|
|
// A render that only puts a new value in a textarea changes no attribute or node.
|
|
window.Livewire.hook('morphed', ({ el }) => growAll(el))
|
|
})
|
|
}
|
|
|
|
new MutationObserver((records) => {
|
|
for (const record of records) {
|
|
if (record.type === 'attributes') {
|
|
if (record.attributeName === 'data-md-indeterminate' && record.target instanceof HTMLInputElement) {
|
|
record.target.indeterminate = record.target.hasAttribute('data-md-indeterminate')
|
|
} else if (! growsByItself && record.target.matches(GROWING)) {
|
|
grow(record.target)
|
|
}
|
|
|
|
continue
|
|
}
|
|
|
|
for (const node of record.addedNodes) {
|
|
if (node.nodeType !== Node.ELEMENT_NODE) {
|
|
continue
|
|
}
|
|
|
|
markAll(node)
|
|
growAll(node)
|
|
}
|
|
}
|
|
}).observe(document.documentElement, {
|
|
subtree: true,
|
|
childList: true,
|
|
attributes: true,
|
|
attributeFilter: ['data-md-indeterminate', 'data-md-autogrow'],
|
|
})
|
|
|
|
markAll(document)
|
|
growAll(document)
|