An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
101 lines
3.8 KiB
JavaScript
101 lines
3.8 KiB
JavaScript
/**
|
|
* `materialTooltip`: shows an `<x-tooltip>` popover for the control it belongs to.
|
|
*
|
|
* The trigger is the popover's parent element (the button, or the standalone wrapper). Hover
|
|
* counts only for a pointer that can hover, after a short delay so a pointer passing over a
|
|
* toolbar does not flash every label; keyboard focus shows it at once — but not the focus a sheet,
|
|
* a dialog or the modal rail moves to its first control as it opens (layers.js), which would put
|
|
* a tooltip over a sheet's close button the moment the sheet appears. A press and Escape hide it
|
|
* at once; leaving and blur let it stand for M3's 1.5s, so the words can still be read while the
|
|
* pointer moves on. Only one tooltip is up at a time: showing one takes the last one down, which
|
|
* the browser will not do for us because these are `popover="manual"`.
|
|
*/
|
|
import { openingFocus } from './layers.js'
|
|
|
|
const HOVER_DELAY_MS = 500
|
|
export const LEAVE_DELAY_MS = 1500
|
|
|
|
let visible = null
|
|
|
|
/**
|
|
* The hover/focus/Escape timing a tooltip and a transient rich tooltip (rich-tooltip.js) share:
|
|
* shows after HOVER_DELAY_MS on a pointer that can hover, at once on a focus `focusable` accepts
|
|
* (never the focus layers.js moves as a sheet or dialog opens), hides after LEAVE_DELAY_MS once
|
|
* the pointer leaves, and at once on Escape. `open`, `show` and `hide` do the actual popover call;
|
|
* a caller adds its own extra listeners (a press, a blur) on the returned `signal`, and calls
|
|
* `hide` from them.
|
|
*/
|
|
export function hoverPopover(el, { open, show, hide, focusable }) {
|
|
const controller = new AbortController()
|
|
const { signal } = controller
|
|
let timer = null
|
|
|
|
const delayed = (action, delay) => {
|
|
clearTimeout(timer)
|
|
timer = setTimeout(action, delay)
|
|
}
|
|
|
|
const showLater = (delay) => delayed(() => !open() && show(), delay)
|
|
const hideLater = (delay = 0) => delayed(() => open() && hide(), delay)
|
|
|
|
el.addEventListener('pointerenter', (event) => event.pointerType === 'mouse' && showLater(HOVER_DELAY_MS), { signal })
|
|
el.addEventListener('pointerleave', () => hideLater(LEAVE_DELAY_MS), { signal })
|
|
el.addEventListener('focusin', (event) => !openingFocus(event) && focusable(event) && showLater(0), { signal })
|
|
document.addEventListener('keydown', (event) => event.key === 'Escape' && hideLater(), { signal })
|
|
|
|
return {
|
|
hide: hideLater,
|
|
signal,
|
|
destroy() {
|
|
clearTimeout(timer)
|
|
controller.abort()
|
|
},
|
|
}
|
|
}
|
|
|
|
document.addEventListener('alpine:init', () => {
|
|
window.Alpine.data('materialTooltip', () => ({
|
|
popover: null,
|
|
|
|
init() {
|
|
const tip = this.$el
|
|
const trigger = tip.parentElement
|
|
|
|
const popover = (this.popover = hoverPopover(trigger, {
|
|
open: () => tip.matches(':popover-open'),
|
|
show: () => {
|
|
if (!tip.isConnected) {
|
|
return
|
|
}
|
|
|
|
if (visible && visible !== tip && visible.matches(':popover-open')) {
|
|
visible.hidePopover()
|
|
}
|
|
|
|
visible = tip
|
|
tip.showPopover()
|
|
},
|
|
hide: () => {
|
|
tip.hidePopover()
|
|
|
|
if (visible === tip) {
|
|
visible = null
|
|
}
|
|
},
|
|
focusable: () => trigger.matches(':focus-within:has(:focus-visible), :focus-visible'),
|
|
}))
|
|
|
|
trigger.addEventListener('pointerdown', () => popover.hide(), { signal: popover.signal })
|
|
trigger.addEventListener('focusout', () => popover.hide(LEAVE_DELAY_MS), { signal: popover.signal })
|
|
},
|
|
|
|
destroy() {
|
|
this.popover.destroy()
|
|
|
|
if (visible === this.$el) {
|
|
visible = null
|
|
}
|
|
},
|
|
}))
|
|
})
|