Files
SealShare/tests/Feature/ShareCreatedTest.php
T
surtic86andClaude Opus 5.5 84c8b81f0a Fix the security audit's findings
Fixes the nine findings of security audit run 1 on 2.4.1 (T1-T11).

F1: Uploads that are not complete now count only the bytes the server
received, and a chunk that goes above the storage quota gets 422. An
anonymous uploader can no longer fill the quota with declared sizes.

F2: The share password and the admin login have a second limit without
the address (20 attempts per minute per share and per e-mail), because
a forged X-Forwarded-For changes the address.

F3: The system password gate and the admin check now also run on
Livewire updates, so an old uploader snapshot cannot register files.

F4: The session keeps a fingerprint of the system password's hash.
When the admin changes the system password, earlier verifications end.

F5: The page after the upload opens only in the session that created
the share, and only while recipients can still reach the share.

F6: The share password limit counts an attempt before the password is
checked, so parallel attempts cannot pass it.

F7: The system password has the same two limits (5 per address, 20 in
total per minute).

F8: A password change or reset signs the user's other sessions out.

F9: The only admin cannot delete the account, which would open /setup
to every visitor.

The setup wizard also holds the admin password to the password
defaults, and Livewire applies EnsureAdmin to updates.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 14:46:38 +02:00

106 lines
4.4 KiB
PHP

<?php
use App\Models\Share;
use App\Services\QrCodeService;
use App\Services\ShareService;
use Illuminate\Http\UploadedFile;
use Illuminate\Support\Facades\Crypt;
use Illuminate\Support\Facades\Storage;
test('the share created page offers the link as a QR code and through the share sheet', function () {
$share = Share::factory()->create();
$url = route('share.download', $share);
$svg = app(QrCodeService::class)->svg($url);
$response = $this->withSession(['created_shares' => [$share->token]])->get(route('share.created', $share));
$response->assertOk()
->assertSee($url, false)
->assertSee('data-test="show-qr-code"', false)
->assertSee('data-test="share-sheet"', false)
->assertSee('share-'.$share->token.'.png')
->assertDontSee('Recipients also need the password.');
// Structure, not the 1.x class string: the `data-qr-code` hook directly wraps the service's own
// SVG, which draws its own white field and quiet zone — no colour class or literal colour here.
expect($response->getContent())
->toMatch('#<div[^>]*\bdata-qr-code\b[^>]*>'.preg_quote($svg, '#').'</div>#');
});
test('the QR code dialog reminds that a protected share also needs its password', function () {
$share = Share::factory()->withPassword()->create();
$this->withSession(['created_shares' => [$share->token]])
->get(route('share.created', $share))
->assertOk()
->assertSee('Recipients also need the password.');
});
test('the uploader who just set the password can copy it beside the link, without it being on screen', function () {
$share = Share::factory()->withPassword()->create();
$response = $this->withSession([
'created_shares' => [$share->token],
'share_password' => ['token' => $share->token, 'password' => Crypt::encryptString('violet-orbit-canyon')],
])
->get(route('share.created', $share));
$response->assertSee('data-test="share-password"', false)
->assertSee('Available only this once. Send it separately from the link.');
// A masked field holding the password, with the field's copy button at its end.
expect($response->getContent())
->toMatch('#<input(?=[^>]*value="violet-orbit-canyon")(?=[^>]*type="password")(?=[^>]*data-test="share-password")[^>]*>#')
->toMatch('#data-test="share-password".*?data-md-field-copy#s');
});
test('the password is not shown without a flash for this share', function (?string $flashedFor) {
$share = Share::factory()->withPassword()->create();
$session = ['created_shares' => [$share->token]];
if ($flashedFor !== null) {
$session['share_password'] = ['token' => $flashedFor, 'password' => Crypt::encryptString('violet-orbit-canyon')];
}
$response = $this->withSession($session)->get(route('share.created', $share));
$response->assertOk()
->assertDontSee('data-test="share-password"', false)
->assertDontSee('violet-orbit-canyon');
})->with([
'no flash (a reload or another visitor)' => [null],
'a flash for another share' => ['another-share-token'],
]);
test('the Private text stat shows for a share with text, and the Files stat excludes it', function () {
Storage::fake('shares');
$share = app(ShareService::class)->createShare(
[
['file' => UploadedFile::fake()->createWithContent('one.txt', 'one'), 'relativePath' => null],
['file' => UploadedFile::fake()->createWithContent('two.txt', 'two'), 'relativePath' => null],
],
[],
'the secret note',
);
$response = $this->withSession(['created_shares' => [$share->token]])->get(route('share.created', $share));
$response->assertOk()
->assertSeeInOrder(['Files', '2', 'Private text']);
});
test('the share created page is not found for a session that did not create the share', function () {
$share = Share::factory()->withPassword()->create();
$this->get(route('share.created', $share))->assertNotFound();
});
test('the share created page is not found once the share is no longer reachable', function (Share $share) {
$this->withSession(['created_shares' => [$share->token]])
->get(route('share.created', $share))
->assertNotFound();
})->with([
'expired' => fn () => Share::factory()->expired()->create(),
'at its download limit' => fn () => Share::factory()->withMaxDownloads(1)->create(['download_count' => 1]),
]);