Measure the time picker's dial after its dialog has finished opening
tests / feature (8.4) (push) Successful in 1m51s
tests / feature (8.5) (push) Successful in 1m57s
tests / browser (chrome, chromium) (push) Successful in 7m45s
tests / browser (firefox, firefox) (push) Failing after 12m42s
tests / browser (safari, webkit) (push) Failing after 13m15s
tests / feature (8.4) (push) Successful in 1m51s
tests / feature (8.5) (push) Successful in 1m57s
tests / browser (chrome, chromium) (push) Successful in 7m45s
tests / browser (firefox, firefox) (push) Failing after 12m42s
tests / browser (safari, webkit) (push) Failing after 13m15s
The test that holds the dial to its pixel size at a 20px root font size read the dial's width straight after the click, so on a loaded machine it caught the dialog mid-entry: scale 0.95 of 256px rounds to 243, a number the stylesheet never sets. The assertion then compared the settled dial against that, and failed for the whole retry window. It now waits for the dialog's own animations to finish before taking the resting width, the way the sheet tests already wait. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
fb7007c976
commit
145f60aa11
@@ -408,6 +408,10 @@ it('keeps the dial and the boxes their fixed pixel size at a 20px root font size
|
||||
|
||||
$page = timeProbe()->click('#meeting');
|
||||
|
||||
// After the dialog's entry, not during it: mid-scale the dial measures 0.95 of its own size,
|
||||
// which would make the resting width this test compares against a number the CSS never sets.
|
||||
$page->assertScript("document.querySelector('#meeting-dialog').getAnimations({ subtree: true }).length === 0");
|
||||
|
||||
$restingWidth = (int) $page->script($dialWidth);
|
||||
$restingFont = $page->script($font);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user