Andreas Reinhold / reiniandClaude Opus 5
247c596c3a
An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
61 lines
3.8 KiB
PHP
61 lines
3.8 KiB
PHP
<?php
|
|
|
|
it('draws the focus pane first and the supporting pane after it, fixed and below by default', function () {
|
|
$html = (string) $this->blade(<<<'BLADE'
|
|
<x-supporting-pane>
|
|
<x-slot:main><article>MAIN</article></x-slot:main>
|
|
<x-slot:supporting><ul>SUPPORTING</ul></x-slot:supporting>
|
|
</x-supporting-pane>
|
|
BLADE);
|
|
|
|
expect(layoutRoot($html))->toMatchArray([
|
|
'<' => 'div',
|
|
'data-md-supporting-pane' => 'data-md-supporting-pane',
|
|
'data-md-width' => 'fixed',
|
|
'data-md-compact' => 'below',
|
|
])
|
|
->and($html)->toMatch('/<div data-md-supporting-pane-main><article>MAIN<\/article><\/div>\s*<aside\s+data-md-supporting-pane-supporting\s*>\s*<div data-md-supporting-pane-body id="[^"]+"><ul>SUPPORTING<\/ul><\/div>\s*<\/aside>/s')
|
|
->not->toContain('data-md-supporting-pane-handle')
|
|
->not->toContain('x-data');
|
|
});
|
|
|
|
it('takes the default slot as the focus pane', function () {
|
|
expect((string) $this->blade('<x-supporting-pane>MAIN<x-slot:supporting>SIDE</x-slot:supporting></x-supporting-pane>'))
|
|
->toMatch('/<div data-md-supporting-pane-main>\s*MAIN\s*<\/div>/');
|
|
});
|
|
|
|
it('splits the window two-thirds to one-third, or keeps the fixed pane for anything else', function () {
|
|
expect(layoutRoot((string) $this->blade('<x-supporting-pane width="split" />'))['data-md-width'])->toBe('split')
|
|
->and(layoutRoot((string) $this->blade('<x-supporting-pane width="half" />'))['data-md-width'])->toBe('fixed');
|
|
});
|
|
|
|
it('names the supporting pane with its label', function () {
|
|
expect((string) $this->blade('<x-supporting-pane label="Comments" />'))->toMatch('/<aside\s+data-md-supporting-pane-supporting\s+aria-label="Comments"/');
|
|
});
|
|
|
|
it('docks the supporting pane as a bottom sheet below expanded, opened by its handle', function () {
|
|
$html = (string) $this->blade('<x-supporting-pane compact="sheet" label="Comments">MAIN<x-slot:supporting>SIDE</x-slot:supporting></x-supporting-pane>');
|
|
|
|
preg_match('/aria-controls="([^"]+)"/', $html, $controls);
|
|
|
|
expect(layoutRoot($html)['data-md-compact'])->toBe('sheet')
|
|
->and($html)->toContain('x-data="{ sheetOpen: false }"')
|
|
->toContain("x-bind:data-md-open=\"sheetOpen ? '' : null\"")
|
|
->toContain('x-on:keydown.escape="if (sheetOpen && $refs.handle.checkVisibility()) { $event.preventDefault(); sheetOpen = false; $refs.handle.focus() }"')
|
|
->toMatch('/<button\s+type="button"\s+class="md-state-layer md-focus-ring"\s+data-md-supporting-pane-handle\s+aria-expanded="false"/')
|
|
->toContain('x-bind:aria-expanded="sheetOpen.toString()"')
|
|
->toMatch('/<span data-md-supporting-pane-grip aria-hidden="true"><\/span>\s*<span class="md-type-title-sm" data-md-supporting-pane-label>Comments<\/span>/')
|
|
->toContain('<div data-md-supporting-pane-body id="'.$controls[1].'">SIDE</div>')
|
|
->and((string) $this->blade('<x-supporting-pane compact="sheet" />'))->toMatch('/data-md-supporting-pane-handle[^>]*aria-label="Show more"/s')
|
|
->and(layoutRoot((string) $this->blade('<x-supporting-pane compact="drawer" />'))['data-md-compact'])->toBe('below');
|
|
});
|
|
|
|
it('places the supporting pane at M3\'s widths from expanded', function () {
|
|
$css = (string) file_get_contents(__DIR__.'/../../../resources/css/layout/supporting-pane.css');
|
|
|
|
expect($css)->toContain("@media (width >= 840px) {\n grid-template-columns: minmax(0, 1fr) 360px;")
|
|
->toContain("@media (width >= 1200px) {\n grid-template-columns: minmax(0, 1fr) 412px;")
|
|
->toContain("[data-md-supporting-pane][data-md-width='split'] {\n grid-template-columns: minmax(0, 2fr) minmax(0, 1fr);")
|
|
->toContain('inset-block-end: max(var(--material-bottom-bar, 0px), var(--material-safe-bottom, env(safe-area-inset-bottom)));');
|
|
});
|