Andreas Reinhold / reiniandClaude Opus 5
247c596c3a
An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
88 lines
3.6 KiB
PHP
88 lines
3.6 KiB
PHP
<?php
|
|
|
|
use NoNameWeb\LivewireMaterial\Support\Scheme;
|
|
|
|
use function Orchestra\Testbench\workbench_path;
|
|
|
|
/*
|
|
* The Workbench's three profiles (baseline, teal, rose), generated into its stylesheet. Tests other
|
|
* than these run without profiles, so each one here points the package at the scheme file.
|
|
*/
|
|
|
|
beforeEach(function () {
|
|
config(['livewire-material.scheme' => workbench_path('resources/css/material-scheme.json')]);
|
|
|
|
$this->profiles = json_decode(file_get_contents(workbench_path('resources/css/material-scheme.json')), true)['profiles'];
|
|
});
|
|
|
|
afterEach(function () {
|
|
Scheme::resolveProfileUsing(null);
|
|
});
|
|
|
|
/**
|
|
* A #rrggbb hex as the rgb() a computed style reports.
|
|
*/
|
|
function rgb(string $hex): string
|
|
{
|
|
[$red, $green, $blue] = sscanf($hex, '#%02x%02x%02x');
|
|
|
|
return "rgb({$red}, {$green}, {$blue})";
|
|
}
|
|
|
|
/**
|
|
* The page's primary colour role, as <html> resolves it.
|
|
*/
|
|
function pagePrimary(): string
|
|
{
|
|
return "getComputedStyle(document.documentElement).getPropertyValue('--md-sys-color-primary').trim()";
|
|
}
|
|
|
|
function profilesReady(mixed $page): mixed
|
|
{
|
|
return ready($page);
|
|
}
|
|
|
|
it('draws each profile in light and dark, and the default without the attribute', function () {
|
|
$page = profilesReady(visit('/material/colour')->inLightMode())
|
|
->assertScript("document.documentElement.getAttribute('data-scheme') === 'baseline'")
|
|
->assertScript(pagePrimary()." === '{$this->profiles['baseline']['light']['primary']}'");
|
|
|
|
$page->script("document.documentElement.setAttribute('data-scheme', 'teal')");
|
|
$page->assertScript(pagePrimary()." === '{$this->profiles['teal']['light']['primary']}'");
|
|
|
|
$page->script("document.documentElement.setAttribute('data-theme', 'dark')");
|
|
$page->assertScript(pagePrimary()." === '{$this->profiles['teal']['dark']['primary']}'")
|
|
// A panel that sets its own theme keeps the page's profile.
|
|
->assertScript("getComputedStyle(document.querySelector('#colour [data-theme=\"light\"] [data-md-showcase-swatch=\"primary\"]')).backgroundColor === '".rgb($this->profiles['teal']['light']['primary'])."'");
|
|
|
|
$page->script("document.documentElement.removeAttribute('data-scheme')");
|
|
$page->assertScript(pagePrimary()." === '{$this->profiles['baseline']['dark']['primary']}'")
|
|
->assertNoJavaScriptErrors();
|
|
});
|
|
|
|
it('previews a profile from the picker and the showcase menu, and keeps it through wire:navigate', function () {
|
|
$page = profilesReady(visit('/material/colour')->inLightMode());
|
|
|
|
$page->click('#colour [data-md-scheme-picker-option="rose"]')
|
|
->assertScript("document.documentElement.getAttribute('data-scheme') === 'rose'")
|
|
->assertScript(pagePrimary()." === '{$this->profiles['rose']['light']['primary']}'")
|
|
->assertScript("window.eval(\"Alpine.store('theme').scheme\") === 'rose'");
|
|
|
|
$page->click('[data-test="showcase-profiles"] [aria-haspopup="menu"]')
|
|
->click('[data-scheme-preview="teal"]')
|
|
->assertScript("document.documentElement.getAttribute('data-scheme') === 'teal'");
|
|
|
|
$page->click('[data-md-navigation-rail-panel] a[href$="/material/buttons"]')
|
|
->assertScript("location.pathname.endsWith('/material/buttons')")
|
|
->assertScript("document.documentElement.getAttribute('data-scheme') === 'teal'")
|
|
->assertNoJavaScriptErrors();
|
|
});
|
|
|
|
it('paints the profile the application resolves from the first frame', function () {
|
|
Scheme::resolveProfileUsing(fn (): string => 'rose');
|
|
|
|
profilesReady(visit('/material')->inDarkMode())
|
|
->assertScript("document.documentElement.getAttribute('data-scheme') === 'rose'")
|
|
->assertScript(pagePrimary()." === '{$this->profiles['rose']['dark']['primary']}'");
|
|
});
|