Andreas Reinhold / reiniandClaude Opus 5
247c596c3a
An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
85 lines
3.6 KiB
CSS
85 lines
3.6 KiB
CSS
/*
|
|
* <x-collapse>: not an M3 component — M3 has expandable list items and menu expansion but no
|
|
* standalone disclosure — built on the native `<details>` so it opens without script, keeps its
|
|
* state through a Livewire morph, and is announced as a disclosure by the browser. Judged against
|
|
* foundations rather than any M3 component spec, since M3 has no standalone disclosure.
|
|
*
|
|
* The height eases open and shut on the fast spatial spring, the same one that turns the chevron,
|
|
* from resources/js/collapse.js: it animates the `<details>`' own `block-size`. This file cannot —
|
|
* `interpolate-size` (for `0 -> auto`) is Chrome's alone, and Firefox does not hold the content's
|
|
* `content-visibility` through a close — so Firefox and Safari used to snap open and shut. While a
|
|
* close runs, `open` is still set and `data-md-collapse-closing` turns the chevron back at its
|
|
* start. Under reduced motion the duration token is zero (tokens/motion.css), and the section
|
|
* snaps, as the browser draws it.
|
|
*
|
|
* `data-md-variant="filled"` is a surface-container tile with a large corner; the summary inherits
|
|
* it (`border-radius: inherit`) so the shared `md-state-layer`'s own `::before`, which also
|
|
* inherits, draws inside the same shape. `md-state-layer` and `md-focus-ring`
|
|
* (foundation/interaction.css) sit on the summary; this file only refines their target — the
|
|
* 48px summary height, the icon and chevron colour — never their opacities or ring.
|
|
*
|
|
* Icon-to-title and title-to-chevron gaps are a literal 12px: the measurement scale has no 12
|
|
* (`space125` is 10px), as alert.css's gap. Every part is matched as its own `<details>`' child, so
|
|
* a collapse nested in a filled one takes neither its padding nor its turned chevron.
|
|
*/
|
|
|
|
@layer material.reset, material.tokens, material.base, material.layout, material.components, material.text, material.visibility;
|
|
|
|
@import './icon.css';
|
|
|
|
@layer material.components {
|
|
[data-md-collapse][data-md-variant='filled'] {
|
|
border-radius: var(--md-sys-shape-corner-lg);
|
|
background-color: var(--md-sys-color-surface-container);
|
|
}
|
|
|
|
[data-md-collapse-summary] {
|
|
display: flex;
|
|
min-block-size: var(--md-sys-measurement-space600);
|
|
align-items: center;
|
|
gap: 12px;
|
|
border-radius: inherit;
|
|
cursor: pointer;
|
|
list-style-type: none;
|
|
font: var(--md-sys-typescale-title-md);
|
|
letter-spacing: var(--md-sys-typescale-title-md-tracking);
|
|
|
|
&::-webkit-details-marker {
|
|
display: none;
|
|
}
|
|
}
|
|
|
|
[data-md-collapse][data-md-variant='filled'] > [data-md-collapse-summary] {
|
|
padding-inline: var(--md-sys-measurement-space200);
|
|
}
|
|
|
|
[data-md-collapse-icon] {
|
|
color: var(--md-sys-color-on-surface-variant);
|
|
}
|
|
|
|
[data-md-collapse-title] {
|
|
min-width: 0;
|
|
flex: 1 1 0%;
|
|
}
|
|
|
|
[data-md-collapse-chevron] {
|
|
color: var(--md-sys-color-on-surface-variant);
|
|
transition: rotate var(--md-sys-motion-spatial-fast-duration) var(--md-sys-motion-spatial-fast);
|
|
}
|
|
|
|
[data-md-collapse][open]:not([data-md-collapse-closing]) > [data-md-collapse-summary] > [data-md-collapse-chevron] {
|
|
rotate: 180deg;
|
|
}
|
|
|
|
[data-md-collapse-body] {
|
|
padding-block: var(--md-sys-measurement-space50) var(--md-sys-measurement-space200);
|
|
color: var(--md-sys-color-on-surface-variant);
|
|
font: var(--md-sys-typescale-body-md);
|
|
letter-spacing: var(--md-sys-typescale-body-md-tracking);
|
|
}
|
|
|
|
[data-md-collapse][data-md-variant='filled'] > [data-md-collapse-body] {
|
|
padding-inline: var(--md-sys-measurement-space200);
|
|
}
|
|
}
|