Andreas Reinhold / reiniandClaude Opus 5
247c596c3a
An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
159 lines
7.0 KiB
CSS
159 lines
7.0 KiB
CSS
/*
|
|
* <x-menu-item>: one row in an `<x-menu>` — an action, a link, or a choice — and, with `submenu`,
|
|
* the trigger and popover of a nested menu beside it.
|
|
*
|
|
* SegmentedMenuTokens (androidx Compose Material 3, Apache-2.0): 48px row (M3's published "List
|
|
* item height" wins over the token's own 44dp `Item`), 16px either side
|
|
* (`ItemLeadingSpace`/`ItemTrailingSpace`), 12px between the icon, the label and the trailing
|
|
* content (`ItemBetweenSpace`, off the 8dp grid), 4px corners (`ItemShape`) that open to 12px at
|
|
* either end of the list (`ItemFirstChildShape`/`ItemLastChildShape` — the library's own list
|
|
* ends, 12px, win over `GroupShape`'s 8dp so a cluster's ends and a list's ends match,
|
|
* menu-group.css). A selected row (`role="menuitemcheckbox"`, the tick beside the colour and
|
|
* shape) takes `ItemSelectedShape`'s 12px corner in tertiary-container; `current` — a menu of
|
|
* places rather than choices — takes the same 12px corner in secondary-container, the
|
|
* navigation-indicator role. `description` (`ItemSupportingTextFont`) grows the row by 8px top
|
|
* and bottom; `shortcut` (`ItemTrailingSupportingTextFont`) sits at the end. Every quiet part of
|
|
* the row — the icon, the description, the trailing text — inks together as
|
|
* `--md-menu-item-ink`; corner and colour are two springs, not one — a colour must never
|
|
* overshoot — and `icon-class` paints only the leading icon, over that ink but never over
|
|
* disabled. The row renders the foundation's `md-state-layer` and `md-focus-ring`
|
|
* (foundation/interaction.css) — no `md-touch-target`, since the row is already 48px tall — and
|
|
* keeps only one refinement: the ring reads inward (-3px), because a row sits edge to edge in the
|
|
* list and an outward one would run past it. A disabled item stays focusable and keeps its ring,
|
|
* because M3 keeps it reachable, but the class already withholds the layer from `aria-disabled`.
|
|
*
|
|
* `submenu` turns the row into the WAI-ARIA menu button for a second `role="menu"` popover beside
|
|
* it, anchored to its end and flipping to the start where the window has no room
|
|
* (resources/js/menu.js). The popover shares its container colour with the menu it opens from
|
|
* through `--material-menu-surface`/`--material-menu-ink` (menu.css defines them on
|
|
* `[data-md-menu-popover]`; the fallbacks here are the standard menu's, for a submenu inside some
|
|
* other list, e.g. a FAB menu's). Inside an `<x-menu sheet-at-compact>` sheet the same markup
|
|
* opens in place instead — menu.css restyles `[data-md-submenu]` and `[data-md-submenu-chevron]`
|
|
* there.
|
|
*/
|
|
|
|
@layer material.reset, material.tokens, material.base, material.layout, material.components, material.text, material.visibility;
|
|
|
|
@import './icon.css';
|
|
@import './badge.css';
|
|
@import './menu.css';
|
|
|
|
@layer material.components {
|
|
[data-md-menu-item] {
|
|
--md-menu-item-ink: var(--md-sys-color-on-surface-variant);
|
|
|
|
display: flex;
|
|
inline-size: 100%;
|
|
min-block-size: var(--md-sys-measurement-space600);
|
|
align-items: center;
|
|
gap: 12px;
|
|
padding-inline: var(--md-sys-measurement-space200);
|
|
border-radius: var(--md-sys-shape-corner-xs);
|
|
background-color: transparent;
|
|
color: var(--md-sys-color-on-surface);
|
|
text-align: start;
|
|
cursor: pointer;
|
|
-webkit-user-select: none;
|
|
user-select: none;
|
|
transition-property: border-radius, background-color, color;
|
|
transition-duration:
|
|
var(--md-sys-motion-spatial-fast-duration),
|
|
var(--md-sys-motion-effects-fast-duration), var(--md-sys-motion-effects-fast-duration);
|
|
transition-timing-function:
|
|
var(--md-sys-motion-spatial-fast),
|
|
var(--md-sys-motion-effects-fast), var(--md-sys-motion-effects-fast);
|
|
|
|
/* The row sits edge to edge in the list, so the ring reads inward, not past the item. */
|
|
&:focus-visible {
|
|
outline-offset: -3px;
|
|
}
|
|
}
|
|
|
|
[data-md-menu-item]:first-child {
|
|
border-start-start-radius: var(--md-sys-shape-corner-md);
|
|
border-start-end-radius: var(--md-sys-shape-corner-md);
|
|
}
|
|
|
|
[data-md-menu-item]:last-child {
|
|
border-end-start-radius: var(--md-sys-shape-corner-md);
|
|
border-end-end-radius: var(--md-sys-shape-corner-md);
|
|
}
|
|
|
|
[data-md-menu-item][data-md-description] {
|
|
padding-block: var(--md-sys-measurement-space100);
|
|
}
|
|
|
|
[data-md-menu-item][aria-checked='true'] {
|
|
--md-menu-item-ink: var(--md-sys-color-on-tertiary-container);
|
|
|
|
border-radius: var(--md-sys-shape-corner-md);
|
|
background-color: var(--md-sys-color-tertiary-container);
|
|
color: var(--md-sys-color-on-tertiary-container);
|
|
}
|
|
|
|
[data-md-menu-item][aria-current='page']:not([aria-checked='true']) {
|
|
--md-menu-item-ink: var(--md-sys-color-on-secondary-container);
|
|
|
|
border-radius: var(--md-sys-shape-corner-md);
|
|
background-color: var(--md-sys-color-secondary-container);
|
|
color: var(--md-sys-color-on-secondary-container);
|
|
}
|
|
|
|
[data-md-menu-item][aria-disabled='true'] {
|
|
--md-menu-item-ink: color-mix(in srgb, var(--md-sys-color-on-surface) calc(var(--md-sys-state-disabled-content-opacity) * 100%), transparent);
|
|
|
|
pointer-events: none;
|
|
color: var(--md-menu-item-ink);
|
|
}
|
|
|
|
[data-md-menu-item] [data-md-icon] {
|
|
color: var(--md-menu-item-ink);
|
|
}
|
|
|
|
[data-md-menu-item][aria-disabled='true'] [data-md-icon] {
|
|
color: color-mix(in srgb, var(--md-sys-color-on-surface) calc(var(--md-sys-state-disabled-content-opacity) * 100%), transparent) !important;
|
|
}
|
|
|
|
[data-md-menu-item-text] {
|
|
min-inline-size: 0;
|
|
flex: 1;
|
|
}
|
|
|
|
[data-md-menu-item-label] {
|
|
display: block;
|
|
overflow: hidden;
|
|
white-space: nowrap;
|
|
text-overflow: ellipsis;
|
|
font: var(--md-sys-typescale-body-lg);
|
|
letter-spacing: var(--md-sys-typescale-body-lg-tracking);
|
|
font-variation-settings: normal;
|
|
}
|
|
|
|
[data-md-menu-item-description] {
|
|
display: block;
|
|
color: var(--md-menu-item-ink);
|
|
font: var(--md-sys-typescale-body-md);
|
|
letter-spacing: var(--md-sys-typescale-body-md-tracking);
|
|
font-variation-settings: normal;
|
|
}
|
|
|
|
[data-md-menu-item-shortcut] {
|
|
flex-shrink: 0;
|
|
color: var(--md-menu-item-ink);
|
|
font: var(--md-sys-typescale-label-sm);
|
|
letter-spacing: var(--md-sys-typescale-label-sm-tracking);
|
|
font-variation-settings: normal;
|
|
}
|
|
|
|
/* The submenu popover: a menu of its own, sharing the container colour of the list it opens
|
|
from. Its size, radius, padding, shadow and pop-and-fade entry/exit are menu.css's shared
|
|
popover chrome (imported above); only its axis and its position are its own — inline,
|
|
beside the item, rather than the standard menu's block axis under its trigger. */
|
|
[data-md-submenu] {
|
|
margin: 0 var(--md-sys-measurement-space50);
|
|
transform-origin: top;
|
|
position-area: inline-end span-block-end;
|
|
position-try-fallbacks: flip-inline;
|
|
}
|
|
}
|