Andreas Reinhold / reiniandClaude Opus 5
247c596c3a
An over-engineering audit of the whole tree, applied in five reviewed batches. Behaviour stays the same except where UPGRADE.md says otherwise. PHP: the showcase and error-page stylesheets are prebuilt into resources/dist by bin/stylesheets.mjs, through Vite's own postcss-import (first occurrence kept, the order an application's build gives), instead of Stylesheets::bundle() inlining imports on every request; only the import walk DesignGuard needs stays. SchemeStylesheet::withProfiles() replaces three copies of the scheme-plus-profiles loop, material:scheme leaves spec and contrast checks to the node script that already made them, and the error page's scheme cache, the hashed view namespace, the translations path with no lang/ folder and DesignGuard's 1.x-name hints are gone. JS: the androidx shape port progress.js and both bin scripts each carried lives once in resources/js/shapes.js (the generated SVGs are unchanged); util.js holds ringIndex(), ms(), reopenGuard() and remember(), which were written out several times; listeners are released through AbortController; tooltip.js's hoverPopover() serves the rich tooltip too. CSS: every rule for an element inside the navigation rail queries `--md-navigation-rail-value` instead of repeating the seven collapsed conditions under five media branches; badge, alert, progress, slider and button read one non-inheriting colour-role table (components/color.css); the dialog chrome, the submenu's popover chrome, the chip's state layer and touch target, and the visually-hidden inputs use the shared rules they copied; foundation/tokens.css is folded into foundation.css. Views: Support\Field and Support\Link replace the error-key, bound-value and link-attribute blocks copied into the fields and link components; the timepicker period group, the menu filter and the showcase head are partials; the datepicker's steppers and entry fields are loops; component docblocks no longer restate SKILL.md. Tests and tooling: one dataset-driven ComponentStylesheetsTest replaces four per-group files, DesignGuardTest and the layout-component tests use datasets, browser tests share one ready() helper, CSS parsing lives in ComponentStylesheet alone. docs/audits and the finding IDs citing it are removed, as are pestphp/pest-plugin-laravel, the unused composer scripts and check:font; the lint job runs in the feature job, which now installs node packages so the prebuilt-stylesheet staleness test runs in CI. Feature suite 1177 passed, Chrome browser suite 299 passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
65 lines
2.3 KiB
JavaScript
65 lines
2.3 KiB
JavaScript
/**
|
|
* `materialFab`: `<x-fab collapse-on-scroll>` — M3's extended FAB that collapses to a FAB while the
|
|
* page scrolls down and extends again on the way back up, or once the page is at the top.
|
|
*
|
|
* Only the flag lives here. The morph itself is CSS (resources/css/components/fab.css), which is
|
|
* how it stays on the spatial spring and how reduced motion makes it instant without a second
|
|
* path through this file.
|
|
*
|
|
* It watches the window, which is what a FAB pinned to the corner of the page scrolls against. A
|
|
* FAB inside a scrolling pane of its own is not this.
|
|
*/
|
|
|
|
// Scrolling is noisy — a wheel's own wobble, a rubber-band bounce at either end — and a FAB that
|
|
// flipped on every pixel would never be still. A move has to be worth this much to count as a
|
|
// direction, and one worth less is kept and added to the next.
|
|
const STEP_PX = 8
|
|
|
|
// Within this much of the top the FAB is extended whichever way the page was last going: M3
|
|
// re-expands it "at the bottom of the view", which on a web page is where the page begins.
|
|
const TOP_PX = 24
|
|
|
|
document.addEventListener('alpine:init', () => {
|
|
window.Alpine.data('materialFab', () => ({
|
|
collapsed: false,
|
|
lastY: 0,
|
|
frame: null,
|
|
// Set in init(). Declared here, or Alpine writes them to the outermost x-data scope,
|
|
// where a second FAB in the same page scope would take the first one's listener.
|
|
schedule: null,
|
|
|
|
init() {
|
|
this.lastY = Math.max(window.scrollY, 0)
|
|
this.schedule = () => {
|
|
this.frame ??= requestAnimationFrame(() => this.measure())
|
|
}
|
|
|
|
window.addEventListener('scroll', this.schedule, { passive: true })
|
|
},
|
|
|
|
destroy() {
|
|
window.removeEventListener('scroll', this.schedule)
|
|
cancelAnimationFrame(this.frame)
|
|
},
|
|
|
|
measure() {
|
|
this.frame = null
|
|
|
|
const y = Math.max(window.scrollY, 0)
|
|
const moved = y - this.lastY
|
|
|
|
if (y <= TOP_PX) {
|
|
this.collapsed = false
|
|
} else if (moved > STEP_PX) {
|
|
this.collapsed = true
|
|
} else if (moved < -STEP_PX) {
|
|
this.collapsed = false
|
|
}
|
|
|
|
if (Math.abs(moved) > STEP_PX || y <= TOP_PX) {
|
|
this.lastY = y
|
|
}
|
|
},
|
|
}))
|
|
})
|